Skip to content

Commit 370b254

Browse files
Removing obsolete code, EOD is handled by DPL
Sending of control events in the TPCSector header has been removed from all workflows a while ago.
1 parent e5ef406 commit 370b254

2 files changed

Lines changed: 0 additions & 36 deletions

File tree

Detectors/GlobalTrackingWorkflow/src/TPCITSMatchingSpec.cxx

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -96,19 +96,6 @@ void TPCITSMatchingDPL::run(ProcessingContext& pc)
9696
throw std::runtime_error("sector header missing on header stack");
9797
}
9898
const int& sector = sectorHeader->sector();
99-
// check the current operation, this is used to either signal eod or noop
100-
// FIXME: the noop is not needed any more once the lane configuration with one
101-
// channel per sector is used
102-
if (sector < 0) {
103-
if (operation < 0 && operation != sector) {
104-
// we expect the same operation on all inputs
105-
LOG(ERROR) << "inconsistent lane operation, got " << sector << ", expecting " << operation;
106-
} else if (operation == 0) {
107-
// store the operation
108-
operation = sector;
109-
}
110-
continue;
111-
}
11299
// the TPCSectorHeader now allows to transport information for more than one sector,
113100
// e.g. for transporting clusters in one single data block. For the moment, the
114101
// implemenation here requires single sectors
@@ -126,11 +113,6 @@ void TPCITSMatchingDPL::run(ProcessingContext& pc)
126113
datarefs[sector] = ref;
127114
}
128115

129-
if (operation == -1) {
130-
// EOD is transmitted in the sectorHeader with sector number equal to -1
131-
LOG(WARNING) << "operation = " << operation;
132-
}
133-
134116
auto printInputLog = [&validSectors, &activeSectors](auto& r, const char* comment, auto& s) {
135117
LOG(INFO) << comment << " " << *(r.spec) << ", size " << DataRefUtils::getPayloadSize(r) //
136118
<< " for sector " << s //

Detectors/GlobalTrackingWorkflow/tpcinterpolationworkflow/src/TPCInterpolationSpec.cxx

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -67,19 +67,6 @@ void TPCInterpolationDPL::run(ProcessingContext& pc)
6767
throw std::runtime_error("sector header missing on header stack");
6868
}
6969
const int& sector = sectorHeader->sector();
70-
// check the current operation, this is used to either signal eod or noop
71-
// FIXME: the noop is not needed any more once the lane configuration with one
72-
// channel per sector is used
73-
if (sector < 0) {
74-
if (operation < 0 && operation != sector) {
75-
// we expect the same operation on all inputs
76-
LOG(ERROR) << "inconsistent lane operation, got " << sector << ", expecting " << operation;
77-
} else if (operation == 0) {
78-
// store the operation
79-
operation = sector;
80-
}
81-
continue;
82-
}
8370
// the TPCSectorHeader now allows to transport information for more than one sector,
8471
// e.g. for transporting clusters in one single data block. For the moment, the
8572
// implemenation here requires single sectors
@@ -97,11 +84,6 @@ void TPCInterpolationDPL::run(ProcessingContext& pc)
9784
datarefs[sector] = ref;
9885
}
9986

100-
if (operation == -1) {
101-
// EOD is transmitted in the sectorHeader with sector number equal to -1
102-
LOG(WARNING) << "operation = " << operation;
103-
}
104-
10587
auto printInputLog = [&validSectors, &activeSectors](auto& r, const char* comment, auto& s) {
10688
LOG(INFO) << comment << " " << *(r.spec) << ", size " << DataRefUtils::getPayloadSize(r) //
10789
<< " for sector " << s //

0 commit comments

Comments
 (0)