Avoid memmove if there is nothing to move

shahor02 · shahor02 · commit 79a0fe0d8da2 · 2024-01-14T13:35:46.000+01:00
To avoid UD with nullptr passed to memmove.
diff --git a/GPU/Utils/FlatObject.h b/GPU/Utils/FlatObject.h
@@ -132,7 +132,10 @@ T* resizeArray(T*& ptr, int oldSize, int newSize, T* newPtr = nullptr)
       newPtr = new T[newSize];
     }
     int mcp = std::min(newSize, oldSize);
-    std::memmove(newPtr, ptr, mcp * sizeof(T));
+    if (mcp) {
+      assert(ptr);
+      std::memmove(newPtr, ptr, mcp * sizeof(T));
+    }
     if (newSize > oldSize) {
       std::memset(newPtr + mcp, 0, (newSize - oldSize) * sizeof(T));
     }

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,10 @@ T* resizeArray(T& ptr, int oldSize, int newSize, T newPtr = nullptr)`
`132`	`132`	`newPtr = new T[newSize];`
`133`	`133`	`}`
`134`	`134`	`int mcp = std::min(newSize, oldSize);`
`135`		`- std::memmove(newPtr, ptr, mcp * sizeof(T));`
	`135`	`+ if (mcp) {`
	`136`	`+ assert(ptr);`
	`137`	`+ std::memmove(newPtr, ptr, mcp * sizeof(T));`
	`138`	`+ }`
`136`	`139`	`if (newSize > oldSize) {`
`137`	`140`	`std::memset(newPtr + mcp, 0, (newSize - oldSize) * sizeof(T));`
`138`	`141`	`}`