ITS: Accounting for empty chipID vector after decoding

Kirill Naumov · shahor02 · commit bdb541f5d2e1 · 2024-07-05T13:48:01.000+02:00
The current implementation causes a segfault for empty chipID vector
diff --git a/Detectors/ITSMFT/common/reconstruction/include/ITSMFTReconstruction/RUDecodeData.h b/Detectors/ITSMFT/common/reconstruction/include/ITSMFTReconstruction/RUDecodeData.h
@@ -120,7 +120,7 @@ int RUDecodeData::decodeROF(const Mapping& mp, const o2::InteractionRecord ir, b
         auto ID = chipData->getChipID();
         // Since the errored chips are not recorded, we need to add them
         // separately
-        if (seenChipIDsInCable.back() != ID) {
+        if (seenChipIDsInCable.empty() || seenChipIDsInCable.back() != ID) {
           seenChipIDsInCable.push_back(ID);
         }
         seenChips[ID] = chipData;

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ int RUDecodeData::decodeROF(const Mapping& mp, const o2::InteractionRecord ir, b`
`120`	`120`	`auto ID = chipData->getChipID();`
`121`	`121`	`// Since the errored chips are not recorded, we need to add them`
`122`	`122`	`// separately`
`123`		`- if (seenChipIDsInCable.back() != ID) {`
	`123`	`+ if (seenChipIDsInCable.empty() \|\| seenChipIDsInCable.back() != ID) {`
`124`	`124`	`seenChipIDsInCable.push_back(ID);`
`125`	`125`	`}`
`126`	`126`	`seenChips[ID] = chipData;`