fixes in TOF calibration workflow

noferini · noferini · commit f3c6fd9c19e6 · 2021-11-22T12:45:58.000+01:00
diff --git a/DataFormats/Detectors/TOF/include/DataFormatsTOF/CalibTimeSlewingParamTOF.h b/DataFormats/Detectors/TOF/include/DataFormatsTOF/CalibTimeSlewingParamTOF.h
@@ -84,6 +84,7 @@ class CalibTimeSlewingParamTOF
   }
 
   CalibTimeSlewingParamTOF& operator+=(const CalibTimeSlewingParamTOF& other);
+  void bind();
 
  private:
   std::array<int, NCHANNELXSECTOR> mChannelStartSec0;
diff --git a/DataFormats/Detectors/TOF/src/CalibTimeSlewingParamTOF.cxx b/DataFormats/Detectors/TOF/src/CalibTimeSlewingParamTOF.cxx
@@ -35,6 +35,27 @@ float CalibTimeSlewingParamTOF::getChannelOffset(int channel) const
 {
   return evalTimeSlewing(channel, 0);
 }
+void CalibTimeSlewingParamTOF::bind()
+{
+  mGlobalOffset[0] = &mGlobalOffsetSec0;
+  mGlobalOffset[1] = &mGlobalOffsetSec1;
+  mGlobalOffset[2] = &mGlobalOffsetSec2;
+  mGlobalOffset[3] = &mGlobalOffsetSec3;
+  mGlobalOffset[4] = &mGlobalOffsetSec4;
+  mGlobalOffset[5] = &mGlobalOffsetSec5;
+  mGlobalOffset[6] = &mGlobalOffsetSec6;
+  mGlobalOffset[7] = &mGlobalOffsetSec7;
+  mGlobalOffset[8] = &mGlobalOffsetSec8;
+  mGlobalOffset[9] = &mGlobalOffsetSec9;
+  mGlobalOffset[10] = &mGlobalOffsetSec10;
+  mGlobalOffset[11] = &mGlobalOffsetSec11;
+  mGlobalOffset[12] = &mGlobalOffsetSec12;
+  mGlobalOffset[13] = &mGlobalOffsetSec13;
+  mGlobalOffset[14] = &mGlobalOffsetSec14;
+  mGlobalOffset[15] = &mGlobalOffsetSec15;
+  mGlobalOffset[16] = &mGlobalOffsetSec16;
+  mGlobalOffset[17] = &mGlobalOffsetSec17;
+}
 
 //______________________________________________
 float CalibTimeSlewingParamTOF::evalTimeSlewing(int channel, float totIn) const
diff --git a/Detectors/GlobalTracking/src/MatchTOF.cxx b/Detectors/GlobalTracking/src/MatchTOF.cxx
@@ -65,6 +65,8 @@ void MatchTOF::run(const o2::globaltracking::RecoContainer& inp)
   mTimerMatchITSTPC.Reset();
   mTimerTot.Reset();
 
+  mCalibInfoTOF.clear();
+
   for (int i = 0; i < trkType::SIZEALL; i++) {
     mMatchedTracks[i].clear();
     mOutTOFLabels[i].clear();
@@ -1093,10 +1095,13 @@ void MatchTOF::selectBestMatches()
     }
 
     // add also calibration infos
-    mCalibInfoTOF.emplace_back(mTOFClusWork[matchingPair.getTOFClIndex()].getMainContributingChannel(),
-                               int(mTOFClusWork[matchingPair.getTOFClIndex()].getTimeRaw() * 1E12), // add time stamp
-                               mTOFClusWork[matchingPair.getTOFClIndex()].getTimeRaw() - intLT.getTOF(o2::track::PID::Pion) - t0info,
-                               mTOFClusWork[matchingPair.getTOFClIndex()].getTot());
+    if (sourceID == o2::dataformats::GlobalTrackID::ITSTPC) {
+      mCalibInfoTOF.emplace_back(mTOFClusWork[matchingPair.getTOFClIndex()].getMainContributingChannel(),
+                                 int(mTOFClusWork[matchingPair.getTOFClIndex()].getTimeRaw() * 1E-12), // add time stamp
+                                 mTOFClusWork[matchingPair.getTOFClIndex()].getTimeRaw() - t0info - intLT.getTOF(o2::track::PID::Pion),
+                                 mTOFClusWork[matchingPair.getTOFClIndex()].getTot());
+    }
+
     if (mMCTruthON) {
       const auto& labelsTOF = mTOFClusLabels->getLabels(matchingPair.getTOFClIndex());
       auto& labelTrack = mTracksLblWork[trkType][itrk];
diff --git a/Detectors/GlobalTrackingWorkflow/src/TOFEventTimeChecker.cxx b/Detectors/GlobalTrackingWorkflow/src/TOFEventTimeChecker.cxx
@@ -84,7 +84,7 @@ using TimeSlewing = o2::dataformats::CalibTimeSlewingParamTOF;
 
 bool MyFilter(const MyTrack& tr)
 {
-  return (tr.mP < 2.0 && tr.mEta > o2::tof::Utils::mEtaMin && tr.mEta < o2::tof::Utils::mEtaMax && tr.mHasTOF);
+  return (tr.mP < 2.0 && tr.mEta > o2::tof::Utils::mEtaMin && tr.mEta < o2::tof::Utils::mEtaMax && tr.mHasTOF && tr.mSource == 1);
 } // accept all
 
 namespace o2
diff --git a/Detectors/TOF/base/include/TOFBase/Utils.h b/Detectors/TOF/base/include/TOFBase/Utils.h
@@ -30,12 +30,12 @@ class Utils
 
   static bool hasFillScheme();
   static int getNinteractionBC();
-  static void addBC(float toftime);
-  static void addBC(double toftime) { addBC(float(toftime)); }
-  static void addInteractionBC(int bc) { mFillScheme.push_back(bc); }
+  static void addBC(float toftime, bool subLatency = false);
+  static void addBC(double toftime, bool subLatency = false) { addBC(float(toftime), subLatency); }
+  static void addInteractionBC(int bc, bool subLatency = false) { mFillScheme.push_back(bc); }
   static int getInteractionBC(int ibc) { return mFillScheme[ibc]; }
-  static double subtractInteractionBC(double time);
-  static float subtractInteractionBC(float time);
+  static double subtractInteractionBC(double time, bool subLatency = false);
+  static float subtractInteractionBC(float time, bool subLatency = false);
   static void init();
   static void printFillScheme();
 
diff --git a/Detectors/TOF/base/src/Utils.cxx b/Detectors/TOF/base/src/Utils.cxx
@@ -52,9 +52,21 @@ int Utils::getNinteractionBC()
   return mFillScheme.size();
 }
 
-double Utils::subtractInteractionBC(double time)
+double Utils::subtractInteractionBC(double time, bool subLatency)
 {
+  static const int deltalat = o2::tof::Geo::BC_IN_ORBIT - o2::tof::Geo::LATENCYWINDOW_IN_BC;
   int bc = int(time * o2::tof::Geo::BC_TIME_INPS_INV + 0.2);
+
+  if (subLatency) {
+    if (bc >= o2::tof::Geo::LATENCYWINDOW_IN_BC) {
+      bc -= o2::tof::Geo::LATENCYWINDOW_IN_BC;
+      time -= o2::tof::Geo::LATENCYWINDOW_IN_BC * o2::tof::Geo::BC_TIME_INPS;
+    } else {
+      bc += deltalat;
+      time += deltalat * o2::tof::Geo::BC_TIME_INPS;
+    }
+  }
+
   int bcOrbit = bc % o2::constants::lhc::LHCMaxBunches;
 
   int dbc = o2::constants::lhc::LHCMaxBunches, bcc = bc;
@@ -77,9 +89,21 @@ double Utils::subtractInteractionBC(double time)
   return time;
 }
 
-float Utils::subtractInteractionBC(float time)
+float Utils::subtractInteractionBC(float time, bool subLatency)
 {
+  static const int deltalat = o2::tof::Geo::BC_IN_ORBIT - o2::tof::Geo::LATENCYWINDOW_IN_BC;
   int bc = int(time * o2::tof::Geo::BC_TIME_INPS_INV + 0.2);
+
+  if (subLatency) {
+    if (bc >= o2::tof::Geo::LATENCYWINDOW_IN_BC) {
+      bc -= o2::tof::Geo::LATENCYWINDOW_IN_BC;
+      time -= o2::tof::Geo::LATENCYWINDOW_IN_BC * o2::tof::Geo::BC_TIME_INPS;
+    } else {
+      bc += deltalat;
+      time += deltalat * o2::tof::Geo::BC_TIME_INPS;
+    }
+  }
+
   int bcOrbit = bc % o2::constants::lhc::LHCMaxBunches;
 
   int dbc = o2::constants::lhc::LHCMaxBunches, bcc = bc;
@@ -88,13 +112,21 @@ float Utils::subtractInteractionBC(float time)
       bcc = bc - bcOrbit + getInteractionBC(k);
       dbc = abs(bcOrbit - getInteractionBC(k));
     }
+    if (abs(bcOrbit - getInteractionBC(k) + o2::constants::lhc::LHCMaxBunches) < dbc) { // in case k is close to the right border (last BC of the orbit)
+      bcc = bc - bcOrbit + getInteractionBC(k) - o2::constants::lhc::LHCMaxBunches;
+      dbc = abs(bcOrbit - getInteractionBC(k) + o2::constants::lhc::LHCMaxBunches);
+    }
+    if (abs(bcOrbit - getInteractionBC(k) - o2::constants::lhc::LHCMaxBunches) < dbc) { // in case k is close to the left border (BC=0)
+      bcc = bc - bcOrbit + getInteractionBC(k) + o2::constants::lhc::LHCMaxBunches;
+      dbc = abs(bcOrbit - getInteractionBC(k) - o2::constants::lhc::LHCMaxBunches);
+    }
   }
   time -= o2::tof::Geo::BC_TIME_INPS * bcc;
 
   return time;
 }
 
-void Utils::addBC(float toftime)
+void Utils::addBC(float toftime, bool subLatency)
 {
   if (!mIsInit) {
     init();
@@ -114,8 +146,19 @@ void Utils::addBC(float toftime)
   }
 
   // just fill
+  static const int deltalat = o2::tof::Geo::BC_IN_ORBIT - o2::tof::Geo::LATENCYWINDOW_IN_BC;
   int bc = int(toftime * o2::tof::Geo::BC_TIME_INPS_INV + 0.2) % o2::constants::lhc::LHCMaxBunches;
 
+  if (subLatency) {
+    if (bc >= o2::tof::Geo::LATENCYWINDOW_IN_BC) {
+      bc -= o2::tof::Geo::LATENCYWINDOW_IN_BC;
+      toftime -= o2::tof::Geo::LATENCYWINDOW_IN_BC * o2::tof::Geo::BC_TIME_INPS;
+    } else {
+      bc += deltalat;
+      toftime += deltalat * o2::tof::Geo::BC_TIME_INPS;
+    }
+  }
+
   mBCmult[bc]++;
 
   if (mBCmult[bc] > mMaxBC) {
diff --git a/Detectors/TOF/calibration/include/TOFCalibration/TOFChannelCalibrator.h b/Detectors/TOF/calibration/include/TOFCalibration/TOFChannelCalibrator.h
@@ -37,6 +37,13 @@
 #include "CCDB/CcdbApi.h"
 #include <boost/format.hpp>
 
+//#define DEBUGGING
+
+#ifdef DEBUGGING
+#include "TProfile.h"
+#include "TH2F.h"
+#endif
+
 using o2::math_utils::fitGaus;
 
 namespace o2
@@ -59,7 +66,11 @@ class TOFChannelData
     LOG(INFO) << "Default c-tor, not to be used";
   }
 
+#ifndef DEBUGGING
   TOFChannelData(int nb, float r, CalibTOFapi* cta, int nElsPerSector = o2::tof::Geo::NPADSXSECTOR, bool perstrip = false, bool safe = false) : mNBins(nb), mRange(r), mCalibTOFapi(cta), mNElsPerSector(nElsPerSector), mPerStrip(perstrip), mSafeMode(safe)
+#else
+  TOFChannelData(int nb, float r, CalibTOFapi* cta, int nElsPerSector = o2::tof::Geo::NPADSXSECTOR, bool perstrip = false, bool safe = false, TH2F* h = nullptr) : mNBins(nb), mRange(r), mCalibTOFapi(cta), mNElsPerSector(nElsPerSector), mPerStrip(perstrip), mSafeMode(safe), mChannelDist(h)
+#endif
   {
     if (r <= 0. || nb < 1) {
       throw std::runtime_error("Wrong initialization of the histogram");
@@ -111,6 +122,10 @@ class TOFChannelData
   std::array<boostHisto, 18> mHisto;
   std::vector<int> mEntries; // vector containing number of entries per channel
 
+#ifdef DEBUGGING
+  TH2F* mChannelDist;
+#endif
+
   CalibTOFapi* mCalibTOFapi = nullptr; // calibTOFapi to correct the t-text
   int mNElsPerSector = o2::tof::Geo::NPADSXSECTOR;
 
@@ -131,6 +146,11 @@ class TOFChannelCalibrator final : public o2::calibration::TimeSlotCalibration<T
   using CcdbObjectInfoVector = std::vector<CcdbObjectInfo>;
   using TimeSlewingVector = std::vector<TimeSlewing>;
 
+#ifdef DEBUGGING
+  TProfile* mFitCal;  //("fitCal",";channel;offset (ps)",13104,0,157248);
+  TH2F* mChannelDist; //("channelDist",";channel; t - t_{exp}^{#pi} (ps)",13104,0,157248,1000,-100000,100000);
+#endif
+
  protected:
   std::deque<o2::calibration::TimeSlot<o2::tof::TOFChannelData>>& getSlots() { return o2::calibration::TimeSlotCalibration<T, o2::tof::TOFChannelData>::getSlots(); }
 
@@ -166,6 +186,10 @@ class TOFChannelCalibrator final : public o2::calibration::TimeSlotCalibration<T
       mLinFitters[i].SetDim(3);
       mLinFitters[i].SetFormula("pol2");
     }
+#ifdef DEBUGGING
+    mFitCal = new TProfile("fitCal", ";channel;offset (ps)", 157248, 0, 157248);
+    mChannelDist = new TH2F("channelDist", ";channel; t - t_{exp}^{#pi} (ps)", 157248, 0, 157248, 1000, -100000, 100000);
+#endif
   }
 
   ~TOFChannelCalibrator() final = default;
@@ -202,7 +226,12 @@ class TOFChannelCalibrator final : public o2::calibration::TimeSlotCalibration<T
     auto& cont = getSlots();
     auto& slot = front ? cont.emplace_front(tstart, tend) : cont.emplace_back(tstart, tend);
     int nElements = mCalibWithCosmics ? NCOMBINSTRIP * Geo::NSTRIPXSECTOR : Geo::NPADSXSECTOR; // if we calibrate with cosmics, we pass the number of possible combinations per sector; otherwise, the number of pads per sector
+#ifndef DEBUGGING
     slot.setContainer(std::make_unique<TOFChannelData>(mNBins, mRange, mCalibTOFapi, nElements, mPerStrip, mSafeMode));
+#else
+    slot.setContainer(std::make_unique<TOFChannelData>(mNBins, mRange, mCalibTOFapi, nElements, mPerStrip, mSafeMode, mChannelDist));
+#endif
+
     return slot;
   }
 
diff --git a/Detectors/TOF/calibration/src/TOFChannelCalibrator.cxx b/Detectors/TOF/calibration/src/TOFChannelCalibrator.cxx
diff --git a/Detectors/TOF/calibration/testWorkflow/tof-calib-workflow.cxx b/Detectors/TOF/calibration/testWorkflow/tof-calib-workflow.cxx
diff --git a/Detectors/TOF/workflowIO/src/CalibInfoReaderSpec.cxx b/Detectors/TOF/workflowIO/src/CalibInfoReaderSpec.cxx

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,7 @@ class CalibTimeSlewingParamTOF`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`CalibTimeSlewingParamTOF& operator+=(const CalibTimeSlewingParamTOF& other);`
	`87`	`+ void bind();`
`87`	`88`
`88`	`89`	`private:`
`89`	`90`	`std::array<int, NCHANNELXSECTOR> mChannelStartSec0;`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ using TimeSlewing = o2::dataformats::CalibTimeSlewingParamTOF;`
`84`	`84`
`85`	`85`	`bool MyFilter(const MyTrack& tr)`
`86`	`86`	`{`
`87`		`- return (tr.mP < 2.0 && tr.mEta > o2::tof::Utils::mEtaMin && tr.mEta < o2::tof::Utils::mEtaMax && tr.mHasTOF);`
	`87`	`+ return (tr.mP < 2.0 && tr.mEta > o2::tof::Utils::mEtaMin && tr.mEta < o2::tof::Utils::mEtaMax && tr.mHasTOF && tr.mSource == 1);`
`88`	`88`	`} // accept all`
`89`	`89`
`90`	`90`	`namespace o2`