Skip to content

Commit f774e01

Browse files
davidrohrdavidrohr
committed
Promote/demote several warnings/errors to alarm, in order to raise infologger-min-severity to important for sync processing
1 parent 8dc570c commit f774e01

12 files changed

Lines changed: 38 additions & 38 deletions

File tree

‎Detectors/ITSMFT/common/reconstruction/include/ITSMFTReconstruction/RawPixelReader.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,7 @@ class RawPixelReader : public PixelReader
768768
#ifdef _RAW_READER_ERROR_CHECKS_
769769
if (RDHUtils::getPacketCounter(rdh) > ruLink->packetCounter + 1) {
770770
ruLinkStat.errorCounts[GBTLinkDecodingStat::ErrPacketCounterJump]++;
771-
LOG(error) << ruLinkStat.ErrNames[GBTLinkDecodingStat::ErrPacketCounterJump]
771+
LOG(alarm) << ruLinkStat.ErrNames[GBTLinkDecodingStat::ErrPacketCounterJump]
772772
<< " : FEEId:" << OUTHEX(RDHUtils::getFEEID(rdh), 4) << ": jump from " << int(ruLink->packetCounter)
773773
<< " to " << int(RDHUtils::getPacketCounter(rdh));
774774
RDHUtils::printRDH(rdh);
@@ -1036,7 +1036,7 @@ class RawPixelReader : public PixelReader
10361036
#ifdef _RAW_READER_ERROR_CHECKS_
10371037
if (RDHUtils::getPacketCounter(rdh) > ruLink->packetCounter + 1) {
10381038
ruLinkStat.errorCounts[GBTLinkDecodingStat::ErrPacketCounterJump]++;
1039-
LOG(error) << ruLinkStat.ErrNames[GBTLinkDecodingStat::ErrPacketCounterJump]
1039+
LOG(alarm) << ruLinkStat.ErrNames[GBTLinkDecodingStat::ErrPacketCounterJump]
10401040
<< " : FEEId:" << OUTHEX(RDHUtils::getFEEID(rdh), 4) << ": jump from " << int(ruLink->packetCounter)
10411041
<< " to " << int(RDHUtils::getPacketCounter(rdh));
10421042
RDHUtils::printRDH(rdh);

‎Detectors/ITSMFT/common/reconstruction/src/Clusterer.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ void Clusterer::ClustererThread::finishChip(ChipPixelData* curChipData, CompClus
248248
} else {
249249
auto warnLeft = MaxHugeClusWarn - parent->mNHugeClus;
250250
if (warnLeft > 0) {
251-
LOGP(warning, "Splitting a huge cluster: chipID {}, rows {}:{} cols {}:{}{}", bbox.chipID, bbox.rowMin, bbox.rowMax, bbox.colMin, bbox.colMax,
251+
LOGP(alarm, "Splitting a huge cluster: chipID {}, rows {}:{} cols {}:{}{}", bbox.chipID, bbox.rowMin, bbox.rowMax, bbox.colMin, bbox.colMax,
252252
warnLeft == 1 ? " (Further warnings will be muted)" : "");
253253
#ifdef WITH_OPENMP
254254
#pragma omp critical

‎Detectors/ITSMFT/common/reconstruction/src/RawPixelDecoder.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ void RawPixelDecoder<Mapping>::setupLinks(InputRecord& inputs)
222222

223223
if (linksAdded) { // new links were added, update link<->RU mapping, usually is done for 1st TF only
224224
if (nLinks) {
225-
LOG(warning) << mSelfName << " New links appeared although the initialization was already done";
225+
LOG(alarm) << mSelfName << " New links appeared although the initialization was already done";
226226
for (auto& ru : mRUDecodeVec) { // reset RU->link references since they may have been changed
227227
memset(&ru.links[0], -1, RUDecodeData::MaxLinksPerRU * sizeof(int));
228228
}

‎Detectors/MUON/MCH/Raw/Decoder/src/DataDecoder.cxx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ DataDecoder::DataDecoder(SampaChannelHandler channelHandler, RdhHandler rdhHandl
250250
void DataDecoder::logErrorMap(int tfcount) const
251251
{
252252
for (auto err : mErrorMap) {
253-
LOGP(error, "{} ({} time{}) [{} TFs seeen]", err.first, err.second,
253+
LOGP(alarm, "{} ({} time{}) [{} TFs seen]", err.first, err.second,
254254
err.second > 1 ? "s" : "", tfcount);
255255
}
256256
}
@@ -494,7 +494,7 @@ bool DataDecoder::addDigit(const DsElecId& dsElecId, DualSampaChannelId channel,
494494

495495
// skip channels not associated to any pad
496496
if (padId < 0) {
497-
LOGP(error, "got invalid padId from dsElecId={} dualSampaId={} channel={}", asString(dsElecId), dsIddet, channel);
497+
LOGP(alarm, "got invalid padId from dsElecId={} dualSampaId={} channel={}", asString(dsElecId), dsIddet, channel);
498498
return false;
499499
}
500500

@@ -694,15 +694,15 @@ bool DataDecoder::getTimeFrameStartRecord(const RawDigit& digit, uint32_t& orbit
694694

695695
if (tfStart.mOrbit < 0) {
696696
if (mErrorCount < MCH_DECODER_MAX_ERROR_COUNT) {
697-
LOGP(warning, "Missing TF start record for S{}-J{}-DS{}-CHIP{}", info.solar, info.ds / 5 + 1, info.ds % 5, info.chip);
697+
LOGP(alarm, "Missing TF start record for S{}-J{}-DS{}-CHIP{}", info.solar, info.ds / 5 + 1, info.ds % 5, info.chip);
698698
mErrorCount += 1;
699699
}
700700
return false;
701701
}
702702

703703
if (tfStart.mValid == false) {
704704
if (mErrorCount < MCH_DECODER_MAX_ERROR_COUNT) {
705-
LOGP(warning, "Invalid TF start record for S{}-J{}-DS{}-CHIP{}", info.solar, info.ds / 5 + 1, info.ds % 5, info.chip);
705+
LOGP(alarm, "Invalid TF start record for S{}-J{}-DS{}-CHIP{}", info.solar, info.ds / 5 + 1, info.ds % 5, info.chip);
706706
mErrorCount += 1;
707707
}
708708
}

‎Detectors/Raw/src/RDHUtils.cxx‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ bool RDHUtils::checkRDH(const void* rdhP, bool verbose)
110110
default:
111111
ok = false;
112112
if (verbose) {
113-
LOG(error) << "Unexpected RDH version " << version << " from";
113+
LOG(alarm) << "Unexpected RDH version " << version << " from";
114114
}
115115
break;
116116
};
@@ -127,26 +127,26 @@ bool RDHUtils::checkRDH(const RAWDataHeaderV4& rdh, bool verbose)
127127
bool ok = true;
128128
if (rdh.version != 4 && rdh.version != 3) {
129129
if (verbose) {
130-
LOG(error) << "RDH version 4 is expected instead of " << int(rdh.version);
130+
LOG(alarm) << "RDH version 4 is expected instead of " << int(rdh.version);
131131
}
132132
ok = false;
133133
}
134134
if (rdh.headerSize != 64) {
135135
if (verbose) {
136-
LOG(error) << "RDH with header size of 64 B is expected instead of " << int(rdh.headerSize);
136+
LOG(alarm) << "RDH with header size of 64 B is expected instead of " << int(rdh.headerSize);
137137
}
138138
ok = false;
139139
}
140140
if (rdh.memorySize < 64 || rdh.offsetToNext < 64 || rdh.memorySize > MAXCRUPage || rdh.offsetToNext > MAXCRUPage) {
141141
if (verbose) {
142-
LOG(error) << "RDH expected to have memorySize/offsetToNext in 64 : 8192 bytes range instead of "
142+
LOG(alarm) << "RDH expected to have memorySize/offsetToNext in 64 : 8192 bytes range instead of "
143143
<< int(rdh.memorySize) << '/' << int(rdh.offsetToNext);
144144
}
145145
ok = false;
146146
}
147147
if (rdh.zero0 || rdh.word3 || rdh.zero41 || rdh.zero42 || rdh.word5 || rdh.zero6 || rdh.word7) {
148148
if (verbose) {
149-
LOG(error) << "Some reserved fields of RDH v4 are not empty";
149+
LOG(alarm) << "Some reserved fields of RDH v4 are not empty";
150150
}
151151
ok = false;
152152
}
@@ -163,26 +163,26 @@ bool RDHUtils::checkRDH(const RAWDataHeaderV5& rdh, bool verbose)
163163
bool ok = true;
164164
if (rdh.version != 5) {
165165
if (verbose) {
166-
LOG(error) << "RDH version 5 is expected instead of " << int(rdh.version);
166+
LOG(alarm) << "RDH version 5 is expected instead of " << int(rdh.version);
167167
}
168168
ok = false;
169169
}
170170
if (rdh.headerSize != 64) {
171171
if (verbose) {
172-
LOG(error) << "RDH with header size of 64 B is expected instead of " << int(rdh.headerSize);
172+
LOG(alarm) << "RDH with header size of 64 B is expected instead of " << int(rdh.headerSize);
173173
}
174174
ok = false;
175175
}
176176
if (rdh.memorySize < 64 || rdh.offsetToNext < 64) {
177177
if (verbose) {
178-
LOG(error) << "RDH expected to have memory size and offset to next >= 64 B instead of "
178+
LOG(alarm) << "RDH expected to have memory size and offset to next >= 64 B instead of "
179179
<< int(rdh.memorySize) << '/' << int(rdh.offsetToNext);
180180
}
181181
ok = false;
182182
}
183183
if (rdh.zero0 || rdh.word3 || rdh.zero4 || rdh.word5 || rdh.zero6 || rdh.word7) {
184184
if (verbose) {
185-
LOG(error) << "Some reserved fields of RDH v5 are not empty";
185+
LOG(alarm) << "Some reserved fields of RDH v5 are not empty";
186186
}
187187
ok = false;
188188
}
@@ -199,26 +199,26 @@ bool RDHUtils::checkRDH(const RAWDataHeaderV6& rdh, bool verbose)
199199
bool ok = true;
200200
if (rdh.version != 6) {
201201
if (verbose) {
202-
LOG(error) << "RDH version 5 is expected instead of " << int(rdh.version);
202+
LOG(alarm) << "RDH version 5 is expected instead of " << int(rdh.version);
203203
}
204204
ok = false;
205205
}
206206
if (rdh.headerSize != 64) {
207207
if (verbose) {
208-
LOG(error) << "RDH with header size of 64 B is expected instead of " << int(rdh.headerSize);
208+
LOG(alarm) << "RDH with header size of 64 B is expected instead of " << int(rdh.headerSize);
209209
}
210210
ok = false;
211211
}
212212
if (rdh.memorySize < 64 || rdh.offsetToNext < 64) {
213213
if (verbose) {
214-
LOG(error) << "RDH expected to have memory size and offset to next >= 64 B instead of "
214+
LOG(alarm) << "RDH expected to have memory size and offset to next >= 64 B instead of "
215215
<< int(rdh.memorySize) << '/' << int(rdh.offsetToNext);
216216
}
217217
ok = false;
218218
}
219219
if (rdh.zero0 || rdh.word3 || rdh.zero4 || rdh.word5 || rdh.zero6 || rdh.word7) {
220220
if (verbose) {
221-
LOG(error) << "Some reserved fields of RDH v6 are not empty";
221+
LOG(alarm) << "Some reserved fields of RDH v6 are not empty";
222222
}
223223
ok = false;
224224
}
@@ -251,6 +251,6 @@ uint32_t RDHUtils::fletcher32(const uint16_t* data, int len)
251251
/// process access to non-existing field
252252
void RDHUtils::processError(int v, const char* field)
253253
{
254-
LOG(error) << "Wrong field " << field << " for RDHv" << v;
254+
LOG(alarm) << "Wrong field " << field << " for RDHv" << v;
255255
throw std::runtime_error("wrong RDH field accessed");
256256
}

‎Detectors/TPC/workflow/src/CalibProcessingHelper.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ uint64_t calib_processing_helper::processRawData(o2::framework::InputRecord& inp
147147
}
148148

149149
} catch (const std::exception& e) {
150-
LOGP(error, "EXCEPTIION in processRawData: {} -> skipping part:{}/{} of spec:{}/{}/{}, size:{}", e.what(), dh->splitPayloadIndex, dh->splitPayloadParts,
150+
LOGP(alarm, "EXCEPTIION in processRawData: {} -> skipping part:{}/{} of spec:{}/{}/{}, size:{}", e.what(), dh->splitPayloadIndex, dh->splitPayloadParts,
151151
dh->dataOrigin, dh->dataDescription, subSpecification, dh->payloadSize);
152152
errorCount++;
153153
continue;

‎Detectors/TPC/workflow/src/LinkZSToDigitsSpec.cxx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -279,9 +279,9 @@ o2::framework::DataProcessorSpec getLinkZSToDigitsSpec(int channel, const std::s
279279
}
280280

281281
} catch (const std::runtime_error& e) {
282-
LOG(error) << "can not create raw parser form input data";
282+
LOG(alarm) << "can not create raw parser form input data";
283283
o2::header::hexDump("payload", input.payload, dh->payloadSize, 64);
284-
LOG(error) << e.what();
284+
LOG(alarm) << e.what();
285285
}
286286
}
287287
};

‎Detectors/TRD/reconstruction/src/CruRawReader.cxx‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ int CruRawReader::parseDigitHCHeader()
292292
increment2dHist(TRDParsingDigitHeaderCountGT3, mFEEID.supermodule * 2 + mHalfChamberSide[0], mStack[0], mLayer[0]);
293293
//TODO graph this and stats it
294294
if (mMaxErrsPrinted > 0) {
295-
LOG(error) << "Error parsing DigitHCHeader, too many additional words count=" << additionalHeaderWords;
295+
LOG(alarm) << "Error parsing DigitHCHeader, too many additional words count=" << additionalHeaderWords;
296296
printDigitHCHeader(mDigitHCHeader, &headers[0]);
297297
checkNoErr();
298298
}
@@ -308,26 +308,26 @@ int CruRawReader::parseDigitHCHeader()
308308
case 1: // header header1;
309309
mDigitHCHeader1.word = headers[headerwordcount];
310310
if (mDigitHCHeader1.res != 0x1) {
311-
//LOG(error) << "Digit HC Header 1 reserved : " << std::hex << mDigitHCHeader1.res << " raw: 0x" << mDigitHCHeader1.word;
311+
//LOG(alarm) << "Digit HC Header 1 reserved : " << std::hex << mDigitHCHeader1.res << " raw: 0x" << mDigitHCHeader1.word;
312312
increment2dHist(TRDParsingDigitHeaderWrong1, mFEEID.supermodule * 2 + mHalfChamberSide[0], mStack[0], mLayer[0]);
313313
}
314314
break;
315315
case 2: // header header2;
316316
mDigitHCHeader2.word = headers[headerwordcount];
317317
if (mDigitHCHeader2.res != 0b110001) {
318-
// LOG(error) << "Digit HC Header 2 reserved : " << std::hex << mDigitHCHeader2.res << " raw: 0x" << mDigitHCHeader2.word;
318+
// LOG(alarm) << "Digit HC Header 2 reserved : " << std::hex << mDigitHCHeader2.res << " raw: 0x" << mDigitHCHeader2.word;
319319
increment2dHist(TRDParsingDigitHeaderWrong2, mFEEID.supermodule * 2 + mHalfChamberSide[0], mStack[0], mLayer[0]);
320320
}
321321
break;
322322
case 3: // header header3;
323323
mDigitHCHeader3.word = headers[headerwordcount];
324324
if (mDigitHCHeader3.res != 0b110101) {
325-
// LOG(error) << "Digit HC Header 3 reserved : " << std::hex << mDigitHCHeader3.res << " raw: 0x" << mDigitHCHeader3.word;
325+
// LOG(alarm) << "Digit HC Header 3 reserved : " << std::hex << mDigitHCHeader3.res << " raw: 0x" << mDigitHCHeader3.word;
326326
increment2dHist(TRDParsingDigitHeaderWrong3, mFEEID.supermodule * 2 + mHalfChamberSide[0], mStack[0], mLayer[0]);
327327
}
328328
break;
329329
default:
330-
//LOG(error) << "Error parsing DigitHCHeader at word:" << headerwordcount << " looking at 0x:" << std::hex << mHBFPayload[mHBFoffset32 - 1];
330+
//LOG(alarm) << "Error parsing DigitHCHeader at word:" << headerwordcount << " looking at 0x:" << std::hex << mHBFPayload[mHBFoffset32 - 1];
331331
increment2dHist(TRDParsingDigitHeaderWrong4, mFEEID.supermodule * 2 + mHalfChamberSide[0], mStack[0], mLayer[0]);
332332
}
333333
}
@@ -554,13 +554,13 @@ int CruRawReader::processHalfCRU(int cruhbfstartoffset)
554554
//move over the DigitHCHeader mHBFoffset32 has already been moved in the reading.
555555
if (mHBFoffset32 - hfboffsetbeforehcparse != 1 + mDigitHCHeader.numberHCW) {
556556
if (mMaxErrsPrinted > 0) {
557-
LOG(error) << "Seems data offset is out of sync with number of HC Headers words " << mHBFoffset32 << "-" << hfboffsetbeforehcparse << "!=" << 1 << "+" << mDigitHCHeader.numberHCW;
557+
LOG(alarm) << "Seems data offset is out of sync with number of HC Headers words " << mHBFoffset32 << "-" << hfboffsetbeforehcparse << "!=" << 1 << "+" << mDigitHCHeader.numberHCW;
558558
checkNoErr();
559559
}
560560
}
561561
if (hcparse == -1) {
562562
if (mMaxWarnPrinted > 0) {
563-
LOG(warn) << "Parsing Digit HCHeader returned a -1";
563+
LOG(alarm) << "Parsing Digit HCHeader returned a -1";
564564
checkNoWarn();
565565
}
566566
} else {
@@ -737,7 +737,7 @@ void CruRawReader::buildDPLOutputs(o2::framework::ProcessingContext& pc)
737737
void CruRawReader::checkNoWarn()
738738
{
739739
if (!mVerbose && --mMaxWarnPrinted == 0) {
740-
LOG(warn) << "Warnings limit reached, the following ones will be suppressed";
740+
LOG(alarm) << "Warnings limit reached, the following ones will be suppressed";
741741
}
742742
}
743743

‎Detectors/TRD/reconstruction/src/TrackletsParser.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ int TrackletsParser::Parse()
270270
qa = mTrackletMCMHeader->pid2;
271271
break;
272272
default:
273-
LOG(warn) << "mcmtrackletcount is not in [0:2] count=" << mcmtrackletcount << " headertrackletcount=" << headertrackletcount << " something very wrong parsing the TrackletMCMData fields with data of : 0x" << std::hex << mTrackletMCMData->word;
273+
LOG(alarm) << "mcmtrackletcount is not in [0:2] count=" << mcmtrackletcount << " headertrackletcount=" << headertrackletcount << " something very wrong parsing the TrackletMCMData fields with data of : 0x" << std::hex << mTrackletMCMData->word;
274274
incParsingError(TRDParsingTrackletInvalidTrackletCount);
275275
//this should have been caught above by the headertrackletcount to mcmtrackletcount
276276
ignoreDataTillTrackletEndMarker = true;

‎Detectors/Upgrades/IT3/reconstruction/src/Clusterer.cxx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ void Clusterer::ClustererThread::finishChip(ChipPixelData* curChipData, CompClus
254254
streamCluster(pixArrBuff, rowMin, rowSpan, colMin, colSpan, chipID,
255255
compClusPtr, patternsPtr, labelsClusPtr, nlab);
256256
} else {
257-
LOG(warning) << "Splitting a huge cluster ! ChipID: " << chipID;
257+
LOG(alarm) << "Splitting a huge cluster ! ChipID: " << chipID;
258258

259259
colSpan %= o2::itsmft::ClusterPattern::MaxColSpan;
260260
if (colSpan == 0) {

0 commit comments

Comments
 (0)