Skip to content

TPC TimeSeries: propagate min-momentum, min-cluster, max-tgl to workflow#15618

Merged
shahor02 merged 2 commits into
AliceO2Group:devfrom
miranov25:dev
Jul 23, 2026
Merged

TPC TimeSeries: propagate min-momentum, min-cluster, max-tgl to workflow#15618
shahor02 merged 2 commits into
AliceO2Group:devfrom
miranov25:dev

Conversation

@miranov25

Copy link
Copy Markdown
Contributor

Add configurable environment variables for o2-tpc-time-series-workflow:
TPCTIMESERIES_MIN_MOMENTUM (default: 0.2)
TPCTIMESERIES_MIN_CLUSTER (default: 80)
TPCTIMESERIES_MAX_TGL (default: 1.4)

Defaults match TPCTimeSeriesSpec.cxx hardcoded values. Previously these cuts were not configurable from the workflow script.

Add configurable environment variables for o2-tpc-time-series-workflow:
  TPCTIMESERIES_MIN_MOMENTUM (default: 0.2)
  TPCTIMESERIES_MIN_CLUSTER  (default: 80)
  TPCTIMESERIES_MAX_TGL      (default: 1.4)

Defaults match TPCTimeSeriesSpec.cxx hardcoded values.
Previously these cuts were not configurable from the workflow script.
@miranov25
miranov25 requested a review from a team as a code owner July 21, 2026 13:28
@miranov25

Copy link
Copy Markdown
Contributor Author

Hello @shahor02, @marslandALICE, @matthias-kleiner, and @catalinristea,

Here is the pull request needed for O2 to set parameters for the low-gain calibration.

We need it as a technical fix and will keep the old default values.

@miranov25

Copy link
Copy Markdown
Contributor Author

Analyzing the output of the latest test production – changing dEddxRation cut – we found another problem in the multiplicity selection.

We introduced multiplicity binning in the time series, but by mistake applied the same multiplicity cut not only for the time series binning, but also for the track selection.

The default value of the cut, 50000, does not allow us to perform studies at extreme occupancies.

To address this, we will need to modify the source code.
I will update the pull request.
Should we first make the value parametrizable from the jdl, or is it better to directly fix the source code?

image

@alcaliva
alcaliva enabled auto-merge (squash) July 23, 2026 12:55
alcaliva
alcaliva previously approved these changes Jul 23, 2026
@alcaliva

Copy link
Copy Markdown
Collaborator

Hi @sawenzel, if you agree, could you please have a look at this one and if your are satisfied merge it? Thanks!

1 similar comment
@alcaliva

Copy link
Copy Markdown
Collaborator

Hi @sawenzel, if you agree, could you please have a look at this one and if your are satisfied merge it? Thanks!

@shahor02

Copy link
Copy Markdown
Collaborator

Please don't merge it yet, one more correction is needed for the time-series.

…rkflow

Add configurable environment variables for o2-tpc-time-series-workflow:
  TPCTIMESERIES_MIN_MOMENTUM (default: 0.2)
  TPCTIMESERIES_MIN_CLUSTER  (default: 80)
  TPCTIMESERIES_MAX_TGL      (default: 1.4)
  TPCTIMESERIES_MULT_MAX     (default: 50000)

Defaults match TPCTimeSeriesSpec.cxx hardcoded values.
Previously these cuts were not configurable from the workflow script.
auto-merge was automatically disabled July 23, 2026 21:08

Head branch was pushed to by a user without write access

@miranov25

Copy link
Copy Markdown
Contributor Author

Hello @shahor02,

I added an option to change the parameter:

  • CONFIG_TPCTIMESERIES+=" --mult-max ${TPCTIMESERIES_MULT_MAX}"

I was hesitant to change the code (the better solution); I will only do that after testing at GSI.

@shahor02
shahor02 enabled auto-merge (squash) July 23, 2026 23:18
@shahor02
shahor02 disabled auto-merge July 23, 2026 23:18
@shahor02
shahor02 enabled auto-merge (squash) July 23, 2026 23:18
@shahor02
shahor02 disabled auto-merge July 23, 2026 23:18
@shahor02
shahor02 merged commit a78221e into AliceO2Group:dev Jul 23, 2026
13 checks passed
github-actions Bot pushed a commit that referenced this pull request Jul 24, 2026
…low (#15618)

* TPC TimeSeries: propagate min-momentum, min-cluster, max-tgl to workflow

Add configurable environment variables for o2-tpc-time-series-workflow:
  TPCTIMESERIES_MIN_MOMENTUM (default: 0.2)
  TPCTIMESERIES_MIN_CLUSTER  (default: 80)
  TPCTIMESERIES_MAX_TGL      (default: 1.4)

Defaults match TPCTimeSeriesSpec.cxx hardcoded values.
Previously these cuts were not configurable from the workflow script.

* TPC TimeSeries: propagate track selection and multiplicity cuts to workflow

Add configurable environment variables for o2-tpc-time-series-workflow:
  TPCTIMESERIES_MIN_MOMENTUM (default: 0.2)
  TPCTIMESERIES_MIN_CLUSTER  (default: 80)
  TPCTIMESERIES_MAX_TGL      (default: 1.4)
  TPCTIMESERIES_MULT_MAX     (default: 50000)

Defaults match TPCTimeSeriesSpec.cxx hardcoded values.
Previously these cuts were not configurable from the workflow script.

---------

Co-authored-by: miranov25 <marian.ivanov@cern.cg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants