Enable AOD production in the FST#7500
Merged
Merged
Conversation
pzhristov
previously approved these changes
Nov 3, 2021
davidrohr
requested changes
Nov 3, 2021
Collaborator
There was a problem hiding this comment.
can we change this to workflow_has_parameter since AOD is not a detector?
Collaborator
Author
There was a problem hiding this comment.
1st I did it via workflow_has_parameter, but the problem is that the parameters are set in advance rather than built in the dpl-workflow, e.g. how would you enable it by default in the FST and at the same time allow its disabling?
As for the semantics, PRIMVTX and SECVTX are also not detectors...
Collaborator
There was a problem hiding this comment.
#7508 would disable it in the FST
Agreed semantically for VTXs, but I didn't want to add yet another list for vertexers.
Collaborator
Author
|
Don't merge until #7508 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.