Skip to content

DPL Analysis: disentangle slicing kernels#8005

Merged
jgrosseo merged 3 commits into
AliceO2Group:devfrom
aalkin:refactor-slicing-kernels
Jan 26, 2022
Merged

DPL Analysis: disentangle slicing kernels#8005
jgrosseo merged 3 commits into
AliceO2Group:devfrom
aalkin:refactor-slicing-kernels

Conversation

@aalkin

@aalkin aalkin commented Jan 25, 2022

Copy link
Copy Markdown
Member
  • Remove unnecessary templates
  • Move code to .cxx
  • Consolidate usage of arrow value_counts kernel
  • Remove unnecessary includes

@ktf

@aalkin
DPL Analysis: disentangle slicing kernels
6fa6763 
* Remove unnecessary templates
* Move code to .cxx
* Consolidate usage of arrow value_counts kernel
* Remove unnecessary includes
@aalkin aalkin requested a review from a team as a code owner January 25, 2022 14:08
ktf
ktf previously approved these changes Jan 25, 2022
View reviewed changes

@ktf ktf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@aalkin

aalkin commented Jan 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@ktf @jgrosseo I've also included the fix for the sortedness checks here, since this PR moves the relevant code into a different file anyway. The PR was full green before this push and I've tested this modification locally.

@aalkin aalkin mentioned this pull request Jan 26, 2022
Closed
@jgrosseo jgrosseo merged commit ff21c1d into AliceO2Group:dev Jan 26, 2022
@aalkin aalkin deleted the refactor-slicing-kernels branch May 30, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgrosseo jgrosseo jgrosseo approved these changes
@ktf ktf ktf left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aalkin @ktf @jgrosseo