Skip to content

Commit b18418f

Browse files
sawenzelchiarazampolli
authored andcommitted
Make TPC reco sensitive to TPCCorrMap param
TPCCorrMap is the main way how TPC charge corrections are selected in reconstruction deprecate former options --corrmap-lumi-inst and --corrmap-lumi-mean and introduce --corrmap-lumi-mode
1 parent f44e54d commit b18418f

2 files changed

Lines changed: 12 additions & 13 deletions

File tree

MC/bin/o2dpg_sim_workflow.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -938,14 +938,14 @@ def getDigiTaskName(det):
938938
else:
939939
tpcclus = createTask(name='tpccluster_' + str(tf), needs=[TPCDigitask['name']], tf=tf, cwd=timeframeworkdir, lab=["RECO"], cpu=NWORKERS, mem='2000')
940940
tpcclus['cmd'] = '${O2_ROOT}/bin/o2-tpc-chunkeddigit-merger --tpc-lanes ' + str(NWORKERS)
941-
tpcclus['cmd'] += ' | ${O2_ROOT}/bin/o2-tpc-reco-workflow ' + getDPL_global_options() + ' --input-type digitizer --output-type clusters,send-clusters-per-sector ' + putConfigValuesNew(["GPU_global","TPCGasParam"],{"GPU_proc.ompThreads" : 1}) + ('',' --disable-mc')[args.no_mc_labels]
941+
tpcclus['cmd'] += ' | ${O2_ROOT}/bin/o2-tpc-reco-workflow ' + getDPL_global_options() + ' --input-type digitizer --output-type clusters,send-clusters-per-sector ' + putConfigValuesNew(["GPU_global","TPCGasParam","TPCCorrMap"],{"GPU_proc.ompThreads" : 1}) + ('',' --disable-mc')[args.no_mc_labels]
942942
workflow['stages'].append(tpcclus)
943943
tpcreconeeds.append(tpcclus['name'])
944944

945945
tpc_corr_scaling_options = anchorConfig.get('tpc-corr-scaling','')
946946
TPCRECOtask=createTask(name='tpcreco_'+str(tf), needs=tpcreconeeds, tf=tf, cwd=timeframeworkdir, lab=["RECO"], relative_cpu=3/8, mem='16000')
947947
TPCRECOtask['cmd'] = '${O2_ROOT}/bin/o2-tpc-reco-workflow ' + getDPL_global_options(bigshm=True) + ' --input-type clusters --output-type tracks,send-clusters-per-sector ' \
948-
+ putConfigValuesNew(["GPU_global","TPCGasParam", "GPU_rec_tpc", "trackTuneParams"], {"GPU_proc.ompThreads":NWORKERS}) + ('',' --disable-mc')[args.no_mc_labels] \
948+
+ putConfigValuesNew(["GPU_global","TPCGasParam", "TPCCorrMap", "GPU_rec_tpc", "trackTuneParams"], {"GPU_proc.ompThreads":NWORKERS}) + ('',' --disable-mc')[args.no_mc_labels] \
949949
+ tpc_corr_scaling_options
950950
workflow['stages'].append(TPCRECOtask)
951951

@@ -966,7 +966,7 @@ def getDigiTaskName(det):
966966

967967
ITSTPCMATCHtask=createTask(name='itstpcMatch_'+str(tf), needs=[TPCRECOtask['name'], ITSRECOtask['name'], FT0RECOtask['name']], tf=tf, cwd=timeframeworkdir, lab=["RECO"], mem='8000', relative_cpu=3/8)
968968
ITSTPCMATCHtask['cmd'] = '${O2_ROOT}/bin/o2-tpcits-match-workflow ' + getDPL_global_options(bigshm=True) + ' --tpc-track-reader \"tpctracks.root\" --tpc-native-cluster-reader \"--infile tpc-native-clusters.root\" --use-ft0' \
969-
+ putConfigValuesNew(['MFTClustererParam', 'ITSCATrackerParam', 'tpcitsMatch', 'TPCGasParam', 'ITSClustererParam, GPU_rec_tpc, trackTuneParams'], {"NameConf.mDirMatLUT" : ".."}) \
969+
+ putConfigValuesNew(['MFTClustererParam', 'ITSCATrackerParam', 'tpcitsMatch', 'TPCGasParam', 'TPCCorrMap', 'ITSClustererParam, GPU_rec_tpc, trackTuneParams'], {"NameConf.mDirMatLUT" : ".."}) \
970970
+ tpc_corr_scaling_options
971971
workflow['stages'].append(ITSTPCMATCHtask)
972972

@@ -981,7 +981,8 @@ def getDigiTaskName(det):
981981
'ITSCATrackerParam',
982982
'trackTuneParams',
983983
'GPU_rec_tpc',
984-
'TPCGasParam'], {"NameConf.mDirMatLUT" : ".."}) \
984+
'TPCGasParam',
985+
'TPCCorrMap'], {"NameConf.mDirMatLUT" : ".."}) \
985986
+ " --track-sources " + anchorConfig.get("o2-trd-global-tracking-options",{}).get("track-sources","all") \
986987
+ tpc_corr_scaling_options
987988
workflow['stages'].append(TRDTRACKINGtask2)
@@ -999,6 +1000,7 @@ def getDigiTaskName(det):
9991000
TOFTPCMATCHERtask['cmd'] = '${O2_ROOT}/bin/o2-tof-matcher-workflow ' + getDPL_global_options() \
10001001
+ putConfigValuesNew(["ITSClustererParam",
10011002
'TPCGasParam',
1003+
'TPCCorrMap',
10021004
'ITSCATrackerParam',
10031005
'MFTClustererParam',
10041006
'GPU_rec_tpc',
@@ -1149,7 +1151,7 @@ def getDigiTaskName(det):
11491151

11501152
PVFINDERtask = createTask(name='pvfinder_'+str(tf), needs=pvfinderneeds, tf=tf, cwd=timeframeworkdir, lab=["RECO"], cpu=NWORKERS, mem='4000')
11511153
PVFINDERtask['cmd'] = '${O2_ROOT}/bin/o2-primary-vertexing-workflow ' \
1152-
+ getDPL_global_options() + putConfigValuesNew(['ITSAlpideParam','MFTAlpideParam', 'pvertexer', 'TPCGasParam'], {"NameConf.mDirMatLUT" : ".."})
1154+
+ getDPL_global_options() + putConfigValuesNew(['ITSAlpideParam','MFTAlpideParam', 'pvertexer', 'TPCGasParam', 'TPCCorrMap'], {"NameConf.mDirMatLUT" : ".."})
11531155
PVFINDERtask['cmd'] += ' --vertexing-sources ' + pvfinder_sources + ' --vertex-track-matching-sources ' + pvfinder_matching_sources + (' --combine-source-devices','')[args.no_combine_dpl_devices]
11541156
PVFINDERtask['cmd'] += ('',' --disable-mc')[args.no_mc_labels]
11551157
workflow['stages'].append(PVFINDERtask)
@@ -1305,7 +1307,7 @@ def addQCPerTF(taskName, needs, readerCommand, configFilePath, objectsFile=''):
13051307
svfinder_cpu = 8
13061308
SVFINDERtask = createTask(name='svfinder_'+str(tf), needs=[PVFINDERtask['name']], tf=tf, cwd=timeframeworkdir, lab=["RECO"], cpu=svfinder_cpu, mem='5000')
13071309
SVFINDERtask['cmd'] = '${O2_ROOT}/bin/o2-secondary-vertexing-workflow '
1308-
SVFINDERtask['cmd'] += getDPL_global_options(bigshm=True) + svfinder_threads + putConfigValuesNew(['svertexer'], {"NameConf.mDirMatLUT" : ".."})
1310+
SVFINDERtask['cmd'] += getDPL_global_options(bigshm=True) + svfinder_threads + putConfigValuesNew(['svertexer', 'TPCCorrMap'], {"NameConf.mDirMatLUT" : ".."})
13091311
# Take None as default, we only add more if nothing from anchorConfig
13101312
svfinder_sources = anchorConfig.get("o2-secondary-vertexing-workflow-options",{}).get("vertexing-sources", None)
13111313
if not svfinder_sources:

UTILS/parse-async-WorkflowConfig.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -187,15 +187,12 @@ def parse_important_DPL_args(cmds, flat_config):
187187
# itstpc matching
188188
if cmd == 'o2-tpcits-match-workflow':
189189
corrstring = ''
190-
s1 = extract_args(tokens, '--corrmap-lumi-inst')
190+
s1 = extract_args(tokens, '--lumi-type')
191191
if s1:
192-
corrstring += ' --corrmap-lumi-inst ' + s1
193-
s2 = extract_args(tokens, '--corrmap-lumi-mean')
192+
corrstring += ' --lumi-type ' + s1
193+
s2 = extract_args(tokens, '--corrmap-lumi-mode')
194194
if s2:
195-
corrstring += ' --corrmap-lumi-mean ' + s2
196-
s3 = extract_args(tokens, '--lumi-type')
197-
if s3:
198-
corrstring += ' --lumi-type ' + s3
195+
corrstring += ' --corrma-lumi-mode ' + s2
199196
# these are some options applied in multiple places (so save them flatly under tpc-corr-scaling)
200197
flat_config['tpc-corr-scaling'] = corrstring
201198

0 commit comments

Comments
 (0)