Add debug task for femto#482
Merged
Merged
Conversation
lbariogl
requested review from
alibuild,
jgrosseo,
saganatt and
victor-gonzalez
as code owners
jgrosseo
reviewed
Jan 28, 2022
Comment on lines
+90
to
+91
| DECLARE_SOA_COLUMN(TPCNClsFound, tpcNClsFound, int16_t); //! Number of TPC clusters | ||
| DECLARE_SOA_COLUMN(TPCNClsCrossedRows, tpcNClsCrossedRows, int16_t); //! Number of TPC crossed rows |
Contributor
There was a problem hiding this comment.
Why isn't uint8_t enough?
Contributor
There was a problem hiding this comment.
There are at maximum 159...
Collaborator
Author
There was a problem hiding this comment.
I did it for consistency with the definition in O2:
Otherwise a cast is needed
Collaborator
Author
There was a problem hiding this comment.
I changed it to uint8_t and applied a cast
Contributor
There was a problem hiding this comment.
Yes, this is better. The other is int16 because it formally could be larger than 8 bit, but in practice it isn't...
jgrosseo
approved these changes
Jan 28, 2022
AnnalenaKa
pushed a commit
to AnnalenaKa/O2Physics
that referenced
this pull request
Jan 30, 2022
* Add debug task for femto * Add cast to uint8_t
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.