From bf2e609863d327b215e62f92d1fe0f92890280b3 Mon Sep 17 00:00:00 2001 From: nstrangm Date: Tue, 9 Jul 2024 13:53:37 +0200 Subject: [PATCH 1/2] PWGEM/PhotonMeson: Fix wrong dimension when filling rotation histograms - Yesterdays PR removed two dimensions from the minv-pt histogram, but two zeros were still included in the filling of the rotation histogram, leading to Hyperloop tests to fail - Removed the additional fill arguments, this should fix the issue --- PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h b/PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h index 7c7c132f909..98372dca3a5 100644 --- a/PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h +++ b/PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h @@ -460,10 +460,10 @@ struct Pi0EtaToGammaGamma { float openingAngle2 = std::acos(photon2.Vect().Dot(photon3.Vect()) / (photon2.P() * photon3.P())); if (openingAngle1 > emccuts.minOpenAngle && abs(mother1.Rapidity()) < maxY) { - fRegistry.fill(HIST("Pair/rotation/hs"), mother1.M(), mother1.Pt(), 0.0, 0.0); + fRegistry.fill(HIST("Pair/rotation/hs"), mother1.M(), mother1.Pt()); } if (openingAngle2 > emccuts.minOpenAngle && abs(mother2.Rapidity()) < maxY) { - fRegistry.fill(HIST("Pair/rotation/hs"), mother2.M(), mother2.Pt(), 0.0, 0.0); + fRegistry.fill(HIST("Pair/rotation/hs"), mother2.M(), mother2.Pt()); } } } @@ -635,8 +635,8 @@ struct Pi0EtaToGammaGamma { used_dileptonIds.emplace_back(tuple_tmp_id2); } ndiphoton++; - } // end of dielectron loop - } // end of g1 loop + } // end of dielectron loop + } // end of g1 loop } else { // PCM-EMC, PCM-PHOS. Nightmare. don't run these pairs. auto photons1_per_collision = photons1.sliceBy(perCollision1, collision.globalIndex()); auto photons2_per_collision = photons2.sliceBy(perCollision2, collision.globalIndex()); @@ -667,7 +667,7 @@ struct Pi0EtaToGammaGamma { } ndiphoton++; } // end of pairing loop - } // end of pairing in same event + } // end of pairing in same event // event mixing if (!cfgDoMix || !(ndiphoton > 0)) { From 1d4ea2a7ec2a4422998fa26df0fcf6698373edb6 Mon Sep 17 00:00:00 2001 From: ALICE Action Bot Date: Tue, 9 Jul 2024 11:58:00 +0000 Subject: [PATCH 2/2] Please consider the following formatting changes --- PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h b/PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h index 98372dca3a5..9fbc650f39a 100644 --- a/PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h +++ b/PWGEM/PhotonMeson/Core/Pi0EtaToGammaGamma.h @@ -635,8 +635,8 @@ struct Pi0EtaToGammaGamma { used_dileptonIds.emplace_back(tuple_tmp_id2); } ndiphoton++; - } // end of dielectron loop - } // end of g1 loop + } // end of dielectron loop + } // end of g1 loop } else { // PCM-EMC, PCM-PHOS. Nightmare. don't run these pairs. auto photons1_per_collision = photons1.sliceBy(perCollision1, collision.globalIndex()); auto photons2_per_collision = photons2.sliceBy(perCollision2, collision.globalIndex()); @@ -667,7 +667,7 @@ struct Pi0EtaToGammaGamma { } ndiphoton++; } // end of pairing loop - } // end of pairing in same event + } // end of pairing in same event // event mixing if (!cfgDoMix || !(ndiphoton > 0)) {