From b88025c26c7117a6a9a369d419e9849d22aecc1d Mon Sep 17 00:00:00 2001 From: Karthik Venkatraman Date: Thu, 22 Sep 2022 16:02:59 +0100 Subject: [PATCH 1/4] exclude tags for min --- ps-rule.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ps-rule.yaml b/ps-rule.yaml index 7c66b607a7..4a764b8e59 100644 --- a/ps-rule.yaml +++ b/ps-rule.yaml @@ -62,6 +62,6 @@ rule: # - Azure.KeyVault.PurgeProtect # - Azure.Resource.UseTags # Suppression ignores rules for a specific Azure resource by name. -# suppression: -# Azure.Resource.UseTags: -# - <>kvvmin001 +suppression: + Azure.Resource.UseTags: + - *min* From 99480118c412f47b8a5fdb6f9cbbd7c983ccf457 Mon Sep 17 00:00:00 2001 From: Karthik Venkatraman Date: Thu, 22 Sep 2022 16:06:29 +0100 Subject: [PATCH 2/4] typo in ps-rule yaml --- ps-rule.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ps-rule.yaml b/ps-rule.yaml index 4a764b8e59..3bbe870fc3 100644 --- a/ps-rule.yaml +++ b/ps-rule.yaml @@ -64,4 +64,4 @@ rule: # Suppression ignores rules for a specific Azure resource by name. suppression: Azure.Resource.UseTags: - - *min* + - '*min*' From 7000a667e915d88c64c72c166f49119804134948 Mon Sep 17 00:00:00 2001 From: Karthik Venkatraman Date: Thu, 22 Sep 2022 16:13:57 +0100 Subject: [PATCH 3/4] update suppression yaml --- .ps-rule/min-suppress.Rule.yaml | 14 ++++++++++++++ ps-rule.yaml | 6 +++--- 2 files changed, 17 insertions(+), 3 deletions(-) create mode 100644 .ps-rule/min-suppress.Rule.yaml diff --git a/.ps-rule/min-suppress.Rule.yaml b/.ps-rule/min-suppress.Rule.yaml new file mode 100644 index 0000000000..a79040f432 --- /dev/null +++ b/.ps-rule/min-suppress.Rule.yaml @@ -0,0 +1,14 @@ +--- +# Synopsis: Suppress Rules for min tests +apiVersion: github.com/microsoft/PSRule/v1 +kind: SuppressionGroup +metadata: + name: 'Suppressmin' +spec: + rule: + - Azure.Resource.UseTags + if: + name: '.' + contains: + - 'min' + diff --git a/ps-rule.yaml b/ps-rule.yaml index 3bbe870fc3..01914244b9 100644 --- a/ps-rule.yaml +++ b/ps-rule.yaml @@ -62,6 +62,6 @@ rule: # - Azure.KeyVault.PurgeProtect # - Azure.Resource.UseTags # Suppression ignores rules for a specific Azure resource by name. -suppression: - Azure.Resource.UseTags: - - '*min*' +#suppression: +# Azure.Resource.UseTags: +# - '*min*' From 3b375f259b07561a78f8c8dd48eebb53cb8a1281 Mon Sep 17 00:00:00 2001 From: Karthik Venkatraman Date: Thu, 22 Sep 2022 16:41:45 +0100 Subject: [PATCH 4/4] keyvault rule exclusions --- .ps-rule/min-suppress.Rule.yaml | 2 ++ ps-rule.yaml | 10 +++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.ps-rule/min-suppress.Rule.yaml b/.ps-rule/min-suppress.Rule.yaml index a79040f432..9c984ea8da 100644 --- a/.ps-rule/min-suppress.Rule.yaml +++ b/.ps-rule/min-suppress.Rule.yaml @@ -7,8 +7,10 @@ metadata: spec: rule: - Azure.Resource.UseTags + - Azure.KeyVault.Logs if: name: '.' contains: - 'min' + \ No newline at end of file diff --git a/ps-rule.yaml b/ps-rule.yaml index 01914244b9..9ee2318a42 100644 --- a/ps-rule.yaml +++ b/ps-rule.yaml @@ -57,11 +57,11 @@ configuration: rule: # Enable custom rules that don't exist in the baseline includeLocal: false - #exclude: + exclude: # Ignore the following rules for all resources - # - Azure.KeyVault.PurgeProtect - # - Azure.Resource.UseTags + - Azure.KeyVault.PurgeProtect + # Suppression ignores rules for a specific Azure resource by name. -#suppression: -# Azure.Resource.UseTags: +# suppression: +# Azure.KeyVault.PurgeProtect: # - '*min*'