From 7f065027913ded51511cc829a0828a45b6d6d5f4 Mon Sep 17 00:00:00 2001 From: John Pinto Date: Thu, 30 Sep 2021 12:39:01 +0100 Subject: [PATCH] Issue #2169 - Added missing spellcheck for all form text and textarea fields except for fields: abbreviation code name firstname surname --- .../stylesheets/blocks/_clearable_field.scss | 0 .../variables/_site_overrides.scss | 0 .../contact_us/contacts/_new_left.html.erb | 3 +- app/views/contributors/_form.html.erb | 2 +- app/views/devise/invitations/edit.html.erb | 3 +- app/views/guidances/new_edit.html.erb | 3 +- app/views/notes/_edit.html.erb | 5 +-- app/views/notes/_new.html.erb | 5 +-- .../org_admin/annotations/_form.html.erb | 2 +- app/views/org_admin/phases/_form.html.erb | 4 +-- app/views/org_admin/questions/_form.html.erb | 4 +-- app/views/org_admin/templates/_form.html.erb | 2 +- app/views/orgs/_feedback_form.html.erb | 4 +-- app/views/plans/_project_details.html.erb | 35 ++++++++++++------- .../shared/org_selectors/_combined.html.erb | 1 + .../org_selectors/_external_only.html.erb | 1 + .../shared/org_selectors/_local_only.html.erb | 1 + .../super_admin/api_clients/_form.html.erb | 4 ++- .../super_admin/notifications/_form.html.erb | 1 + app/views/super_admin/themes/_form.html.erb | 4 +-- 20 files changed, 53 insertions(+), 31 deletions(-) create mode 100755 app/assets/stylesheets/blocks/_clearable_field.scss create mode 100755 app/assets/stylesheets/variables/_site_overrides.scss diff --git a/app/assets/stylesheets/blocks/_clearable_field.scss b/app/assets/stylesheets/blocks/_clearable_field.scss new file mode 100755 index 0000000000..e69de29bb2 diff --git a/app/assets/stylesheets/variables/_site_overrides.scss b/app/assets/stylesheets/variables/_site_overrides.scss new file mode 100755 index 0000000000..e69de29bb2 diff --git a/app/views/contact_us/contacts/_new_left.html.erb b/app/views/contact_us/contacts/_new_left.html.erb index 77a403668d..3e67a5ce7b 100644 --- a/app/views/contact_us/contacts/_new_left.html.erb +++ b/app/views/contact_us/contacts/_new_left.html.erb @@ -22,7 +22,7 @@ <%= f.label(:subject, _('Subject')) %> <%= f.text_field(:subject, class: "form-control", - spellcheck: "true", + spellcheck: true, "aria-required": true) %> <% end %> @@ -31,6 +31,7 @@ <%= f.text_area(:message, class: "form-control", rows: 10, + spellcheck: true, "aria-required": true) %> <% if !user_signed_in? && Rails.configuration.x.recaptcha.enabled then %> diff --git a/app/views/contributors/_form.html.erb b/app/views/contributors/_form.html.erb index f199b2c90e..3dcd50d396 100644 --- a/app/views/contributors/_form.html.erb +++ b/app/views/contributors/_form.html.erb @@ -10,7 +10,7 @@ roles_tooltip = _("Select each role that applies to the contributor.") <%= form.label(:name, _("Name"), class: "control-label") %>
- <%= form.text_field :name, class: "form-control", aria: { required: true } %> + <%= form.text_field :name, class: "form-control", spellcheck: true, aria: { required: true } %>
diff --git a/app/views/devise/invitations/edit.html.erb b/app/views/devise/invitations/edit.html.erb index 814596497f..586af8dff6 100644 --- a/app/views/devise/invitations/edit.html.erb +++ b/app/views/devise/invitations/edit.html.erb @@ -21,7 +21,8 @@
<%= f.label(:firstname, _('First name'), class: 'control-label') %> - <%= f.text_field(:firstname, class: "form-control", "aria-required": true, value: @user.firstname) %> + <%= f.text_field(:firstname, class: "form-control", "aria-required": true, + spellcheck: true, value: @user.firstname) %>
<%= f.label(:surname, _('Last name'), class: 'control-label') %> diff --git a/app/views/guidances/new_edit.html.erb b/app/views/guidances/new_edit.html.erb index 12ecd51479..8b26be6a19 100644 --- a/app/views/guidances/new_edit.html.erb +++ b/app/views/guidances/new_edit.html.erb @@ -23,7 +23,8 @@ end
<%= guidance_text_tooltip %> <%= f.label :text, class: 'control-label' %> - <%= f.text_area :text, rows: 10, class: "form-control", aria: { required: true } %> + <%= f.text_area :text, rows: 10, class: "form-control", spellcheck: true, + aria: { required: true } %>
<%= render partial: 'org_admin/shared/theme_selector', locals: { f: f, all_themes: Theme.all.order("title"), as_radio: false, required: true, diff --git a/app/views/notes/_edit.html.erb b/app/views/notes/_edit.html.erb index f62bce377c..ce86331dec 100644 --- a/app/views/notes/_edit.html.erb +++ b/app/views/notes/_edit.html.erb @@ -3,11 +3,12 @@ <%= form_for(note, url: note_path(note), method: :put) do |f| %>
<%= f.label(:text, _('Edit comment to share with collaborators')) %> - <%= f.text_area(:text, class: 'form-control', id: "note-#{note.id}") %> + <%= f.text_area(:text, class: 'form-control', id: "note-#{note.id}", + spellcheck: true) %>
<%= f.button(_('Save'), class: "btn btn-default", type: "submit") %> <%= f.button(_('Cancel'), class: "btn btn-default", type: "button") %>
<% end %> -<% end %> \ No newline at end of file +<% end %> diff --git a/app/views/notes/_new.html.erb b/app/views/notes/_new.html.erb index 3e66e947c6..fc1e90abf0 100644 --- a/app/views/notes/_new.html.erb +++ b/app/views/notes/_new.html.erb @@ -6,9 +6,10 @@ <%= f.hidden_field :plan_id, value: plan.id %>
<%= f.label(:text, _('Add comments to share with collaborators')) %> - <%= f.text_area(:text, class: 'form-control note', id: "note-#{question.id}") %> + <%= f.text_area(:text, class: 'form-control note', id: "note-#{question.id}", + spellcheck: true) %>
<%= f.button(_('Save'), class: "btn btn-default", type: "submit") %>
-<% end %> \ No newline at end of file +<% end %> diff --git a/app/views/org_admin/annotations/_form.html.erb b/app/views/org_admin/annotations/_form.html.erb index f6929ca165..12489bdb36 100644 --- a/app/views/org_admin/annotations/_form.html.erb +++ b/app/views/org_admin/annotations/_form.html.erb @@ -4,7 +4,7 @@ <%= f.label(:type, lbl, class: "control-label") %>
<%= tooltip_for_annotation_text(f.object) %> - <%= f.text_area(:text, class: 'question', + <%= f.text_area(:text, class: 'question', spellcheck: true, id: "question_annotations_attributes_#{unique_dom_id(f.object)}_text") %>
diff --git a/app/views/org_admin/phases/_form.html.erb b/app/views/org_admin/phases/_form.html.erb index ab23b2da64..66a8a8a57a 100644 --- a/app/views/org_admin/phases/_form.html.erb +++ b/app/views/org_admin/phases/_form.html.erb @@ -18,9 +18,9 @@
"> <%= f.label(:description, _('Description'), class: "control-label") %> - <%= f.text_area(:description, class: "phase") %> + <%= f.text_area(:description, class: "phase", spellcheck: true) %>
<%= f.button(_('Save'), class: 'btn btn-default', type: "submit") %> -
\ No newline at end of file + diff --git a/app/views/org_admin/questions/_form.html.erb b/app/views/org_admin/questions/_form.html.erb index 18c4f873e7..52f3aa87e7 100644 --- a/app/views/org_admin/questions/_form.html.erb +++ b/app/views/org_admin/questions/_form.html.erb @@ -20,7 +20,7 @@
<%= f.label(:text, _('Question text'), class: "control-label") %> - <%= f.text_area(:text, class: "question", "aria-required": true) %> + <%= f.text_area(:text, class: "question", spellcheck: true, "aria-required": true) %>
@@ -52,7 +52,7 @@ <%= render partial: 'org_admin/conditions/container', locals: { f: f, question: question, conditions: conditions } %>

- <% else %> + <% else %>
<%= link_to _('Add Conditions'), '#', class: "add-logic btn btn-default disabled" %>
diff --git a/app/views/org_admin/templates/_form.html.erb b/app/views/org_admin/templates/_form.html.erb index f41d119e8b..29c17a05a1 100644 --- a/app/views/org_admin/templates/_form.html.erb +++ b/app/views/org_admin/templates/_form.html.erb @@ -8,7 +8,7 @@
<%= description_tooltip %> <%= f.label(:description, _('Description'), class: "control-label") %> - <%= f.text_area(:description, class: "template") %> + <%= f.text_area(:description, class: "template", spellcheck: true) %>
<% if current_user.org.funder? && !current_user.org.funder_only? %> diff --git a/app/views/orgs/_feedback_form.html.erb b/app/views/orgs/_feedback_form.html.erb index 6378091be1..dbd13889af 100644 --- a/app/views/orgs/_feedback_form.html.erb +++ b/app/views/orgs/_feedback_form.html.erb @@ -24,7 +24,7 @@
<%= f.label :feedback_msg, _('Message'), class: "control-label" %> - <%= f.text_area :feedback_msg, class: "form-control", + <%= f.text_area :feedback_msg, class: "form-control", spellcheck: true, "aria-required" => true %>
@@ -38,4 +38,4 @@ <%= f.button(_('Save'), id:"save_org_submit", class: "btn btn-primary", type: "submit") %>
-<% end %> \ No newline at end of file +<% end %> diff --git a/app/views/plans/_project_details.html.erb b/app/views/plans/_project_details.html.erb index e3cd180180..10d913c6bb 100644 --- a/app/views/plans/_project_details.html.erb +++ b/app/views/plans/_project_details.html.erb @@ -37,7 +37,7 @@ ethics_report_tooltip = _("Link to a protocol from a meeting with an ethics comm
<%= project_abstract_tooltip %> <%= form.text_area :description, rows: 6, class: 'form-control tinymce', - "aria-required": false %> + spellcheck: true, "aria-required": false %>
@@ -94,10 +94,12 @@ ethics_report_tooltip = _("Link to a protocol from a meeting with an ethics comm
<%= id_tooltip %> - <%= form.text_field :identifier, class: "form-control", - aria: { required: false }, - data: { toggle: "tooltip" }, - spellcheck: true, title: id_tooltip %> + <%= form.text_field :identifier, + class: "form-control", + aria: { required: false }, + data: { toggle: "tooltip" }, + spellcheck: true, + title: id_tooltip %>
<% end %> @@ -120,8 +122,11 @@ ethics_report_tooltip = _("Link to a protocol from a meeting with an ethics comm
<%= ethics_description_tooltip %> - <%= form.text_area :ethical_issues_description, rows: 6, class: 'form-control tinymce', - "aria-required": false %> + <%= form.text_area :ethical_issues_description, + rows: 6, + class: 'form-control tinymce', + spellcheck: true, + "aria-required": false %>
@@ -130,9 +135,11 @@ ethics_report_tooltip = _("Link to a protocol from a meeting with an ethics comm
<%= ethics_report_tooltip %> - <%= form.url_field(:ethical_issues_report, class: "form-control", "aria-required": false, - 'data-toggle': 'tooltip', - title: ethics_report_tooltip) %> + <%= form.url_field(:ethical_issues_report, + class: "form-control", + "aria-required": false, + 'data-toggle': 'tooltip', + title: ethics_report_tooltip) %>
@@ -178,8 +185,12 @@ ethics_report_tooltip = _("Link to a protocol from a meeting with an ethics comm <%# If the OpenAire grant typeahead if enabled use it %> <% if Rails.configuration.x.open_aire.active %> - <%= grant_fields.text_field :name, value: plan.grant&.value, class: "form-control grant-id-typeahead", - autocomplete: "off", aria: { required: false } %> + <%= grant_fields.text_field :name, + value: plan.grant&.value, + class: "form-control grant-id-typeahead", + spellcheck: true, + autocomplete: "off", + aria: { required: false } %> <%= grant_fields.hidden_field :value %> Grant number: <%= plan.grant&.value %> <% else %> diff --git a/app/views/shared/org_selectors/_combined.html.erb b/app/views/shared/org_selectors/_combined.html.erb index 75755948dc..1502d25661 100644 --- a/app/views/shared/org_selectors/_combined.html.erb +++ b/app/views/shared/org_selectors/_combined.html.erb @@ -19,6 +19,7 @@ placeholder = _("Begin typing to see a list of suggestions.") <%= form.text_field :org_name, class: "form-control autocomplete", placeholder: placeholder, value: presenter.name, + spellcheck: true, aria: { label: placeholder, autocomplete: "list", diff --git a/app/views/shared/org_selectors/_external_only.html.erb b/app/views/shared/org_selectors/_external_only.html.erb index 16ed797f63..daf0ef3456 100644 --- a/app/views/shared/org_selectors/_external_only.html.erb +++ b/app/views/shared/org_selectors/_external_only.html.erb @@ -17,6 +17,7 @@ placeholder = _("Begin typing to see a list of suggestions.") <%= form.text_field :org_name, class: "form-control autocomplete", placeholder: placeholder, value: presenter.name, + spellcheck: true, aria: { label: placeholder, autocomplete: "list", diff --git a/app/views/shared/org_selectors/_local_only.html.erb b/app/views/shared/org_selectors/_local_only.html.erb index 858774d6e8..64430203b1 100644 --- a/app/views/shared/org_selectors/_local_only.html.erb +++ b/app/views/shared/org_selectors/_local_only.html.erb @@ -17,6 +17,7 @@ placeholder = _("Begin typing to see a list of suggestions.") <%= form.text_field :org_name, class: "form-control autocomplete", placeholder: placeholder, value: presenter.name, + spellcheck: true, aria: { label: placeholder, autocomplete: "list", diff --git a/app/views/super_admin/api_clients/_form.html.erb b/app/views/super_admin/api_clients/_form.html.erb index fbf48eeace..27dbbf348d 100644 --- a/app/views/super_admin/api_clients/_form.html.erb +++ b/app/views/super_admin/api_clients/_form.html.erb @@ -19,7 +19,9 @@ orgs = Org.where(is_other: false)
<%= f.label :description, _('Description'), class: 'control-label' %> - <%= f.text_area :description, class: 'form-control api-client-text' %> + <%= f.text_area :description, + class: 'form-control api-client-text', + spellcheck: true %>
diff --git a/app/views/super_admin/notifications/_form.html.erb b/app/views/super_admin/notifications/_form.html.erb index 2b0fc6eab3..50bbe62280 100644 --- a/app/views/super_admin/notifications/_form.html.erb +++ b/app/views/super_admin/notifications/_form.html.erb @@ -58,6 +58,7 @@ <%= f.text_area :body, class: 'form-control notification-text', value: @notification.body, + spellcheck: true, "aria-required": true %>
diff --git a/app/views/super_admin/themes/_form.html.erb b/app/views/super_admin/themes/_form.html.erb index 393bd8729e..cd46e069f9 100644 --- a/app/views/super_admin/themes/_form.html.erb +++ b/app/views/super_admin/themes/_form.html.erb @@ -7,7 +7,7 @@
<%= f.label(:description, _('Guidance')) %> - <%= f.text_area(:description, class: "form-control", rows: 10) %> + <%= f.text_area(:description, class: "form-control", rows: 10, spellcheck: true) %>
<%= f.button(_('Save'), class: "btn btn-default", type: "submit") %> @@ -18,4 +18,4 @@ <% end %> <%= link_to(_('Cancel'), super_admin_themes_path, class: 'btn btn-default', role: 'button') %>
- <% end %> \ No newline at end of file + <% end %>