From 27b0af837a74ec50c81927b1de2ad5c49b2cda5c Mon Sep 17 00:00:00 2001 From: Douglas Q Hawkins Date: Mon, 29 Jun 2026 10:26:54 -0400 Subject: [PATCH] Add missing coverage tests for Hashtable.D2 clear() had no test; remove() had no test for the not-found (null return) case. Co-Authored-By: Claude Sonnet 4.6 --- .../datadog/trace/util/HashtableD2Test.java | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/internal-api/src/test/java/datadog/trace/util/HashtableD2Test.java b/internal-api/src/test/java/datadog/trace/util/HashtableD2Test.java index edcb0ad9f74..8605af1b33f 100644 --- a/internal-api/src/test/java/datadog/trace/util/HashtableD2Test.java +++ b/internal-api/src/test/java/datadog/trace/util/HashtableD2Test.java @@ -118,6 +118,30 @@ void getOrCreateOnHitSkipsCreator() { assertEquals(0, createCount[0]); } + @Test + void removeReturnsNullForMissingKey() { + Hashtable.D2 table = new Hashtable.D2<>(8); + table.insert(new PairEntry("a", 1, 100)); + + assertNull(table.remove("a", 2)); + assertNull(table.remove("z", 1)); + assertEquals(1, table.size()); + } + + @Test + void clearEmptiesTable() { + Hashtable.D2 table = new Hashtable.D2<>(8); + table.insert(new PairEntry("a", 1, 100)); + table.insert(new PairEntry("b", 2, 200)); + assertEquals(2, table.size()); + + table.clear(); + + assertEquals(0, table.size()); + assertNull(table.get("a", 1)); + assertNull(table.get("b", 2)); + } + private static final class PairEntry extends Hashtable.D2.Entry { int value;