[BDMS-264] Expand transfer seeder#232
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. |
TylerAdamMartinez
requested review from
chasetmartin,
jacob-a-brown,
jirhiker and
ksmuczynski
Contributor
Author
|
NO, NOT DELETE THE BRANCH SINCE THE FRONTEND STILL CALLS IT FOR CI/CD AND WILL CONTINUE TO DO SO UNTIL MERGED INTO STAGING. |
ksmuczynski
approved these changes
Nov 5, 2025
ksmuczynski
left a comment
ksmuczynski
left a comment
Contributor
There was a problem hiding this comment.
The order in which the models are created looks good to me. I think the Contact or Location models could be created first, either way should work. The model numbers skip from 2 to 5, but I'm assuming that's just a typo; I don't think any additional core models are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem/context:
• CI Testing will fail without a local DB with some data, and using the transfer script is not practical
How
Implementation summary - the following was changed/added/removed:
• Use Faker to mock dummy data
Notes
Any special considerations, workarounds, or follow-up work to note?
• Please take note of the numbers in the code comments. This is how I think each model should be created in order.