From 466bb187609221a5665fb7a32d5e188bb3a02569 Mon Sep 17 00:00:00 2001 From: jacob-a-brown Date: Wed, 17 Dec 2025 14:22:02 -0700 Subject: [PATCH 1/2] fix: remove duplicate convert_m_to_ft --- services/util.py | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/services/util.py b/services/util.py index 6a7316073..4ac0cc72d 100644 --- a/services/util.py +++ b/services/util.py @@ -45,25 +45,18 @@ def transform_srid(geometry, source_srid, target_srid): return transform(transformer.transform, geometry) -def convert_m_to_ft(meters: float | None) -> float | None: - """Convert a length from meters to feet.""" - if meters is None: - return None - return round(meters * METERS_TO_FEET, 6) - - -def convert_ft_to_m(feet: float | None) -> float | None: +def convert_ft_to_m(feet: float | None, ndigits: int = 6) -> float | None: """Convert a length from feet to meters.""" if feet is None: return None - return round(feet / METERS_TO_FEET, 6) + return round(feet / METERS_TO_FEET, ndigits) -def convert_m_to_ft(meters: float | None) -> float | None: +def convert_m_to_ft(meters: float | None, ndigits: int = 6) -> float | None: """Convert a length from meters to feet.""" if meters is None: return None - return round(meters * METERS_TO_FEET, 6) + return round(meters * METERS_TO_FEET, ndigits) def get_tiger_data( From 29e6208dd8d3893e7cb48a7488b5d42c25ed597c Mon Sep 17 00:00:00 2001 From: jacob-a-brown Date: Wed, 17 Dec 2025 15:02:22 -0700 Subject: [PATCH 2/2] feat: start util tests --- tests/test_util.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 tests/test_util.py diff --git a/tests/test_util.py b/tests/test_util.py new file mode 100644 index 000000000..c7e0c1034 --- /dev/null +++ b/tests/test_util.py @@ -0,0 +1,17 @@ +from services.util import convert_ft_to_m, convert_m_to_ft + + +def test_convert_ft_to_m(): + assert convert_ft_to_m(0) == 0.0 + assert convert_ft_to_m(3.28084) == 1.0 + assert convert_ft_to_m(10) == 3.048 + assert convert_ft_to_m(None) is None + assert convert_ft_to_m(10, ndigits=4) == 3.048 + + +def test_convert_m_to_ft(): + assert convert_m_to_ft(0) == 0.0 + assert convert_m_to_ft(1) == 3.28084 + assert convert_m_to_ft(3.048) == 10.0 + assert convert_m_to_ft(None) is None + assert convert_m_to_ft(3.048, ndigits=4) == 10.0