From a5b56b530e6cabe7df6e9993a6207461128d92b8 Mon Sep 17 00:00:00 2001 From: ace-n Date: Mon, 16 Mar 2020 15:02:08 -0700 Subject: [PATCH 1/3] functions/logging: add stdout/stderr + note about (ignored) Stackdriver severity --- .../main/java/com/example/functions/LogHelloWorld.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/functions/snippets/src/main/java/com/example/functions/LogHelloWorld.java b/functions/snippets/src/main/java/com/example/functions/LogHelloWorld.java index 64457523ce4..1dfe3b56fee 100644 --- a/functions/snippets/src/main/java/com/example/functions/LogHelloWorld.java +++ b/functions/snippets/src/main/java/com/example/functions/LogHelloWorld.java @@ -32,8 +32,12 @@ public class LogHelloWorld implements HttpFunction { @Override public void service(HttpRequest request, HttpResponse response) throws IOException { - LOGGER.info("I am an info log!"); - LOGGER.warning("I am a warning log!"); + System.out.println("I am an info log to stdout!"); + System.err.println("I am an info log to stderr!"); + + // Stackdriver does not detect severity from Cloud Functions log output + LOGGER.info("I am an info log to Stackdriver!"); + LOGGER.warning("I am an info log to Stackdriver!"); BufferedWriter writer = response.getWriter(); writer.write("Messages successfully logged!"); From c19550d3bc22ffd81da732a68574c829496b9636 Mon Sep 17 00:00:00 2001 From: Ace Nassri Date: Mon, 16 Mar 2020 15:20:26 -0700 Subject: [PATCH 2/3] Make messages clearer --- .../main/java/com/example/functions/LogHelloWorld.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/functions/snippets/src/main/java/com/example/functions/LogHelloWorld.java b/functions/snippets/src/main/java/com/example/functions/LogHelloWorld.java index 1dfe3b56fee..944330f348e 100644 --- a/functions/snippets/src/main/java/com/example/functions/LogHelloWorld.java +++ b/functions/snippets/src/main/java/com/example/functions/LogHelloWorld.java @@ -32,12 +32,12 @@ public class LogHelloWorld implements HttpFunction { @Override public void service(HttpRequest request, HttpResponse response) throws IOException { - System.out.println("I am an info log to stdout!"); - System.err.println("I am an info log to stderr!"); + System.out.println("I am a log to stdout!"); + System.err.println("I am a log to stderr!"); // Stackdriver does not detect severity from Cloud Functions log output - LOGGER.info("I am an info log to Stackdriver!"); - LOGGER.warning("I am an info log to Stackdriver!"); + LOGGER.info("I am an info log!"); + LOGGER.warning("I am a warning log!"); BufferedWriter writer = response.getWriter(); writer.write("Messages successfully logged!"); From 2e5ba09e1e5f875dfce71003178f1a376d9c3758 Mon Sep 17 00:00:00 2001 From: ace-n Date: Fri, 20 Mar 2020 20:42:55 -0700 Subject: [PATCH 3/3] Fix tests --- .../src/test/java/com/example/functions/SnippetsTests.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/functions/snippets/src/test/java/com/example/functions/SnippetsTests.java b/functions/snippets/src/test/java/com/example/functions/SnippetsTests.java index c13a6aa3b9e..e1736f63bbc 100644 --- a/functions/snippets/src/test/java/com/example/functions/SnippetsTests.java +++ b/functions/snippets/src/test/java/com/example/functions/SnippetsTests.java @@ -90,7 +90,7 @@ public void beforeTest() throws IOException { @After public void afterTest() { - System.setOut(null); + System.out.flush(); logHandler.flush(); }