Skip to content

M3 Setup + Content#15

Merged
oraqlle merged 11 commits into
devfrom
chapter/m3
Apr 16, 2023
Merged

M3 Setup + Content#15
oraqlle merged 11 commits into
devfrom
chapter/m3

Conversation

@jasparm

@jasparm jasparm commented Apr 10, 2023

Copy link
Copy Markdown
Member

I've put in all the info that I can think of, but I am sure I will have missed stuff, so lemme know what I should add in. Challenges are on their way, but I have a few ideas that I need to do some reading on before I can flesh them out properly.

@jasparm jasparm requested review from Ozzywap, isoyuki and oraqlle April 10, 2023 03:29
@jasparm jasparm self-assigned this Apr 10, 2023
@jasparm jasparm added this to the Initial Release - v1.0.0 milestone Apr 10, 2023
This was linked to issues Apr 10, 2023
@jasparm

jasparm commented Apr 10, 2023

Copy link
Copy Markdown
Member Author

I also changed directory structure a little bit for images for both the m3 section and the getting started section, so images are in a subfolder instead of main chapter folder. Makes it a bit cleaner.

@oraqlle oraqlle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. There's a lot of great stuff here. Just some more general (potential) changes that need discussing. I was thinking of moving the M3 login/get access to M3 to your chapter entirely as I don't want the new recruits fighting with M3 before getting a good grasp on C, the C ecosystem and C workflow. How would you feel about moving the M3 setup to this chapter as the first section? This way they setup and then try to login, do "Hello World" and can immediately get 'feedback' ie. whether they can login or not etc. all at once for M3 and not wait weeks before checking. Let me know what you think. Second is more of a nitpick but rename images/ to imgs to reduce collisions when we merge (again a nitpick, not something that was done incorrectly 😅). I didn't look at the challenges page as you said they are still in works so I'll wait until you are ready to share those. Other than that, just read the more specific stuff I left on some of the lines.

Comment thread src/chapter3/software-tooling.md Outdated
Comment thread src/chapter3/software-tooling.md Outdated
Comment thread src/chapter3/slurm.md
Comment thread src/chapter3/slurm.md
Comment thread src/chapter3/shared-fs.md
Comment thread src/chapter3/bash.md Outdated
Comment thread src/chapter3/linux-cmds.md Outdated
This was unlinked from issues Apr 15, 2023
@jasparm jasparm requested a review from oraqlle April 16, 2023 00:19
@jasparm

jasparm commented Apr 16, 2023

Copy link
Copy Markdown
Member Author

Fixed the merge conflict, except I think i did it stupidly my bad. I just clicked on the resolve merge thing in github and edited it there instead of just editing my branch so it merged from dev to m3??? idk how this stuff works completely

@oraqlle

oraqlle commented Apr 16, 2023

Copy link
Copy Markdown
Contributor

Fixed the merge conflict, except I think i did it stupidly my bad. I just clicked on the resolve merge thing in github and edited it there instead of just editing my branch so it merged from dev to m3??? idk how this stuff works completely

That's okay. It The Git graph looks fine. Everything is merging into dev anyway and there are going to be merge conflicts anyway from all the branches merging together which I will be fixing. I'll review the changes now.

@oraqlle oraqlle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Just a few more changes.

Comment thread src/chapter3/linux-cmds.md Outdated
Comment thread src/chapter3/shared-fs.md Outdated
Comment thread src/chapter3/challenges.md
Comment thread src/chapter3/challenges.md Outdated
@jasparm jasparm requested a review from oraqlle April 16, 2023 06:40

@oraqlle oraqlle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@oraqlle oraqlle merged commit edac7a6 into dev Apr 16, 2023
@oraqlle oraqlle added the enhancement New feature or request label May 8, 2023
@oraqlle oraqlle added M3 Chapter Issues related to the M3 chapter Challenges Repository Issues related to the HPC challenges repository labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Challenges Repository Issues related to the HPC challenges repository enhancement New feature or request M3 Chapter Issues related to the M3 chapter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants