M3 Setup + Content#15
Conversation
|
I also changed directory structure a little bit for images for both the m3 section and the getting started section, so images are in a subfolder instead of main chapter folder. Makes it a bit cleaner. |
oraqlle
left a comment
There was a problem hiding this comment.
Excellent work. There's a lot of great stuff here. Just some more general (potential) changes that need discussing. I was thinking of moving the M3 login/get access to M3 to your chapter entirely as I don't want the new recruits fighting with M3 before getting a good grasp on C, the C ecosystem and C workflow. How would you feel about moving the M3 setup to this chapter as the first section? This way they setup and then try to login, do "Hello World" and can immediately get 'feedback' ie. whether they can login or not etc. all at once for M3 and not wait weeks before checking. Let me know what you think. Second is more of a nitpick but rename images/ to imgs to reduce collisions when we merge (again a nitpick, not something that was done incorrectly 😅). I didn't look at the challenges page as you said they are still in works so I'll wait until you are ready to share those. Other than that, just read the more specific stuff I left on some of the lines.
|
Fixed the merge conflict, except I think i did it stupidly my bad. I just clicked on the resolve merge thing in github and edited it there instead of just editing my branch so it merged from dev to m3??? idk how this stuff works completely |
That's okay. It The Git graph looks fine. Everything is merging into dev anyway and there are going to be merge conflicts anyway from all the branches merging together which I will be fixing. I'll review the changes now. |
oraqlle
left a comment
There was a problem hiding this comment.
Great work. Just a few more changes.
I've put in all the info that I can think of, but I am sure I will have missed stuff, so lemme know what I should add in. Challenges are on their way, but I have a few ideas that I need to do some reading on before I can flesh them out properly.