From e04ff8cde5851b71a64b964920c083e47b64f698 Mon Sep 17 00:00:00 2001
From: Jason Pascucci <jpascucci@nvidia.com>
Date: Wed, 30 Sep 2026 11:31:39 -0700
Subject: [PATCH] Closes #2975

Removed the use of --status, which https://github.com/orgs/community/discussions/24626 is tracking as a stale server side data problem.

Gemini recommends removal of server-side --status and replacement with client side jq.
---
 ci/tools/lookup-run-id               |  3 +-
 ci/tools/tests/test_lookup_run_id.py | 59 ++++++++++++++++++++++------
 2 files changed, 48 insertions(+), 14 deletions(-)

diff --git a/ci/tools/lookup-run-id b/ci/tools/lookup-run-id
index b177727cde5..ff8a153d81c 100755
--- a/ci/tools/lookup-run-id
+++ b/ci/tools/lookup-run-id
@@ -104,7 +104,6 @@ if [[ "${MODE}" == "branch" ]]; then
         --repo "${REPOSITORY}" \
         --branch "${REF}" \
         --workflow "${WORKFLOW_NAME}" \
-        --status success \
         --json databaseId,workflowName,status,conclusion,headSha,headBranch,createdAt,url \
         --limit 100)
 
@@ -206,8 +205,8 @@ RUN_DATA=$(gh run list \
     --repo "${REPOSITORY}" \
     --commit "${COMMIT_SHA}" \
     --workflow "${WORKFLOW_NAME}" \
-    --status completed \
     --json databaseId,workflowName,status,conclusion,headSha,headBranch,event,createdAt,url \
+    --jq 'map(select(.status == "completed"))' \
     --limit 50)
 
 if [[ -z "${RUN_DATA}" || "${RUN_DATA}" == "[]" ]]; then
diff --git a/ci/tools/tests/test_lookup_run_id.py b/ci/tools/tests/test_lookup_run_id.py
index cb972b24ed3..a46d6471f9f 100644
--- a/ci/tools/tests/test_lookup_run_id.py
+++ b/ci/tools/tests/test_lookup_run_id.py
@@ -22,21 +22,31 @@
 if args[:2] == ["run", "list"]:
     runs = json.loads(os.environ["FAKE_RUNS"])
     try:
-        status = args[args.index("--status") + 1]
         limit = int(args[args.index("--limit") + 1])
     except (ValueError, IndexError):
-        print("run list requires --status and --limit", file=sys.stderr)
+        print("run list requires --limit", file=sys.stderr)
         raise SystemExit(2)
-    if status == "success":
-        runs = [run for run in runs if run["conclusion"] == "success"]
-    elif status == "completed":
-        runs = [run for run in runs if run["status"] == "completed"]
-    else:
-        print(f"unsupported status filter: {status}", file=sys.stderr)
+    if "--status" in args:
+        print("status filters are intentionally unsupported", file=sys.stderr)
         raise SystemExit(2)
+    if "--jq" in args:
+        try:
+            jq_filter = args[args.index("--jq") + 1]
+        except IndexError:
+            print("run list --jq requires a value", file=sys.stderr)
+            raise SystemExit(2)
+        if jq_filter == 'map(select(.status == "completed"))':
+            runs = [run for run in runs if run["status"] == "completed"]
+        else:
+            print(f"unsupported jq filter: {jq_filter}", file=sys.stderr)
+            raise SystemExit(2)
     print(json.dumps(runs[:limit]))
     raise SystemExit(0)
 
+if args[:2] == ["run", "view"]:
+    print(json.dumps({"url": "https://example.invalid/runs/view"}))
+    raise SystemExit(0)
+
 if args[:1] == ["api"]:
     if "--paginate" not in args or "--jq" not in args:
         print("artifact lookup must be paginated and filtered", file=sys.stderr)
@@ -60,14 +70,24 @@
 """
 
 
-def _run(run_id, created_at, *, branch="12.9.x", workflow="CI", conclusion="success"):
+def _run(
+    run_id,
+    created_at,
+    *,
+    branch="12.9.x",
+    workflow="CI",
+    conclusion="success",
+    event="push",
+    status="completed",
+):
     return {
         "databaseId": run_id,
         "workflowName": workflow,
-        "status": "completed",
+        "status": status,
         "conclusion": conclusion,
         "headSha": f"sha-{run_id}",
         "headBranch": branch,
+        "event": event,
         "createdAt": created_at,
         "url": f"https://example.invalid/runs/{run_id}",
     }
@@ -104,14 +124,14 @@ def _lookup(fake_gh, runs, artifacts, *args, workflow="CI"):
 
 @pytest.mark.agent_authored(model="gpt-5.6")
 class TestBranchLookup:
-    def test_filters_successful_runs_before_applying_limit(self, fake_gh):
+    def test_filters_successful_runs_without_status_filter(self, fake_gh):
         runs = [
             _run(
                 run_id,
                 "2026-08-13T12:00:00Z",
                 conclusion="failure",
             )
-            for run_id in range(200, 100, -1)
+            for run_id in range(200, 190, -1)
         ]
         runs.append(_run(50, "2026-08-12T12:00:00Z"))
 
@@ -237,3 +257,18 @@ def test_propagates_artifact_api_failures(self, fake_gh):
 
         assert result.returncode == 1
         assert "Failed to list artifacts for run 100" in result.stderr
+
+
+@pytest.mark.agent_authored(model="gpt-5.6")
+class TestTagLookup:
+    def test_filters_completed_runs_without_status_filter(self, fake_gh):
+        runs = [
+            _run(300, "2026-08-13T12:00:00Z", branch="HEAD", status="in_progress"),
+            _run(200, "2026-08-12T12:00:00Z", branch="HEAD"),
+            _run(100, "2026-08-11T12:00:00Z", branch="HEAD"),
+        ]
+
+        result = _lookup(fake_gh, runs, {}, "HEAD")
+
+        assert result.returncode == 0, result.stderr
+        assert result.stdout.strip() == "200"