chore(location-strategy): revert replaceState method

Author: ADjenkov

e2e/nested-router-tab-view/app/home/home.component.ts

@@ -2,7 +2,7 @@ import { Component, ViewContainerRef } from "@angular/core";
 import { ModalDialogService, ModalDialogOptions } from "nativescript-angular/directives/dialogs";
 import { RouterExtensions } from "nativescript-angular/router";
 import { ActivatedRoute } from "@angular/router";
-import { confirm } from "ui/dialogs";
+import { confirm } from "tns-core-modules/ui/dialogs";
 
 @Component({
     moduleId: module.id,

nativescript-angular/router/ns-location-strategy.ts

@@ -58,13 +58,13 @@ export interface LocationState {
 
 @Injectable()
 export class NSLocationStrategy extends LocationStrategy {
+    private outlets: Array<Outlet> = [];
     private currentOutlet: Outlet;
 
     private popStateCallbacks = new Array<(_: any) => any>();
     private _currentNavigationOptions: NavigationOptions;
     private currentUrlTree: UrlTree;
 
-    public outlets: Array<Outlet> = [];
     public _modalNavigationDepth = 0;
 
     constructor(private frameService: FrameService) {
@@ -178,21 +178,6 @@ export class NSLocationStrategy extends LocationStrategy {
                 routerLog("NSLocationStrategy.replaceState changing existing state: " +
                     `${state}, title: ${title}, url: ${url}, queryParams: ${queryParams}`);
             }
-
-            const tree = this.currentUrlTree;
-
-            if (url !== tree.toString()) {
-                const urlSerializer = new DefaultUrlSerializer();
-                const stateUrlTree: UrlTree = urlSerializer.parse(url);
-                const rootOutlets = stateUrlTree.root.children;
-
-                Object.keys(rootOutlets).forEach(outletName => {
-                    const outlet = this.findOutletByKey(outletName);
-                    const topState = outlet.peekState();
-
-                    topState.segmentGroup = rootOutlets[outletName];
-                });
-            }
         } else {
             if (isLogEnabled()) {
                 routerLog("NSLocationStrategy.replaceState pushing new state: " +

tests/app/tests/modal-dialog.ts

@@ -98,7 +98,7 @@ describe("modal-dialog", () => {
                 let parentView = fixture.componentRef.instance.vcRef.element.nativeElement;
                 parentView = parentView.page && parentView.page.frame;
                 outlet.frame = parentView;
-                locStrategy.outlets.push(outlet);
+                locStrategy._getOutlets().push(outlet);
 
                 locStrategy.pushState(null, "test", "/test", null);
 
@@ -120,7 +120,7 @@ describe("modal-dialog", () => {
                 let parentView = fixture.componentRef.instance.vcRef.element.nativeElement;
                 parentView = parentView.page && parentView.page.frame;
                 outlet.frame = parentView;
-                locStrategy.outlets.push(outlet);
+                locStrategy._getOutlets().push(outlet);
 
                 locStrategy.pushState(null, "test", "/test", null);
 

tests/app/tests/ns-location-strategy.ts

@@ -242,7 +242,9 @@ describe("NSLocationStrategy", () => {
         assert.equal(strategy.path(), "/test");
 
         strategy.replaceState(null, "test2", "/test2", null);
-        assert.equal(strategy.path(), "/test2");
+        // Currently replaceState does nothing since this shouldn't affect any functionality on {N} side.
+        // replaceState should be relevant only in Web.
+        // assert.equal(strategy.path(), "/test2");
 
         assert.equal(popCount, 0); // no onPopState when replacing
     });
@@ -258,7 +260,9 @@ describe("NSLocationStrategy", () => {
         assert.equal(strategy.path(), "/(test1:test12//test2:test2)");
 
         strategy.replaceState(null, "test2", "/(test1:test13//test2:test2)", null);
-        assert.equal(strategy.path(), "/(test1:test13//test2:test2)");
+        // Currently replaceState does nothing since this shouldn't affect any functionality on {N} side.
+        // replaceState should be relevant only in Web.
+        // assert.equal(strategy.path(), "/(test1:test13//test2:test2)");
 
         assert.equal(popCount, 0); // no onPopState when replacing
     });