fix(ts): ship package with reference to iterable interface

sis0k0 · sis0k0 · commit 7edfa6b5139c · 2017-03-16T13:55:36.000+02:00
diff --git a/.gitignore b/.gitignore
@@ -9,6 +9,7 @@ tags
 /nativescript-angular/**/*.d.ts
 /nativescript-angular/**/*.js
 
+!/nativescript-angular/iterable.d.ts
 !/nativescript-angular/global.d.ts
 !/nativescript-angular/postinstall.js
 !/nativescript-angular/hooks/**/*.js
@@ -52,4 +53,4 @@ startup-test/node_modules
 !.vscode/settings.json
 !.vscode/tasks.json
 !.vscode/launch.json
-!.vscode/extensions.json
+!.vscode/extensions.json
diff --git a/nativescript-angular/.npmignore b/nativescript-angular/.npmignore
@@ -5,8 +5,8 @@
 
 *.js.map
 
-tsconfig.json
 global.d.ts
+tsconfig.json
 .npmignore
 gulpfile.js
 tslint.json
diff --git a/nativescript-angular/iterable.d.ts b/nativescript-angular/iterable.d.ts
@@ -0,0 +1 @@
+declare interface Iterable<T> {}
diff --git a/nativescript-angular/nativescript.module.ts b/nativescript-angular/nativescript.module.ts
@@ -1,3 +1,5 @@
+/// <reference path="./iterable.d.ts" />
+
 import "globals";
 import "./zone-js/dist/zone-nativescript";
 
diff --git a/nativescript-angular/tsconfig.json b/nativescript-angular/tsconfig.json
@@ -14,7 +14,7 @@
     "noUnusedLocals": true,
     "noUnusedParameters": true,
     "noImplicitAny": false
- },
+},
   "angularCompilerOptions": {
     "genDir": ".",
     "skipMetadataEmit": false,
diff --git a/nativescript-angular/view-util.ts b/nativescript-angular/view-util.ts
@@ -210,7 +210,8 @@ export class ViewUtil {
 
         let index = 0;
         let found = false;
-        parent.eachChild(child => {
+
+        parent._eachLayoutView(child => {
             if (child === node) {
                 found = true;
             }
diff --git a/ng-sample/package.json b/ng-sample/package.json
@@ -23,7 +23,6 @@
   },
   "homepage": "https://github.com/NativeScript/template-hello-world",
   "dependencies": {
-    "tns-core-modules": "~2.5.0",
     "@angular/common": "4.0.0-rc.3",
     "@angular/compiler": "4.0.0-rc.3",
     "@angular/core": "4.0.0-rc.3",
@@ -33,7 +32,8 @@
     "@angular/platform-browser-dynamic": "4.0.0-rc.3",
     "@angular/router": "4.0.0-rc.3",
     "nativescript-angular": "file:../nativescript-angular",
-    "rxjs": "~5.0.1"
+    "rxjs": "~5.0.1",
+    "tns-core-modules": "~2.5.0"
   },
   "devDependencies": {
     "zone.js": "~0.7.2",
@@ -50,7 +50,7 @@
   "nativescript": {
     "id": "org.nativescript.ngsample",
     "tns-android": {
-      "version": "2.4.1"
+      "version": "2.5.0"
     },
     "tns-ios": {
       "version": "2.4.0"
diff --git a/ng-sample/tsconfig.json b/ng-sample/tsconfig.json
@@ -15,4 +15,4 @@
         "node_modules",
         "platforms"
     ]
-}
+}
diff --git a/tests/package.json b/tests/package.json
@@ -1,3 +1,12 @@
+{
+  "nativescript": {
+    "id": "org.nativescript.ngtests",
+    "tns-android": {
+      "version": "2.5.0"
+    },
+    "tns-ios": {
+      "version": "2.5.0"
+    }
   },
   "name": "ngtests",
   "main": "app.js",
@@ -48,7 +57,7 @@
     "nativescript-dev-typescript": "^0.3.1",
     "socket.io": "1.4.8",
     "socket.io-client": "1.4.8",
-    "typescript": "~2.2.0",
+    "typescript": "~2.1.0",
     "wd": "0.4.0",
     "zone.js": "^0.7.2"
   },
diff --git a/tests/references.d.ts b/tests/references.d.ts
@@ -0,0 +1 @@
+/// <reference path="./node_modules/tns-core-modules/tns-core-modules.d.ts" /> Needed for autocompletion and compilation.
diff --git a/tests/tsconfig.json b/tests/tsconfig.json
@@ -4,7 +4,6 @@
         "target": "es5",
         "experimentalDecorators": true,
         "emitDecoratorMetadata": true,
-        "sourceMap": false,
         "noEmitHelpers": true,
         "noEmitOnError": true
     },
@@ -13,4 +12,4 @@
         "platforms",
         "**/*.aot"
     ]
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+/// <reference path="./iterable.d.ts" />`
	`2`	`+`
`1`	`3`	`import "globals";`
`2`	`4`	`import "./zone-js/dist/zone-nativescript";`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,8 @@ export class ViewUtil {`
`210`	`210`
`211`	`211`	`let index = 0;`
`212`	`212`	`let found = false;`
`213`		`- parent.eachChild(child => {`
	`213`	`+`
	`214`	`+ parent._eachLayoutView(child => {`
`214`	`215`	`if (child === node) {`
`215`	`216`	`found = true;`
`216`	`217`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,4 +15,4 @@`
`15`	`15`	`"node_modules",`
`16`	`16`	`"platforms"`
`17`	`17`	`]`
`18`		`-}`
	`18`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+/// <reference path="./node_modules/tns-core-modules/tns-core-modules.d.ts" /> Needed for autocompletion and compilation.`