Skip to content

feat(android): add option for showing internal/external storage#302

Merged
tgpetrov merged 1 commit into
NativeScript:masterfrom
xuhcc:sd-card
Sep 9, 2019
Merged

feat(android): add option for showing internal/external storage#302
tgpetrov merged 1 commit into
NativeScript:masterfrom
xuhcc:sd-card

Conversation

@xuhcc

@xuhcc xuhcc commented Aug 27, 2019

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

Internal and external storage may not be shown by default in Android file chooser.

What is the new behavior?

The new showAdvanced option forces the file chooser to show these locations. However, under the hood, it uses an undocumented android function, so the warning was added to readme.

I also removed two broken links from TOC.

@cla-bot cla-bot Bot added the cla: yes label Aug 27, 2019
@tgpetrov

tgpetrov commented Sep 4, 2019

Copy link
Copy Markdown
Contributor

@xuhcc We are experiencing an issue with saucelabs where we run our tests which is the reason for their failure, as soon as we sort it out we can proceed with merging your PRs.

@tgpetrov

tgpetrov commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

@xuhcc Can you rebase your branch with latest changes from master so a can merge it?

@xuhcc

xuhcc commented Sep 9, 2019

Copy link
Copy Markdown
Contributor Author

@tgpetrov Done.

@tgpetrov tgpetrov merged commit 5ac9aa7 into NativeScript:master Sep 9, 2019
@xuhcc xuhcc deleted the sd-card branch September 9, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants