From 27f0474c61f679e1e42d0f9b0a2a060fbea79734 Mon Sep 17 00:00:00 2001 From: Jammy2211 Date: Thu, 30 Jul 2026 15:16:42 +0100 Subject: [PATCH] chore: de-instance firewall comments + bump v2/v1 release.yml actions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Clears the standing 'manifest drift: tenant firewall — 2 mismatch(es)': the autocti_workspace mentions in generate.py's and its test's incident narration become 'an unregistered workspace' (the specifics live in git history and PyAutoHands#215; the firewall allowlist doctrine says never grow it casually). Also bumps release.yml's checkout@v2 -> v4 and setup-python@v2 -> v5 to the fleet standard — purely mechanical version strings, no step-logic changes. PyAutoHands#217. Suite: 258 passed. Co-Authored-By: Claude Fable 5 --- .github/workflows/release.yml | 24 ++++++++++++------------ autohands/generate.py | 2 +- tests/test_generate_validates_project.py | 2 +- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index a694f853..3e35d2a0 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -108,17 +108,17 @@ jobs: ref: main path: PyAutoLens steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: path: PyAutoHands - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: repository: "${{ matrix.project.repository }}" ref: "${{ matrix.project.ref }}" path: "${{ matrix.project.path }}" - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v2 + uses: actions/setup-python@v5 with: python-version: ${{ matrix.python-version }} - name: Build @@ -390,7 +390,7 @@ jobs: path: PyAutoLens pat: PAT_PYAUTOLABS steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: path: PyAutoHands - name: Checkout @@ -398,7 +398,7 @@ jobs: PAT="${{ secrets[matrix.project.pat] }}" git clone -b "${{ matrix.project.ref }}" "https://$PAT@github.com/${{ matrix.project.repository }}.git" "${{ matrix.project.path }}" - name: Set up Python 3.12 - uses: actions/setup-python@v2 + uses: actions/setup-python@v5 with: python-version: "3.12" - name: Configure Git @@ -498,11 +498,11 @@ jobs: - publish_release_notes if: "${{ always() && needs.resolve_mode.outputs.rehearsal != 'true' }}" steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: path: PyAutoHands - name: Set up Python - uses: actions/setup-python@v2 + uses: actions/setup-python@v5 with: python-version: '3.12' - name: Announce release outcome in Slack @@ -552,11 +552,11 @@ jobs: - repo: PyAutoLabs/PyAutoLens pat: PAT_PYAUTOLABS steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: path: PyAutoHands - name: Set up Python - uses: actions/setup-python@v2 + uses: actions/setup-python@v5 with: python-version: '3.12' - name: Publish release notes @@ -636,7 +636,7 @@ jobs: bump_colab_urls: false write_api_baseline: true steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: path: PyAutoHands - name: Checkout @@ -647,7 +647,7 @@ jobs: git config --global user.email "richard@rghsoftware.co.uk" git config --global user.name "GitHub Actions bot" - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v2 + uses: actions/setup-python@v5 with: python-version: ${{ matrix.python-version }} - name: Install Jupyter dependency @@ -772,7 +772,7 @@ jobs: - PyAutoLabs/PyAutoGalaxy - PyAutoLabs/PyAutoLens steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: path: PyAutoHands - name: Checkout library diff --git a/autohands/generate.py b/autohands/generate.py index b4bfb47d..c83f6ca1 100644 --- a/autohands/generate.py +++ b/autohands/generate.py @@ -63,7 +63,7 @@ def copy_to_notebooks(source): # clears the whole `notebooks/` tree, while `inject_colab_setup` only # rejects an unknown project deep inside the per-script loop that follows # it — so running this on an unregistered project deleted 113 tracked - # notebooks in autocti_workspace and *then* aborted. A workspace with a + # notebooks in an unregistered workspace and *then* aborted. A workspace with a # root `start_here.py` happened to fail safely (that loop injects before # the rmtree); one without it did not. `build_util.COLAB_PROJECTS` stays # the single source of truth, and `inject_colab_setup`'s own raise remains diff --git a/tests/test_generate_validates_project.py b/tests/test_generate_validates_project.py index 585f676b..d765bf76 100644 --- a/tests/test_generate_validates_project.py +++ b/tests/test_generate_validates_project.py @@ -3,7 +3,7 @@ `generate.py` clears the whole ``notebooks/`` tree, and until this was fixed the only rejection of an unknown project happened inside the per-script loop that runs *after* that rmtree — so running it on an unregistered project deleted 113 -tracked notebooks in `autocti_workspace` and then aborted. These tests pin the +tracked notebooks in an unregistered workspace and then aborted. These tests pin the ordering, since the failure is invisible in a passing run. Driven as a subprocess: `generate.py` parses argv and does all its work at