capture the functional oneTBB modifications as patches

Comparing src/tbb against a pristine oneTBB 2022.0.0 turns up 41 modified
files. Most are workarounds for over-zealous CRAN checks -- commented-out
'#pragma warning' / '#pragma GCC diagnostic' directives and the like -- and
are not worth carrying. Seven are not:

- src/tbb/def/{lin32,lin64,mac64}-tbb.def add
  tbb::internal::task_scheduler_observer_v3::observe to the export list,
  under a comment reading 'Needed by rstan', along with std:: exception
  typeinfo and destructors for backwards compatibility. These are the
  Linux/macOS counterpart of the Windows tbb.dll stub, so losing them would
  break rstan on exactly the platforms where it currently works.

- The four CMakeLists.txt files drop VERSION / SOVERSION, so the build emits
  unversioned libraries. install.libs.R's versionBundledTbbLibraries() then
  re-creates the 'libtbb.so.2' layout (#260); the two have to stay in step.

Both patches verified by applying them to a pristine tree and confirming
every touched file matches what we ship.

Author: kevinushey

patches/legacy_tbb_abi.diff

@@ -171,3 +171,90 @@
 +
 +#endif /* _WIN32 */
 \ No newline at end of file
+--- a/src/tbb/src/tbb/def/lin32-tbb.def
++++ b/src/tbb/src/tbb/def/lin32-tbb.def
+@@ -17,6 +17,26 @@
+ {
+ global:
+ 
++/* Needed for backwards compatibility */
++_ZNSt13runtime_errorD1Ev;
++_ZTISt13runtime_error;
++_ZTSSt13runtime_error;
++_ZNSt16invalid_argumentD1Ev;
++_ZTISt16invalid_argument;
++_ZTSSt16invalid_argument;
++_ZNSt11range_errorD1Ev;
++_ZTISt11range_error;
++_ZTSSt11range_error;
++_ZNSt12length_errorD1Ev;
++_ZTISt12length_error;
++_ZTSSt12length_error;
++_ZNSt12out_of_rangeD1Ev;
++_ZTISt12out_of_range;
++_ZTSSt12out_of_range;
++
++/* Needed by rstan */
++_ZN3tbb8internal26task_scheduler_observer_v37observeEb;
++
+ /* Assertions (assert.cpp) */
+ _ZN3tbb6detail2r117assertion_failureEPKciS3_S3_;
+ 
+--- a/src/tbb/src/tbb/def/lin64-tbb.def
++++ b/src/tbb/src/tbb/def/lin64-tbb.def
+@@ -17,6 +17,26 @@
+ {
+ global:
+ 
++/* Needed for backwards compatibility */
++_ZNSt13runtime_errorD1Ev;
++_ZTISt13runtime_error;
++_ZTSSt13runtime_error;
++_ZNSt16invalid_argumentD1Ev;
++_ZTISt16invalid_argument;
++_ZTSSt16invalid_argument;
++_ZNSt11range_errorD1Ev;
++_ZTISt11range_error;
++_ZTSSt11range_error;
++_ZNSt12length_errorD1Ev;
++_ZTISt12length_error;
++_ZTSSt12length_error;
++_ZNSt12out_of_rangeD1Ev;
++_ZTISt12out_of_range;
++_ZTSSt12out_of_range;
++
++/* Needed by rstan */
++_ZN3tbb8internal26task_scheduler_observer_v37observeEb;
++
+ /* Assertions (assert.cpp) */
+ _ZN3tbb6detail2r117assertion_failureEPKciS3_S3_;
+ 
+--- a/src/tbb/src/tbb/def/mac64-tbb.def
++++ b/src/tbb/src/tbb/def/mac64-tbb.def
+@@ -19,6 +19,26 @@
+ # be listed WITHOUT one leading underscore. __TBB_SYMBOL macro should add underscore when
+ # necessary, depending on the intended usage.
+ 
++# Needed for backwards compatibility
++__ZNSt13runtime_errorD1Ev
++__ZTISt13runtime_error
++__ZTSSt13runtime_error
++__ZNSt16invalid_argumentD1Ev
++__ZTISt16invalid_argument
++__ZTSSt16invalid_argument
++__ZNSt11range_errorD1Ev
++__ZTISt11range_error
++__ZTSSt11range_error
++__ZNSt12length_errorD1Ev
++__ZTISt12length_error
++__ZTSSt12length_error
++__ZNSt12out_of_rangeD1Ev
++__ZTISt12out_of_range
++__ZTSSt12out_of_range
++
++# Needed by rstan
++__ZN3tbb8internal26task_scheduler_observer_v37observeEb
++
+ # Assertions (assert.cpp)
+ __ZN3tbb6detail2r117assertion_failureEPKciS3_S3_
+ 

patches/unversioned_libraries.diff

@@ -0,0 +1,46 @@
+--- a/src/tbb/src/tbb/CMakeLists.txt
++++ b/src/tbb/src/tbb/CMakeLists.txt
+@@ -90,8 +90,6 @@
+ # Avoid use of target_link_libraries here as it changes /DEF option to \DEF on Windows.
+ set_target_properties(tbb PROPERTIES
+     DEFINE_SYMBOL ""
+-    VERSION ${TBB_BINARY_VERSION}.${TBB_BINARY_MINOR_VERSION}
+-    SOVERSION ${TBB_BINARY_VERSION}
+ )
+ 
+ tbb_handle_ipo(tbb)
+--- a/src/tbb/src/tbbbind/CMakeLists.txt
++++ b/src/tbb/src/tbbbind/CMakeLists.txt
+@@ -53,8 +53,6 @@
+     # Avoid use of target_link_libraries here as it changes /DEF option to \DEF on Windows.
+     set_target_properties(${TBBBIND_NAME} PROPERTIES
+         DEFINE_SYMBOL ""
+-        VERSION ${TBBBIND_BINARY_VERSION}.${TBB_BINARY_MINOR_VERSION}
+-        SOVERSION ${TBBBIND_BINARY_VERSION}
+     )
+ 
+     tbb_handle_ipo(${TBBBIND_NAME})
+--- a/src/tbb/src/tbbmalloc/CMakeLists.txt
++++ b/src/tbb/src/tbbmalloc/CMakeLists.txt
+@@ -70,8 +70,6 @@
+ # Avoid use of target_link_libraries here as it changes /DEF option to \DEF on Windows.
+ set_target_properties(tbbmalloc PROPERTIES
+     DEFINE_SYMBOL ""
+-    VERSION ${TBBMALLOC_BINARY_VERSION}.${TBB_BINARY_MINOR_VERSION}
+-    SOVERSION ${TBBMALLOC_BINARY_VERSION}
+     LINKER_LANGUAGE C
+ )
+ 
+--- a/src/tbb/src/tbbmalloc_proxy/CMakeLists.txt
++++ b/src/tbb/src/tbbmalloc_proxy/CMakeLists.txt
+@@ -54,10 +54,6 @@
+     ${TBB_COMMON_COMPILE_FLAGS}
+ )
+ 
+-set_target_properties(tbbmalloc_proxy PROPERTIES
+-    VERSION ${TBBMALLOC_BINARY_VERSION}.${TBB_BINARY_MINOR_VERSION}
+-    SOVERSION ${TBBMALLOC_BINARY_VERSION})
+-
+ if (UNIX AND NOT APPLE)
+     # Avoid use of target_link_libraries here as it changes /DEF option to \DEF on Windows.
+     set_target_properties(tbbmalloc_proxy PROPERTIES