Skip to content

Commit 6cf07e2

Browse files
committed
clarify that arch subdirs are not Windows-specific in test comments
1 parent 0e721e6 commit 6cf07e2

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

tests/test-arch-system-file.R

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
# Unit tests for archSystemFile(), the arch-aware wrapper around system.file()
2-
# introduced when systemFile() was renamed (see #251, #252). It injects the
3-
# architecture-specific subdirectory (.Platform$r_arch) used on Windows, e.g.
4-
# archSystemFile("lib") -> 'lib/x64', while behaving like system.file()
5-
# elsewhere. Note that this subdirectory only ever holds compiled libraries
6-
# ('lib', 'libs'); headers and other resources are never installed under it.
2+
# introduced when systemFile() was renamed (see #251, #252). When R is built
3+
# multi-arch -- typically Windows, but also possible on Linux and macOS -- it
4+
# installs compiled libraries under an architecture-specific subdirectory named
5+
# by .Platform$r_arch, e.g. 'libs/x64'. archSystemFile() injects that subdir,
6+
# and behaves like system.file() when r_arch is unset. Note the subdir only
7+
# ever holds compiled libraries ('lib', 'libs'); headers and other resources
8+
# are never installed under it.
79

810
RcppParallel:::test_init()
911

@@ -40,8 +42,8 @@ assert(samePath(archSystemFile("lib"), expected("lib")))
4042
assert(samePath(archSystemFile("lib", "libtbb.so"), expected("lib", "libtbb.so")))
4143

4244
# the package's own compiled code is installed under 'libs' (or 'libs/<arch>'
43-
# on Windows) -- exactly the arch-aware lookup archSystemFile() exists for --
44-
# so it must resolve to an existing directory on every platform
45+
# under a multi-arch R) -- exactly the arch-aware lookup archSystemFile()
46+
# exists for -- so it must resolve to an existing directory on every platform
4547
libs <- archSystemFile("libs")
4648
assert(nzchar(libs))
4749
assert(dir.exists(libs))

0 commit comments

Comments
 (0)