Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

[DNM] Introduce lexical to improve textarea (better context mention UX, no more hacks with regex, etc)#2881

Closed
elianiva wants to merge 3 commits into
RooCodeInc:mainfrom
elianiva:feat/better-textarea
Closed

[DNM] Introduce lexical to improve textarea (better context mention UX, no more hacks with regex, etc)#2881
elianiva wants to merge 3 commits into
RooCodeInc:mainfrom
elianiva:feat/better-textarea

Conversation

@elianiva

@elianiva elianiva commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

it's still in a very rough condition, but basic text editing works for now
just putting this up to let people know and avoid duplicate effort

todo:

  • basic text editing
  • properly handle keyboard events
  • handle commands (currently only used to change mode, but we can expand the idea further)
  • handle copy/paste for files
  • handle drag and drop
  • handle mention (file, commits, etc)
  • display mention in a better format
  • show included context in current prompt
  • other edge cases i haven't found yet
  • add tests, there's currently none

a lot of these are generated by gemini 2.5 pro as you can tell by a lot of these useless comments, i've adjusted a few of them but there are still a lot of stuff that needs to be fixed ((it was struggling with apply_diff a lot once it reaches a certain point i ended up stopping it and just do it by hand))

i'll be adjusting/fixing them along the way and posting updates here (and discord)

feel free to comments any of your ideas :)

@changeset-bot

changeset-bot Bot commented Apr 23, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ff20b25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cte

cte commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

Nice! I noticed that they have a mentions plugin; should we use that or roll our own?

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 23, 2025
@elianiva

Copy link
Copy Markdown
Contributor Author

Nice! I noticed that they have a mentions plugin; should we use that or roll our own?

currently i want to try to roll our own because i want to experiment a bit with it, having more control is good

@hannesrudolph hannesrudolph moved this from PR [Pre Approval Review] to PR [Draft/WIP] in Roo Code Roadmap May 10, 2025
@hannesrudolph hannesrudolph moved this from New to PR [Draft/WIP] in Roo Code Roadmap May 20, 2025
@hannesrudolph hannesrudolph moved this from PR [Draft / In Progress] to TEMP in Roo Code Roadmap May 26, 2025
@daniel-lxs daniel-lxs moved this from TEMP to PR [Draft / In Progress] in Roo Code Roadmap May 26, 2025
@elianiva

elianiva commented Jun 4, 2025

Copy link
Copy Markdown
Contributor Author

i'll close this one for now, this doesn't have a clear feature description and has been left behind quiet far

i will revisit this and make and issue-first approach later when i've written all the things we need to consider

@elianiva elianiva closed this Jun 4, 2025
@github-project-automation github-project-automation Bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Jun 4, 2025
@github-project-automation github-project-automation Bot moved this from PR [Draft/WIP] to Done in Roo Code Roadmap Jun 4, 2025
@elianiva elianiva deleted the feat/better-textarea branch June 4, 2025 16:29
@cte

cte commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

LMK if I can help with this - it's been on my list to explore for a while.

@elianiva elianiva mentioned this pull request Jun 5, 2025
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants