From 32dc8dfb753d247028ead5d9ebe9000c6fd2ffd7 Mon Sep 17 00:00:00 2001 From: ScriptedAlchemy Date: Mon, 31 Aug 2026 06:42:40 +0000 Subject: [PATCH] refactor(examples): drop explicit skills lists in favor of convention discovery (skills-starter, mcp-app) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Convention discovery (config/discover.ts) already finds every skills/*/SKILL.md directory when the config is silent, so the explicit lists in skills-starter and mcp-app named exactly what discovery finds. Dropping them is behavior-identical — inspect output differs only in skills[*].provenance.kind flipping explicit → conventional (plus the digests over the edited files) — and teaches the convention instead of duplicating it. The skills-starter README now says skills are discovered from skills/ automatically. --- examples/mcp-app/agent-bundle.config.ts | 1 - examples/skills-starter/README.md | 5 +++-- examples/skills-starter/agent-bundle.config.ts | 5 ----- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/examples/mcp-app/agent-bundle.config.ts b/examples/mcp-app/agent-bundle.config.ts index 54ac496f4..2072b0928 100644 --- a/examples/mcp-app/agent-bundle.config.ts +++ b/examples/mcp-app/agent-bundle.config.ts @@ -27,6 +27,5 @@ export default defineConfig({ scripts: { 'check-service-fixture': './src/scripts/check-service-fixture.ts', }, - skills: ['skills/service-readiness'], targets: ['portable', 'codex', 'claude'], }); diff --git a/examples/skills-starter/README.md b/examples/skills-starter/README.md index df807fbe3..a27deebdd 100644 --- a/examples/skills-starter/README.md +++ b/examples/skills-starter/README.md @@ -12,8 +12,9 @@ required. Both eval suites are deterministic and read only checked-in fixtures. ## What is authored -- `agent-bundle.config.ts` declares the plugin, its three Skills, and portable, Codex, - and Claude targets. +- `agent-bundle.config.ts` declares the plugin and its portable, Codex, and + Claude targets. The Skills are not listed there: every `skills/*/SKILL.md` + directory is discovered automatically by convention. - `skills/incident-triage/SKILL.md` guides a production incident from first signal through containment, evidence collection, and a handoff-ready update. - `skills/dependency-upgrade/SKILL.md` plans dependency upgrades with API, diff --git a/examples/skills-starter/agent-bundle.config.ts b/examples/skills-starter/agent-bundle.config.ts index d6ae69a06..d6e7a2de1 100644 --- a/examples/skills-starter/agent-bundle.config.ts +++ b/examples/skills-starter/agent-bundle.config.ts @@ -6,10 +6,5 @@ export default defineConfig({ name: 'skills-starter', version: '1.0.0', }, - skills: [ - 'skills/dependency-upgrade', - 'skills/incident-triage', - 'skills/release-review', - ], targets: ['portable', 'codex', 'claude'], });