From 12a0348b78e54e3c6a4acbc38b48e37e44388b6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Mendon=C3=A7a=20Fran=C3=A7a?= Date: Thu, 30 Oct 2025 21:04:18 +0000 Subject: [PATCH 1/2] Enable Migration/DepartmentName cop --- rubocop.yml | 5 ----- test/fixtures/full_config.yml | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/rubocop.yml b/rubocop.yml index c18c1dc9..27eb75ce 100644 --- a/rubocop.yml +++ b/rubocop.yml @@ -532,11 +532,6 @@ Metrics/PerceivedComplexity: Enabled: false -# Migration Department -Migration/DepartmentName: - Enabled: false - - # Naming Department Naming/AccessorMethodName: Enabled: false diff --git a/test/fixtures/full_config.yml b/test/fixtures/full_config.yml index 30fd2718..f0f9bd93 100644 --- a/test/fixtures/full_config.yml +++ b/test/fixtures/full_config.yml @@ -2132,7 +2132,7 @@ Metrics/PerceivedComplexity: Migration/DepartmentName: Description: Check that cop names in rubocop:disable (etc) comments are given with department name. - Enabled: false + Enabled: true VersionAdded: '0.75' Naming/AccessorMethodName: Description: Checks the naming of accessor methods for get_/set_. From 117885ba4173967e3b4a4f8e5eedffef3dee1b64 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Mendon=C3=A7a=20Fran=C3=A7a?= Date: Thu, 30 Oct 2025 21:17:09 +0000 Subject: [PATCH 2/2] Enable cops in the Naming department - [Naming/BlockParameterName](https://docs.rubocop.org/rubocop/cops_naming.html#namingblockparametername) - [Naming/ClassAndModuleCamelCase](https://docs.rubocop.org/rubocop/cops_naming.html#namingclassandmodulecamelcase) - [Naming/ConstantName](https://docs.rubocop.org/rubocop/cops_naming.html#namingconstantname) - [Naming/HeredocDelimiterCase](https://docs.rubocop.org/rubocop/cops_naming.html#namingheredocdelimitercase) - [Naming/MethodName](https://docs.rubocop.org/rubocop/cops_naming.html#namingmethodname) - [Naming/MethodParameterName](https://docs.rubocop.org/rubocop/cops_naming.html#namingmethodparametername) - [Naming/VariableName](https://docs.rubocop.org/rubocop/cops_naming.html#namingvariablename) --- rubocop.yml | 22 +--------------------- test/fixtures/full_config.yml | 19 +++++++++---------- 2 files changed, 10 insertions(+), 31 deletions(-) diff --git a/rubocop.yml b/rubocop.yml index 27eb75ce..e9191270 100644 --- a/rubocop.yml +++ b/rubocop.yml @@ -545,34 +545,17 @@ Naming/BinaryOperatorParameterName: Naming/BlockForwarding: Enabled: false -Naming/BlockParameterName: - Enabled: false - -Naming/ClassAndModuleCamelCase: - Enabled: false - -Naming/ConstantName: - Enabled: false - Naming/FileName: Enabled: false -Naming/HeredocDelimiterCase: - Enabled: false - Naming/HeredocDelimiterNaming: Enabled: false Naming/MemoizedInstanceVariableName: Enabled: false -Naming/MethodName: - Enabled: false - AllowedPatterns: - - '\Atest_' - Naming/MethodParameterName: - Enabled: false + MinNameLength: 1 <% if rubocop_version >= "1.76" %> Naming/PredicateMethod: @@ -593,9 +576,6 @@ Naming/PredicateName: Naming/RescuedExceptionsVariableName: Enabled: false -Naming/VariableName: - Enabled: false - Naming/VariableNumber: Enabled: false diff --git a/test/fixtures/full_config.yml b/test/fixtures/full_config.yml index f0f9bd93..ccc85235 100644 --- a/test/fixtures/full_config.yml +++ b/test/fixtures/full_config.yml @@ -2165,7 +2165,7 @@ Naming/BlockForwarding: Naming/BlockParameterName: Description: Checks for block parameter names that contain capital letters, end in numbers, or do not meet a minimal length. - Enabled: false + Enabled: true VersionAdded: '0.53' VersionChanged: '0.77' MinNameLength: 1 @@ -2175,7 +2175,7 @@ Naming/BlockParameterName: Naming/ClassAndModuleCamelCase: Description: Use CamelCase for classes and modules. StyleGuide: "#camelcase-classes" - Enabled: false + Enabled: true VersionAdded: '0.50' VersionChanged: '0.85' AllowedNames: @@ -2183,7 +2183,7 @@ Naming/ClassAndModuleCamelCase: Naming/ConstantName: Description: Constants should use SCREAMING_SNAKE_CASE. StyleGuide: "#screaming-snake-case" - Enabled: false + Enabled: true VersionAdded: '0.50' Naming/FileName: Description: Use snake_case for source file names. @@ -2246,7 +2246,7 @@ Naming/FileName: Naming/HeredocDelimiterCase: Description: Use configured case for heredoc delimiters. StyleGuide: "#heredoc-delimiters" - Enabled: false + Enabled: true VersionAdded: '0.50' VersionChanged: '1.2' EnforcedStyle: uppercase @@ -2303,15 +2303,14 @@ Naming/MemoizedInstanceVariableName: Naming/MethodName: Description: Use the configured style when naming methods. StyleGuide: "#snake-case-symbols-methods-vars" - Enabled: false + Enabled: true VersionAdded: '0.50' VersionChanged: '1.75' EnforcedStyle: snake_case SupportedStyles: - snake_case - camelCase - AllowedPatterns: - - "\\Atest_" + AllowedPatterns: [] ForbiddenIdentifiers: - __id__ - __send__ @@ -2319,10 +2318,10 @@ Naming/MethodName: Naming/MethodParameterName: Description: Checks for method parameter names that contain capital letters, end in numbers, or do not meet a minimal length. - Enabled: false + Enabled: true VersionAdded: '0.53' VersionChanged: '0.77' - MinNameLength: 3 + MinNameLength: 1 AllowNamesEndingInNumbers: true AllowedNames: - as @@ -2381,7 +2380,7 @@ Naming/RescuedExceptionsVariableName: Naming/VariableName: Description: Use the configured style when naming variables. StyleGuide: "#snake-case-symbols-methods-vars" - Enabled: false + Enabled: true VersionAdded: '0.50' VersionChanged: '1.73' EnforcedStyle: snake_case