Removed SetKeyValue check, as it causes issues with certain entity keyvalues. The problem arises from certain <class>::KeyValue internal calls to the BaseClass::KeyValue do not return true/false properly.

The above change allows us to remove the Weapon.set_color method, as it fixes the issue causing us to have to resort to using that method.

Author: satoon101

addons/source-python/packages/source-python/entities/entity.py

@@ -321,7 +321,7 @@ def get_color(self):
     def set_color(self, color):
         """Set the entity's color."""
         # Set the entity's render mode
-        self.render_mode |= RenderMode.TRANS_COLOR
+        self.render_mode = RenderMode.TRANS_COLOR
 
         # Set the entity's color
         self.render_color = color

addons/source-python/packages/source-python/weapons/entity.py

@@ -146,16 +146,3 @@ def set_secondary_fire_ammo(self, value):
     secondary_fire_ammo = property(
         get_secondary_fire_ammo, set_secondary_fire_ammo,
         doc="""Property to get/set the weapon's secondary fire ammo.""")
-
-    def set_color(self, color):
-        """Set the weapon's color."""
-        color = color.r + (color.g << 8) + (color.b << 16) + (color.a << 24)
-        if color >= 2**31:
-            color -= 2**32
-        self.render_mode_prop |= 1
-        self.render_fx |= 256
-        self.render = color
-
-    color = property(
-        Entity.get_color, set_color,
-        doc="""Property to get/set the weapon's color.""")

src/core/modules/entities/entities_entity.h

@@ -182,9 +182,14 @@ class CBaseEntityWrapper: public IServerEntity
 	template<class T>
 	void SetKeyValue(const char* szName, T value)
 	{
-		if (!servertools->SetKeyValue(GetThis(), szName, value))
-			BOOST_RAISE_EXCEPTION(PyExc_NameError, "\"%s\" is not a valid KeyValue for entity class \"%s\".",
-				szName, GetDataDescMap()->dataClassName);
+		/*
+			Removing this conditional/exception as it causes issues with certain entity keyvalues
+		*/
+		//	if (!servertools->SetKeyValue(GetThis(), szName, value))
+		//		BOOST_RAISE_EXCEPTION(PyExc_NameError, "\"%s\" is not a valid KeyValue for entity class \"%s\".",
+		//			szName, GetDataDescMap()->dataClassName);
+
+		servertools->SetKeyValue(GetThis(), szName, value);
 	}
 
 	edict_t* GetEdict()