feat(toolset): inherit feedback from MCP, add disable flag#375
Draft
willleeney wants to merge 1 commit into
Draft
feat(toolset): inherit feedback from MCP, add disable flag#375willleeney wants to merge 1 commit into
willleeney wants to merge 1 commit into
Conversation
The StackOne MCP server now exposes submit_feedback as a global tool on
every account, so the SDK no longer defines/injects its own feedback tool
— it inherits submit_feedback straight from the MCP catalog and executes it
through the same /actions/rpc path as every other tool.
- Remove createFeedbackTool + its unconditional injection in fetchTools
(and the src/feedback.ts REST tool that POSTed to the removed
/ai/tool-feedback endpoint) and its export.
- fetchTools keeps submit_feedback available by default even when
provider/action filters are applied (those are connector-keyed), collapses
it to a single instance across multi-account fetches, and drops it only
when { feedback: false } is passed.
- Mock MCP server now registers submit_feedback unconditionally, mirroring
production so tests exercise the real inherited-from-MCP path.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The StackOne MCP server now exposes
submit_feedbackas a global tool on every account (see unified-cloud-api PR #8507). This SDK no longer defines or injects its own feedback tool — it inheritssubmit_feedbackstraight from the MCP catalog and executes it through the same/actions/rpcpath as every other tool (that PR teaches/actions/rpcto dispatchsubmit_feedback).createFeedbackTool+ its unconditional injection infetchTools, thesrc/feedback.tsREST tool (which POSTed to the now-removed/ai/tool-feedback), and itsindex.tsexport.fetchToolskeepssubmit_feedbackavailable even whenproviders/actionsfilters are applied (those are connector-keyed and would otherwise drop it), collapses it to a single instance across multi-account fetches, and removes it only when{ feedback: false }is passed.submit_feedbackunconditionally, mirroring production so tests exercise the real inherited-from-MCP path.unified-cloud-api PR #8507 (global
submit_feedbackMCP tool +/actions/rpcdispatch). Draft until that merges — executing feedback will 404 until then.Test plan
pnpm test— updatedtoolsets.test.ts; existing filter/multi-account tests now assertsubmit_feedback(renamed from the old injectedtool_feedback), plus new tests: on-by-default,{ feedback: false }disables, survives provider filter unless disabled, and appears exactly once across accounts. Deletedfeedback.test.ts.🤖 Generated with Claude Code
Summary by cubic
Inherit
submit_feedbackfrom MCP as a global tool and add an option to disable it. This removes the SDK’s custom feedback tool and routes feedback through/actions/rpclike any other tool.Refactors
createFeedbackTool,src/feedback.ts, its export, andsrc/feedback.test.ts.fetchToolsnow keepssubmit_feedbackby default (even withproviders/actionsfilters), collapses it to one instance across multi-account fetches, and drops it only with{ feedback: false }.submit_feedbackfor every account to match production.Migration
submit_feedbackand dispatches it via/actions/rpc.tool_feedbacktosubmit_feedback.fetchTools({ feedback: false }).Written for commit aa1fde0. Summary will update on new commits.