From e267566ee13a84c2a1a12da813d6067e3c4fac58 Mon Sep 17 00:00:00 2001 From: Kevin Van Cott Date: Mon, 6 Jul 2026 18:44:25 -0500 Subject: [PATCH] fix: some more small sorting optimizations --- examples/preact/kitchen-sink/src/main.tsx | 5 +- .../react/kitchen-sink/src/routes/index.tsx | 5 +- examples/solid/kitchen-sink/src/App.tsx | 5 +- .../src/core/rows/coreRowsFeature.ts | 1 + .../rowSelectionFeature.utils.ts | 3 +- .../row-sorting/createSortedRowModel.ts | 41 +++- .../row-sorting/rowSortingFeature.utils.ts | 3 +- packages/table-core/src/utils.ts | 21 ++ .../row-selection/rowSelectionFeature.test.ts | 35 ++++ .../tests/unit/core/rows/constructRow.test.ts | 28 +++ .../row-sorting/createSortedRowModel.test.ts | 118 +++++++++++- perf-done.md | 116 ++++++++++- perf-skipped.md | 77 +++++++- perf-todo.md | 181 +----------------- 14 files changed, 439 insertions(+), 200 deletions(-) diff --git a/examples/preact/kitchen-sink/src/main.tsx b/examples/preact/kitchen-sink/src/main.tsx index 6de73e2255..f2cdd73d2d 100644 --- a/examples/preact/kitchen-sink/src/main.tsx +++ b/examples/preact/kitchen-sink/src/main.tsx @@ -488,7 +488,10 @@ function App() { getGroupingValue: (row) => `${row.firstName} ${row.lastName}`, cell: ({ row, getValue }) => (
- {row.getCanExpand() ? ( + {/* On a grouped row the grouped-cell wrapper already renders the + expander, so don't render a second one here. This expander is + only for expanding nested sub-rows. */} + {row.getIsGrouped() ? null : row.getCanExpand() ? (