Check sdk in action

Author: EgorkaKulikov

utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/models/GenerateTestsModel.kt

@@ -79,14 +79,6 @@ data class GenerateTestsModel(
     }
     var runGeneratedTestsWithCoverage : Boolean = false
     var enableSummariesGeneration : Boolean = true
-
-    val jdkVersion: JavaSdkVersion?
-        get() = try {
-            testModule.jdkVersion()
-        } catch (e: IllegalStateException) {
-            // Just ignore it here, notification will be shown in org.utbot.intellij.plugin.ui.utils.ModuleUtilsKt.jdkVersionBy
-            null
-        }
 }
 
 val PsiClass.packageName: String

utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/ui/GenerateTestsDialogWindow.kt

@@ -141,6 +141,7 @@ import org.utbot.intellij.plugin.ui.utils.testResourceRootTypes
 import org.utbot.intellij.plugin.ui.utils.testRootType
 import org.utbot.intellij.plugin.util.IntelliJApiHelper
 import org.utbot.intellij.plugin.util.extractFirstLevelMembers
+import org.utbot.intellij.plugin.util.findSdkVersion
 
 private const val RECENTS_KEY = "org.utbot.recents"
 
@@ -315,14 +316,8 @@ class GenerateTestsDialogWindow(val model: GenerateTestsModel) : DialogWrapper(m
             label?.let { add(it, BorderLayout.LINE_END) }
         })
 
-    private fun findSdkVersion(): JavaVersion {
-        val moduleSdk = ModuleRootManager.getInstance(model.srcModule).sdk
-        return JavaVersion.tryParse(moduleSdk?.versionString)
-            ?: error("Cannot define sdk version in module ${model.srcModule}")
-    }
-
     override fun createTitlePane(): JComponent? {
-        val sdkVersion = findSdkVersion()
+        val sdkVersion = findSdkVersion(model.srcModule)
         //TODO:SAT-1571 investigate Android Studio specific sdk issues
         if (sdkVersion.feature in minSupportedSdkVersion..maxSupportedSdkVersion || IntelliJApiHelper.isAndroidStudio()) return null
         isOKActionEnabled = false
@@ -374,7 +369,7 @@ class GenerateTestsDialogWindow(val model: GenerateTestsModel) : DialogWrapper(m
                     val isEdited = ShowSettingsUtil.getInstance().editConfigurable(model.project, projectStructure)
                     { projectStructure.select(model.srcModule.name, ClasspathEditor.getName(), true) }
 
-                    val sdkVersion = findSdkVersion()
+                    val sdkVersion = findSdkVersion(model.srcModule)
                     val sdkFixed = isEdited && sdkVersion.feature in minSupportedSdkVersion..maxSupportedSdkVersion
                     if (sdkFixed) {
                         this@SdkNotificationPanel.isVisible = false
@@ -723,7 +718,7 @@ class GenerateTestsDialogWindow(val model: GenerateTestsModel) : DialogWrapper(m
         val libraryInProject =
             findFrameworkLibrary(model.project, model.testModule, selectedTestFramework, LibrarySearchScope.Project)
         val versionInProject = libraryInProject?.libraryName?.parseVersion()
-        val sdkVersion: Int? = findSdkVersion().feature
+        val sdkVersion = findSdkVersion(model.srcModule).feature
 
         val libraryDescriptor = when (selectedTestFramework) {
             Junit4 -> jUnit4LibraryDescriptor(versionInProject)

utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/ui/actions/GenerateTestsAction.kt

@@ -21,6 +21,7 @@ import com.intellij.refactoring.util.classMembers.MemberInfo
 import org.jetbrains.kotlin.idea.core.getPackage
 import org.jetbrains.kotlin.idea.core.util.toPsiDirectory
 import org.jetbrains.kotlin.idea.core.util.toPsiFile
+import org.jetbrains.kotlin.idea.util.module
 import org.utbot.intellij.plugin.util.extractFirstLevelMembers
 import org.utbot.intellij.plugin.util.isVisible
 import java.util.*
@@ -29,6 +30,7 @@ import org.jetbrains.kotlin.utils.addIfNotNull
 import org.utbot.framework.plugin.api.util.LockFile
 import org.utbot.intellij.plugin.models.packageName
 import org.utbot.intellij.plugin.ui.InvalidClassNotifier
+import org.utbot.intellij.plugin.util.findSdkVersionOrNull
 import org.utbot.intellij.plugin.util.isAbstract
 
 class GenerateTestsAction : AnAction(), UpdateInBackground {
@@ -164,6 +166,10 @@ class GenerateTestsAction : AnAction(), UpdateInBackground {
     }
 
     private fun PsiClass.isInvalid(withWarnings: Boolean): Boolean {
+        if (this.module?.let { findSdkVersionOrNull(it) } == null) {
+            if (withWarnings) InvalidClassNotifier.notify("class out of module with defined sdk")
+        }
+
         val isAbstractOrInterface = this.isInterface || this.isAbstract
         if (isAbstractOrInterface) {
             if (withWarnings) InvalidClassNotifier.notify("abstract class or interface ${this.name}")

utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/util/SdkUtils.kt

@@ -0,0 +1,15 @@
+package org.utbot.intellij.plugin.util
+
+import com.intellij.openapi.module.Module
+import com.intellij.openapi.roots.ModuleRootManager
+import com.intellij.util.lang.JavaVersion
+
+fun findSdkVersion(module:Module): JavaVersion =
+    findSdkVersionOrNull(module) ?: error("Cannot define sdk version in module $module")
+
+fun findSdkVersionOrNull(module: Module): JavaVersion? {
+    val moduleSdk = ModuleRootManager.getInstance(module).sdk
+    return JavaVersion.tryParse(moduleSdk?.versionString)
+}
+
+