From 0d24e0e973efb1a35a077de51f48d973dc2fab0f Mon Sep 17 00:00:00 2001 From: Thomas Lopez Date: Mon, 8 Jun 2026 09:40:25 -0400 Subject: [PATCH 01/11] removing useless meta files --- Editor Default Resources/Icons/Scripts.meta | 8 -------- Editor Default Resources/Icons/Toolbar/Actions.meta | 8 -------- 2 files changed, 16 deletions(-) delete mode 100644 Editor Default Resources/Icons/Scripts.meta delete mode 100644 Editor Default Resources/Icons/Toolbar/Actions.meta diff --git a/Editor Default Resources/Icons/Scripts.meta b/Editor Default Resources/Icons/Scripts.meta deleted file mode 100644 index 041945534..000000000 --- a/Editor Default Resources/Icons/Scripts.meta +++ /dev/null @@ -1,8 +0,0 @@ -fileFormatVersion: 2 -guid: 9a8f569ae5f58994da7bf320e27bef77 -folderAsset: yes -DefaultImporter: - externalObjects: {} - userData: - assetBundleName: - assetBundleVariant: diff --git a/Editor Default Resources/Icons/Toolbar/Actions.meta b/Editor Default Resources/Icons/Toolbar/Actions.meta deleted file mode 100644 index c53b5c209..000000000 --- a/Editor Default Resources/Icons/Toolbar/Actions.meta +++ /dev/null @@ -1,8 +0,0 @@ -fileFormatVersion: 2 -guid: 810f39d81d94448499c3345c938475c7 -folderAsset: yes -DefaultImporter: - externalObjects: {} - userData: - assetBundleName: - assetBundleVariant: From 6ad3fb5410d6fb5858f4fd71633b3ee92a920d34 Mon Sep 17 00:00:00 2001 From: Thomas Lopez Date: Mon, 8 Jun 2026 09:44:24 -0400 Subject: [PATCH 02/11] (UAC1005) fixes a direct self-reference cycle in serialized class --- Editor/StateMachines/ShapeState.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Editor/StateMachines/ShapeState.cs b/Editor/StateMachines/ShapeState.cs index 7208a0d6c..2ec7d5520 100644 --- a/Editor/StateMachines/ShapeState.cs +++ b/Editor/StateMachines/ShapeState.cs @@ -7,7 +7,8 @@ namespace UnityEditor.ProBuilder abstract class ShapeState { public static ShapeState s_defaultState; - public ShapeState m_nextState = null; + // UAC1005: direct self-reference cycle in serialized class + [SerializeReference] public ShapeState m_nextState = null; public static DrawShapeTool tool; public static ShapeState StartStateMachine() From 5081ec3f5fe0d295446c5ef31001337a6c4024f7 Mon Sep 17 00:00:00 2001 From: Thomas Lopez Date: Mon, 8 Jun 2026 09:45:47 -0400 Subject: [PATCH 03/11] fixed uss format --- Editor/Resources/ActionOverlay.uss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Editor/Resources/ActionOverlay.uss b/Editor/Resources/ActionOverlay.uss index 4d1498f24..9aa67680f 100644 --- a/Editor/Resources/ActionOverlay.uss +++ b/Editor/Resources/ActionOverlay.uss @@ -90,7 +90,7 @@ max-height: 16px; min-height: 16px; min-width: 16px; - background-position-x: center 0; + background-position-x: center; } #ActionName { From d1f5c2437d49a3574842a91c0c25a6cc671b2270 Mon Sep 17 00:00:00 2001 From: Thomas Lopez Date: Mon, 8 Jun 2026 10:02:51 -0400 Subject: [PATCH 04/11] added inherited doc comment on public API --- Editor/EditorCore/PolyShapeTool.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/Editor/EditorCore/PolyShapeTool.cs b/Editor/EditorCore/PolyShapeTool.cs index 24b4f296d..088b57a3a 100644 --- a/Editor/EditorCore/PolyShapeTool.cs +++ b/Editor/EditorCore/PolyShapeTool.cs @@ -259,6 +259,7 @@ static bool CanCreateNewPolyShape() [EditorTool("Edit PolyShape", typeof(PolyShape))] public class PolyShapeTool : EditorTool { + /// public override bool gridSnapEnabled => true; [MenuItem("Tools/ProBuilder/Edit/Edit PolyShape", true, PreferenceKeys.menuEditor + 10)] From 93a44386f661d7384fb3f83238d68d886885c9e3 Mon Sep 17 00:00:00 2001 From: Thomas Lopez Date: Mon, 8 Jun 2026 10:33:55 -0400 Subject: [PATCH 05/11] moving resources --- Content/Resources/com.unity.probuilder.meta | 8 ++++++++ .../Resources/com.unity.probuilder/Materials.meta | 8 ++++++++ .../Materials/EdgePicker.mat | 0 .../Materials/EdgePicker.mat.meta | 0 .../Materials/EdgePickerURP.mat | 0 .../Materials/EdgePickerURP.mat.meta | 0 .../Materials/FacePicker.mat | 0 .../Materials/FacePicker.mat.meta | 0 .../Materials/FacePickerURP.mat | 0 .../Materials/FacePickerURP.mat.meta | 0 .../Materials/VertexPicker.mat | 0 .../Materials/VertexPicker.mat.meta | 0 .../Materials/VertexPickerURP.mat | 0 .../Materials/VertexPickerURP.mat.meta | 0 Editor/Overlays/ProBuilderActionsOverlay.cs | 2 +- Editor/Resources/com.unity.probuilder.meta | 8 ++++++++ .../{ => com.unity.probuilder}/ActionButton.uxml | 2 +- .../ActionButton.uxml.meta | 0 .../{ => com.unity.probuilder}/ActionOverlay.uss | 0 .../ActionOverlay.uss.meta | 0 Runtime/Core/BuiltinMaterials.cs | 14 +++++++------- 21 files changed, 33 insertions(+), 9 deletions(-) create mode 100644 Content/Resources/com.unity.probuilder.meta create mode 100644 Content/Resources/com.unity.probuilder/Materials.meta rename Content/Resources/{ => com.unity.probuilder}/Materials/EdgePicker.mat (100%) rename Content/Resources/{ => com.unity.probuilder}/Materials/EdgePicker.mat.meta (100%) rename Content/Resources/{ => com.unity.probuilder}/Materials/EdgePickerURP.mat (100%) rename Content/Resources/{ => com.unity.probuilder}/Materials/EdgePickerURP.mat.meta (100%) rename Content/Resources/{ => com.unity.probuilder}/Materials/FacePicker.mat (100%) rename Content/Resources/{ => com.unity.probuilder}/Materials/FacePicker.mat.meta (100%) rename Content/Resources/{ => com.unity.probuilder}/Materials/FacePickerURP.mat (100%) rename Content/Resources/{ => com.unity.probuilder}/Materials/FacePickerURP.mat.meta (100%) rename Content/Resources/{ => com.unity.probuilder}/Materials/VertexPicker.mat (100%) rename Content/Resources/{ => com.unity.probuilder}/Materials/VertexPicker.mat.meta (100%) rename Content/Resources/{ => com.unity.probuilder}/Materials/VertexPickerURP.mat (100%) rename Content/Resources/{ => com.unity.probuilder}/Materials/VertexPickerURP.mat.meta (100%) create mode 100644 Editor/Resources/com.unity.probuilder.meta rename Editor/Resources/{ => com.unity.probuilder}/ActionButton.uxml (83%) rename Editor/Resources/{ => com.unity.probuilder}/ActionButton.uxml.meta (100%) rename Editor/Resources/{ => com.unity.probuilder}/ActionOverlay.uss (100%) rename Editor/Resources/{ => com.unity.probuilder}/ActionOverlay.uss.meta (100%) diff --git a/Content/Resources/com.unity.probuilder.meta b/Content/Resources/com.unity.probuilder.meta new file mode 100644 index 000000000..52145ce91 --- /dev/null +++ b/Content/Resources/com.unity.probuilder.meta @@ -0,0 +1,8 @@ +fileFormatVersion: 2 +guid: 2fd0621f5ae921e44802d0469d771565 +folderAsset: yes +DefaultImporter: + externalObjects: {} + userData: + assetBundleName: + assetBundleVariant: diff --git a/Content/Resources/com.unity.probuilder/Materials.meta b/Content/Resources/com.unity.probuilder/Materials.meta new file mode 100644 index 000000000..574cafc44 --- /dev/null +++ b/Content/Resources/com.unity.probuilder/Materials.meta @@ -0,0 +1,8 @@ +fileFormatVersion: 2 +guid: 048578cfc1b66cf489e58d5d269543d3 +folderAsset: yes +DefaultImporter: + externalObjects: {} + userData: + assetBundleName: + assetBundleVariant: diff --git a/Content/Resources/Materials/EdgePicker.mat b/Content/Resources/com.unity.probuilder/Materials/EdgePicker.mat similarity index 100% rename from Content/Resources/Materials/EdgePicker.mat rename to Content/Resources/com.unity.probuilder/Materials/EdgePicker.mat diff --git a/Content/Resources/Materials/EdgePicker.mat.meta b/Content/Resources/com.unity.probuilder/Materials/EdgePicker.mat.meta similarity index 100% rename from Content/Resources/Materials/EdgePicker.mat.meta rename to Content/Resources/com.unity.probuilder/Materials/EdgePicker.mat.meta diff --git a/Content/Resources/Materials/EdgePickerURP.mat b/Content/Resources/com.unity.probuilder/Materials/EdgePickerURP.mat similarity index 100% rename from Content/Resources/Materials/EdgePickerURP.mat rename to Content/Resources/com.unity.probuilder/Materials/EdgePickerURP.mat diff --git a/Content/Resources/Materials/EdgePickerURP.mat.meta b/Content/Resources/com.unity.probuilder/Materials/EdgePickerURP.mat.meta similarity index 100% rename from Content/Resources/Materials/EdgePickerURP.mat.meta rename to Content/Resources/com.unity.probuilder/Materials/EdgePickerURP.mat.meta diff --git a/Content/Resources/Materials/FacePicker.mat b/Content/Resources/com.unity.probuilder/Materials/FacePicker.mat similarity index 100% rename from Content/Resources/Materials/FacePicker.mat rename to Content/Resources/com.unity.probuilder/Materials/FacePicker.mat diff --git a/Content/Resources/Materials/FacePicker.mat.meta b/Content/Resources/com.unity.probuilder/Materials/FacePicker.mat.meta similarity index 100% rename from Content/Resources/Materials/FacePicker.mat.meta rename to Content/Resources/com.unity.probuilder/Materials/FacePicker.mat.meta diff --git a/Content/Resources/Materials/FacePickerURP.mat b/Content/Resources/com.unity.probuilder/Materials/FacePickerURP.mat similarity index 100% rename from Content/Resources/Materials/FacePickerURP.mat rename to Content/Resources/com.unity.probuilder/Materials/FacePickerURP.mat diff --git a/Content/Resources/Materials/FacePickerURP.mat.meta b/Content/Resources/com.unity.probuilder/Materials/FacePickerURP.mat.meta similarity index 100% rename from Content/Resources/Materials/FacePickerURP.mat.meta rename to Content/Resources/com.unity.probuilder/Materials/FacePickerURP.mat.meta diff --git a/Content/Resources/Materials/VertexPicker.mat b/Content/Resources/com.unity.probuilder/Materials/VertexPicker.mat similarity index 100% rename from Content/Resources/Materials/VertexPicker.mat rename to Content/Resources/com.unity.probuilder/Materials/VertexPicker.mat diff --git a/Content/Resources/Materials/VertexPicker.mat.meta b/Content/Resources/com.unity.probuilder/Materials/VertexPicker.mat.meta similarity index 100% rename from Content/Resources/Materials/VertexPicker.mat.meta rename to Content/Resources/com.unity.probuilder/Materials/VertexPicker.mat.meta diff --git a/Content/Resources/Materials/VertexPickerURP.mat b/Content/Resources/com.unity.probuilder/Materials/VertexPickerURP.mat similarity index 100% rename from Content/Resources/Materials/VertexPickerURP.mat rename to Content/Resources/com.unity.probuilder/Materials/VertexPickerURP.mat diff --git a/Content/Resources/Materials/VertexPickerURP.mat.meta b/Content/Resources/com.unity.probuilder/Materials/VertexPickerURP.mat.meta similarity index 100% rename from Content/Resources/Materials/VertexPickerURP.mat.meta rename to Content/Resources/com.unity.probuilder/Materials/VertexPickerURP.mat.meta diff --git a/Editor/Overlays/ProBuilderActionsOverlay.cs b/Editor/Overlays/ProBuilderActionsOverlay.cs index db221b97a..c5f5c6a5c 100644 --- a/Editor/Overlays/ProBuilderActionsOverlay.cs +++ b/Editor/Overlays/ProBuilderActionsOverlay.cs @@ -14,7 +14,7 @@ namespace UnityEditor.ProBuilder { class ProBuilderActionButton : VisualElement { - const string k_UxmlPath = "Packages/com.unity.probuilder/Editor/Resources/ActionButton.uxml"; + const string k_UxmlPath = "Packages/com.unity.probuilder/Editor/Resources/com.unity.probuilder/ActionButton.uxml"; static VisualTreeAsset s_ButtonAsset; MenuAction m_Action; diff --git a/Editor/Resources/com.unity.probuilder.meta b/Editor/Resources/com.unity.probuilder.meta new file mode 100644 index 000000000..30348381b --- /dev/null +++ b/Editor/Resources/com.unity.probuilder.meta @@ -0,0 +1,8 @@ +fileFormatVersion: 2 +guid: 9e8775346f7b15a49a534d0496d830ec +folderAsset: yes +DefaultImporter: + externalObjects: {} + userData: + assetBundleName: + assetBundleVariant: diff --git a/Editor/Resources/ActionButton.uxml b/Editor/Resources/com.unity.probuilder/ActionButton.uxml similarity index 83% rename from Editor/Resources/ActionButton.uxml rename to Editor/Resources/com.unity.probuilder/ActionButton.uxml index e0642bc3c..de82e6a1a 100644 --- a/Editor/Resources/ActionButton.uxml +++ b/Editor/Resources/com.unity.probuilder/ActionButton.uxml @@ -1,5 +1,5 @@ -