From 735b7b31e2ef4adab7ad3e99f0668f7ea73abede Mon Sep 17 00:00:00 2001 From: Wendy Raschke Date: Fri, 1 Mar 2024 11:28:12 -0600 Subject: [PATCH 1/2] Default placeholder for versions fields can be confusing --- .github/workflows/update_files_for_release.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/update_files_for_release.yml b/.github/workflows/update_files_for_release.yml index bb6e4aa3c..f90e2ba50 100644 --- a/.github/workflows/update_files_for_release.yml +++ b/.github/workflows/update_files_for_release.yml @@ -6,14 +6,11 @@ on: workflow_dispatch: inputs: OLD_VERSION: - description: 'Enter old version' - # Show defaults as examples so user enters correct format. - default: '23.0.0.11' + description: 'Enter old version (what was just released)' required: true type: string NEW_VERSION: - description: 'Enter new version' - default: '23.0.0.12' + description: 'Enter new version (pre-eGA release)' required: true type: string BUILD_LABEL: From 4c3bb55166f156999b56ce17839bdbfc8fa61903 Mon Sep 17 00:00:00 2001 From: Wendy Raschke Date: Fri, 1 Mar 2024 11:39:16 -0600 Subject: [PATCH 2/2] Remove Michal as reviewer --- .github/workflows/update_files_for_release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/update_files_for_release.yml b/.github/workflows/update_files_for_release.yml index f90e2ba50..7e89b84b3 100644 --- a/.github/workflows/update_files_for_release.yml +++ b/.github/workflows/update_files_for_release.yml @@ -52,7 +52,7 @@ jobs: - name: Create Pull Request run: | - gh pr create -B vNext -H "${{ inputs.NEW_VERSION }}-release" -r mbroz2 -r leochr --title "Updates for the release of ${{ inputs.NEW_VERSION }}" --body "Created by Github Actions" + gh pr create -B vNext -H "${{ inputs.NEW_VERSION }}-release" -r leochr --title "Updates for the release of ${{ inputs.NEW_VERSION }}" --body "Created by Github Actions" env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}