fix(metadata): preserve explicit class on ApiResource when propagating defaults#8262
Open
soyuka wants to merge 1 commit into
Open
fix(metadata): preserve explicit class on ApiResource when propagating defaults#8262soyuka wants to merge 1 commit into
soyuka wants to merge 1 commit into
Conversation
…g defaults When `#[ApiResource(class: SomeClass::class)]` is set explicitly, the factory overwrote it with the PHP class name during default propagation, preventing the explicit class from reaching cascaded operations. Fall back to the PHP class name only when no class is set. Fixes api-platform#7187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
#[ApiResource(class: SomeClass::class)]is set explicitly on a resource, the factory was overwriting the user-provided class with the PHP class name during default propagation. As a result, the explicitclassnever reached cascaded operations.The change in
OperationDefaultsTrait::getResourceWithDefaults()now falls back to the PHP class name only when noclassis already set on the resource.Maintainer directive (from issue #7187): "you shouldn't really change the
classbut indeed we should fix this".Reproduction
Before the fix, every operation's
getClass()returnedResourceClassPropagation::class, ignoring the explicit attribute argument. After the fix, both the resource and every cascaded operation exposeResourceClassPropagationTarget::class.Test plan
testCreatePropagatesExplicitResourceClass.AttributesResourceMetadataCollectionFactoryTestclass still green (12 tests, 31 assertions).tests/Functional/OverriddenOperationTest.phpstill green (10 tests, 20 assertions).Fixes #7187