feat(expo): add Android bottom sheet presentation#9216
Draft
swolfand wants to merge 2 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 61e5663 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an opt-in Android presentation mode to the Expo native
AuthView:AuthViewcontinues to render inline by default, so existing full-screen and embedded usages are unchanged. WhenbottomSheetis selected on Android, the Expo native host presents Clerk's existing Compose auth flow in a Material 3 bottom sheet, uses the Clerk theme background, keeps Clerk branding visible in the partially expanded state, and supports expansion and dismissal.Previously, the Expo bridge always mounted the Android auth view as full-parent content. React Native callers could place that content inside a modal, but could not opt into a native Material bottom-sheet presentation without modifying the bridge locally.
Validation:
pnpm turbo build --filter=@clerk/expopnpm turbo test --filter=@clerk/expo(107 tests)pnpm --filter @clerk/expo lint(no errors; existing warnings only)pnpm --filter @clerk/expo format:check