chore(nextjs): Remove useSearchParams usage#2651
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5fa57ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brkalow
requested review from
a team and
panteliselef
and removed request for
a team
Contributor
|
This is currently blocking us from upgrading to Next 14. Hopefully this can be merged soon |
|
Can this be merged? Currently preventing my app from working properly with Next.JS 14 |
Contributor
nikosdouvlis
force-pushed
the
brk.chore/no-use-search-params
branch
from
de14bfd to
5fa57ad
Compare
nikosdouvlis
approved these changes
Feb 2, 2024
nikosdouvlis
pushed a commit
that referenced
this pull request
Feb 2, 2024
* chore(nextjs): Remove useSearchParams usage * feat(nextjs): Implement useAwaitableNavigate with useTransition * chore(repo): Update type dependencies to fix integration build error (cherry picked from commit f68b015)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attempting to avoid CSR de-opt due to
useSearchParams()usage. RefactorsuseAwaitableNavigate()to rely onuseTransitioninstead of Next's route state hooks. This avoids any potential de-opt and provides a more reliable implementation by relying on React's native transition behavior.Fixes SDK-1266
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore