fix(backend): BAPIClients list methods should return { data, totalCount }#2714
Merged
Conversation
🦋 Changeset detectedLatest commit: e4439e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
force-pushed
the
sdk-1260-backend-paginated-return-value
branch
from
3b9cc1a to
fc802ca
Compare
dimkl
changed the title
{ data, totalCount }
…talCount}` This change makes the `users.getUserList()` method invoke 2 requests and may result in data.legth != totalCount in some edge cases.
…ist()` and rename params type
dimkl
force-pushed
the
sdk-1260-backend-paginated-return-value
branch
from
9497ad9 to
e4439e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make all listing API requests to return consistent
{ data: Resource[], totalCount: number }.Support pagination request params
{ limit, offset }to:sessions.getSessionList({ limit, offset })clients.getClientList({ limit, offset })Since the
users.getUserList()does not return thetotal_countas a temporary solution thatmethod will perform 2 BAPI requests:
users.getCount()internally)Fix using
ClerkPaginationRequesttype without passing a generic.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore