fix(clerk-js): Give application logo correct CSS width#2735
Merged
LekoArts merged 2 commits intoFeb 7, 2024
Conversation
🦋 Changeset detectedLatest commit: 8965396 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
octoper
approved these changes
Feb 6, 2024
LekoArts
deleted the
lekoarts/sdk-1298-logo-in-sign-in-component-is-squished
branch
LekoArts
added a commit
that referenced
this pull request
Feb 7, 2024
* fix(clerk-js): Give application logo correct CSS width * Create witty-eggs-punch.md (cherry picked from commit 11fbfde)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Go to SDK 1298 and visit the preview URL with Firefox or Safari. The application logo should be too wide/squished.
Apply the fix of this PR to the
<img />with.logoImageclass and it should look fine.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore