From 874530226c91e15ef833ff9a415c8ed3e5704ce0 Mon Sep 17 00:00:00 2001 From: Bryce Kalow Date: Tue, 19 Nov 2024 16:08:53 -0600 Subject: [PATCH 1/3] fix a bug in the dev CLI where next was not detected unless next.config was present --- packages/dev-cli/src/commands/setup.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dev-cli/src/commands/setup.js b/packages/dev-cli/src/commands/setup.js index 764e64be2ef..543d292df6c 100644 --- a/packages/dev-cli/src/commands/setup.js +++ b/packages/dev-cli/src/commands/setup.js @@ -40,7 +40,7 @@ function hasPackage(packages, dependency) { async function detectFramework() { const { dependencies, devDependencies } = await getDependencies(join(process.cwd(), 'package.json')); - const IS_NEXT = hasFile('next.config.js') || hasFile('next.config.mjs'); + const IS_NEXT = hasFile('next.config.js') || hasFile('next.config.mjs') || hasPackage(dependencies, 'next'); if (IS_NEXT) { return 'nextjs'; } From 9f14c92759e1976280124aaca050696c5ed952fe Mon Sep 17 00:00:00 2001 From: Bryce Kalow Date: Tue, 19 Nov 2024 21:34:42 -0600 Subject: [PATCH 2/3] simplify check --- packages/dev-cli/src/commands/setup.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/dev-cli/src/commands/setup.js b/packages/dev-cli/src/commands/setup.js index 543d292df6c..c739e4ed6aa 100644 --- a/packages/dev-cli/src/commands/setup.js +++ b/packages/dev-cli/src/commands/setup.js @@ -40,7 +40,7 @@ function hasPackage(packages, dependency) { async function detectFramework() { const { dependencies, devDependencies } = await getDependencies(join(process.cwd(), 'package.json')); - const IS_NEXT = hasFile('next.config.js') || hasFile('next.config.mjs') || hasPackage(dependencies, 'next'); + const IS_NEXT = hasPackage(dependencies, 'next'); if (IS_NEXT) { return 'nextjs'; } From 985e4e77c8751d7b64c829b3e78c8314db297cea Mon Sep 17 00:00:00 2001 From: Bryce Kalow Date: Tue, 19 Nov 2024 21:35:30 -0600 Subject: [PATCH 3/3] adds changeset --- .changeset/shaggy-donuts-cry.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/shaggy-donuts-cry.md diff --git a/.changeset/shaggy-donuts-cry.md b/.changeset/shaggy-donuts-cry.md new file mode 100644 index 00000000000..555d224ee0d --- /dev/null +++ b/.changeset/shaggy-donuts-cry.md @@ -0,0 +1,5 @@ +--- +'@clerk/dev-cli': patch +--- + +Fix framework detection for Next.js. `clerk-dev` will now check for `next` as a dependency.