Skip to content

feat(localization): translate deleteOrganization and domainSection objects to Korean#1630

Merged
nikosdouvlis merged 10 commits into
clerk:mainfrom
JungHoonGhae:main
Aug 25, 2023
Merged

feat(localization): translate deleteOrganization and domainSection objects to Korean#1630
nikosdouvlis merged 10 commits into
clerk:mainfrom
JungHoonGhae:main

Conversation

@JungHoonGhae

@JungHoonGhae JungHoonGhae commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: localization

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

Description

  • npm test runs as expected.
  • npm run build runs as expected.

translate deleteOrganization and domainSection objects to Korean

JungHoonGhae and others added 9 commits August 18, 2023 01:13
In the English translation(en-US.ts), the description 'Delete your account and all its associated data' was present. However, this was missing in the Korean translation(ko-KR.ts). 

This update ensures that the Korean translation also includes the information about deleting all data associated with the account.

This change is essential to provide a clearer understanding to users about the consequences of deleting their account.
Update ko-KR.ts (Added Missing Account Deletion Description)
korean userProfile > dangerSection > deleteAccountDescription update
fix formatting error
@changeset-bot

changeset-bot Bot commented Aug 24, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6d7d7eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jit-ci jit-ci Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great news! Jit hasn't found any security issues in your PR. Good Job! 🏆

@nikosdouvlis

Copy link
Copy Markdown
Member

Great stuff, thank you @JungHoonGhae
Merging so we can get this out soon.

@nikosdouvlis
nikosdouvlis merged commit dcabc22 into clerk:main Aug 25, 2023
@clerk-cookie clerk-cookie mentioned this pull request Aug 25, 2023
@clerk-cookie

Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants