Puppeteer firefox to codeceptjs (#1740)

* puppeteer firefox to codeceptjs

* Update Puppeteer.js

* Update Puppeteer-firefox.md

* Update Puppeteer.js

Author: ngadiyak

docs/helpers/Puppeteer-firefox.md

@@ -0,0 +1,55 @@
+# Puppeteer-firefox
+
+Now you can use Puppeteer for Firefox (min version: Firefox/63.0.4)
+
+[Repository](https://github.com/GoogleChrome/puppeteer/tree/master/experimental/puppeteer-firefox)
+
+Some of Puppeteer API methods has not supported in firefox yet. You could check status of them at [Puppeteer API coverage status](https://aslushnikov.github.io/ispuppeteerfirefoxready/)
+
+## Installation
+
+```sh
+npm install puppeteer-firefox
+```
+
+## Configuration
+
+If you want to use puppeteer-firefox, you should add it in Puppeteer section in codecept.conf.js.
+
+- browser: 'chrome' OR 'firefox', 'chrome' is default value
+
+```js
+helpers: {
+        Puppeteer: {
+            browser: process.env.BROWSER || 'firefox',            
+            url: process.env.BASE_URL || 'https://example.com',
+            chrome: {
+                args: [
+                    '--ignore-certificate-errors',
+                ],
+            },
+            firefox: {
+                args: [
+                    '--ignore-certificate-errors'
+                ],
+            },
+        },
+```
+
+## Run-multiple
+
+Example multiple section in codecept.conf.js:
+```js
+ multiple: {
+        parallel: {
+            chunks: process.env.THREADS || 30,
+            browsers: [{
+                browser: 'chrome',
+                windowSize: '1920x1080',
+            }, {
+                browser: 'firefox',
+                windowSize: '1920x1080',
+            }],
+        },
+    },
+```

docs/helpers/Puppeteer.md

@@ -15,6 +15,8 @@ This helper works with a browser out of the box with no additional tools require
 
 Requires `puppeteer` package to be installed.
 
+[Experimental: Puppeteer-firefox](Puppeteer-firefox.md)
+
 ## Configuration
 
 This helper should be configured in codecept.json or codecept.conf.js

docs/puppeteer.md

@@ -6,6 +6,8 @@ title: Testing with Puppeteer
 Among all Selenium alternatives the most interesting emerging ones are tools developed around Google Chrome [DevTools Protocol](https://chromedevtools.github.io/devtools-protocol/). And the most prominent one is [Puppeteer](https://github.com/GoogleChrome/puppeteer).
 It operates over Google Chrome directly without requireing additional tools like ChromeDriver. So tests setup with Puppeteer can be started with npm install only. If you want get faster and simpler to setup tests, Puppeteer would be your choice.
 
+[Experimental: Puppeteer-firefox](helpers/Puppeteer-firefox.md)
+
 CodeceptJS uses Puppeteer to improve end to end testing experience. No need to learn the syntax of a new tool, all drivers in CodeceptJS share the same API.
 
 Take a look at a sample test:

lib/helper/Puppeteer.js

@@ -45,6 +45,7 @@ const consoleLogStore = new Console();
  *
  * This helper should be configured in codecept.json or codecept.conf.js
  *
+ * * `browser`: (optional, default: chrome) - select browser
  * * `url`: base url of website to be tested
  * * `show`: (optional, default: false) - show Google Chrome window for debug.
  * * `restart`: (optional, default: true) - restart browser between tests.
@@ -140,7 +141,8 @@ const consoleLogStore = new Console();
 class Puppeteer extends Helper {
   constructor(config) {
     super(config);
-    puppeteer = requireg('puppeteer');
+
+    puppeteer = requireg(config.browser === 'firefox' ? 'puppeteer-firefox' : 'puppeteer');
 
     // set defaults
     this.isRemoteBrowser = false;
@@ -152,6 +154,7 @@ class Puppeteer extends Helper {
 
   _validateConfig(config) {
     const defaults = {
+      browser: 'chrome',
       waitForAction: 100,
       waitForTimeout: 1000,
       fullPageScreenshots: false,
@@ -170,9 +173,13 @@ class Puppeteer extends Helper {
     return Object.assign(defaults, config);
   }
 
+  _getOptions(config) {
+    return config.browser === 'firefox' ? this.options.firefox : this.options.chrome;
+  }
+
   _setConfig(config) {
     this.options = this._validateConfig(config);
-    this.puppeteerOptions = Object.assign({ headless: !this.options.show }, this.options.chrome);
+    this.puppeteerOptions = Object.assign({ headless: !this.options.show }, this._getOptions(config));
     this.isRemoteBrowser = !!this.puppeteerOptions.browserWSEndpoint;
     popupStore.defaultAction = this.options.defaultPopupAction;
   }
@@ -185,6 +192,7 @@ class Puppeteer extends Helper {
 
   static _checkRequirements() {
     try {
+
       requireg('puppeteer');
     } catch (e) {
       return ['puppeteer@^1.6.0'];
@@ -340,7 +348,9 @@ class Puppeteer extends Helper {
     if (!page) return;
     page.setDefaultNavigationTimeout(this.options.getPageTimeout);
     this.context = await this.page.$('body');
-    await page.bringToFront();
+    if (this.config.browser === 'chrome') {
+      await page.bringToFront();
+    }
   }
 
   /**