From f01bec6e52d96b9bcf15c315343e3a463b69be5b Mon Sep 17 00:00:00 2001 From: Peter Nguyen Tr Date: Thu, 2 Apr 2020 08:30:53 +0200 Subject: [PATCH 1/4] (fix): undefined in screenshot name --- lib/plugin/screenshotOnFail.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/plugin/screenshotOnFail.js b/lib/plugin/screenshotOnFail.js index d9144d06e..fddfea643 100644 --- a/lib/plugin/screenshotOnFail.js +++ b/lib/plugin/screenshotOnFail.js @@ -129,7 +129,7 @@ module.exports = function (config) { return test.uuid; } - if (test.ctx) { + if (test.ctx && test.ctx.test.uuid) { return test.ctx.test.uuid; } From aff8ba42c8c8422793614a8d50a13c07e2cdd491 Mon Sep 17 00:00:00 2001 From: Peter Nguyen Tr Date: Thu, 2 Apr 2020 15:15:25 +0200 Subject: [PATCH 2/4] add test for case uuid is null --- test/unit/plugin/screenshotOnFail_test.js | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/test/unit/plugin/screenshotOnFail_test.js b/test/unit/plugin/screenshotOnFail_test.js index 6412c47d6..06349ad5c 100644 --- a/test/unit/plugin/screenshotOnFail_test.js +++ b/test/unit/plugin/screenshotOnFail_test.js @@ -43,6 +43,17 @@ describe('screenshotOnFail', () => { assert.ok(screenshotSaved.called); assert.equal('test1_1.failed.png', screenshotSaved.getCall(0).args[0]); }); + + it('should create screenshot with unique name when uuid is null', async () => { + screenshotOnFail({ uniqueScreenshotNames: true }); + event.dispatcher.emit(event.test.failed, { title: 'test1' }); + await recorder.promise(); + assert.ok(screenshotSaved.called); + const fileName = screenshotSaved.getCall(0).args[0]; + const regexpFileName = /test1_[0-9]{10}.failed.png/; + assert.equal(fileName.match(regexpFileName).length, 1); + }); + // TODO: write more tests for different options }); From 93e00cc99775414045245d7463080d84ac4637a2 Mon Sep 17 00:00:00 2001 From: Peter Nguyen Tr Date: Thu, 2 Apr 2020 15:16:15 +0200 Subject: [PATCH 3/4] fix lint issue --- test/unit/plugin/screenshotOnFail_test.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/unit/plugin/screenshotOnFail_test.js b/test/unit/plugin/screenshotOnFail_test.js index 06349ad5c..324d9f224 100644 --- a/test/unit/plugin/screenshotOnFail_test.js +++ b/test/unit/plugin/screenshotOnFail_test.js @@ -54,6 +54,5 @@ describe('screenshotOnFail', () => { assert.equal(fileName.match(regexpFileName).length, 1); }); - // TODO: write more tests for different options }); From c6939110835b500d3564d60285fefea432465ab1 Mon Sep 17 00:00:00 2001 From: Peter Nguyen Tr Date: Thu, 2 Apr 2020 15:18:45 +0200 Subject: [PATCH 4/4] fix lint issue --- test/unit/plugin/screenshotOnFail_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/plugin/screenshotOnFail_test.js b/test/unit/plugin/screenshotOnFail_test.js index 324d9f224..6c47c1dc7 100644 --- a/test/unit/plugin/screenshotOnFail_test.js +++ b/test/unit/plugin/screenshotOnFail_test.js @@ -43,7 +43,7 @@ describe('screenshotOnFail', () => { assert.ok(screenshotSaved.called); assert.equal('test1_1.failed.png', screenshotSaved.getCall(0).args[0]); }); - + it('should create screenshot with unique name when uuid is null', async () => { screenshotOnFail({ uniqueScreenshotNames: true }); event.dispatcher.emit(event.test.failed, { title: 'test1' });