Remove redundant #if NET in CollectionHelpers.ValidateCopyToArguments#128464
Open
iikuzmychov wants to merge 1 commit into
Open
Remove redundant #if NET in CollectionHelpers.ValidateCopyToArguments#128464iikuzmychov wants to merge 1 commit into
#if NET in CollectionHelpers.ValidateCopyToArguments#128464iikuzmychov wants to merge 1 commit into
Conversation
Both branches of the conditional called ArgumentNullException.ThrowIfNull(array) identically, so the #if/#else served no purpose.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes redundant conditional compilation around a null check in CollectionHelpers, simplifying the method without changing behavior.
Changes:
- Deleted
#if NET / #else / #endifdirectives that wrapped identical code. - Kept a single
ArgumentNullException.ThrowIfNull(array);call.
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-collections |
iikuzmychov
changed the title
#if NET in CollectionHelpers.ValidateCopyToArguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both branches of the first
#if NET/#elseinCollectionHelpers.ValidateCopyToArgumentscalledArgumentNullException.ThrowIfNull(array);identically. Removed the preprocessor split.