[TEST] Improve SqlDataRecord DateOnly and TimeOnly coverage#3128
Conversation
Make SqlDecimalConvertToDecimal_TestInRange run on non-US systems fixes dotnet#3125 related to dotnet#2258
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@ErikEJ looking into the test failures more, it looks like they're genuine failures of the test related to the changes you made. The value itself looks to be correct but the formatting is wrong. Looks like it's possible the assert isn't doing the right comparison? |
benrr101
left a comment
benrr101
left a comment
There was a problem hiding this comment.
Holding until the unit tests are fixed
|
@benrr101 Thanks - it is SO hard to locate the actual errors |
|
@benrr101 I had made the .NET Framework test pass locally 😆 |
|
@benrr101 Tests are passing now! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@ErikEJ Hmm, it looks like there's still an issue with the cast on netfx |
|
@benrr101 OMG - the pipeline never ran - I will investigate, thanks |
|
@dotnet/sqlclientdevteam Pls kick the CI 🙏 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@benrr101 Failing test seems unrelated ?? |
Agreed, it seems to be so. I'll proceed to kick it until its behavior improves. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3128 +/- ##
==========================================
- Coverage 72.73% 66.14% -6.59%
==========================================
Files 283 279 -4
Lines 58997 58945 -52
==========================================
- Hits 42910 38989 -3921
- Misses 16087 19956 +3869
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
benrr101
left a comment
benrr101
left a comment
There was a problem hiding this comment.
Test passing, LFG 🚢 🚢 🚢
5 participants
Make SqlDecimalConvertToDecimal_TestInRange run on non-US systems
fixes #3125
related to #2258