Skip to content

Handle nested Fragments in toTree (#12106)#12107

Merged
aweary merged 1 commit into
react:masterfrom
maciej-ka:handle-nested-fragments-in-to-tree
Jan 27, 2018
Merged

Handle nested Fragments in toTree (#12106)#12107
aweary merged 1 commit into
react:masterfrom
maciej-ka:handle-nested-fragments-in-to-tree

Conversation

@maciej-ka

@maciej-ka maciej-ka commented Jan 27, 2018

Copy link
Copy Markdown
Contributor

Resolves #12106

@aweary aweary merged commit ef8d6d9 into react:master Jan 27, 2018
@gaearon

gaearon commented Feb 5, 2018

Copy link
Copy Markdown
Collaborator

This was not a sufficient fix. Please see #12154.

@maciej-ka maciej-ka deleted the handle-nested-fragments-in-to-tree branch February 5, 2018 12:16
@aweary

aweary commented Feb 5, 2018

Copy link
Copy Markdown
Contributor

Woops 😬

@maciej-ka

Copy link
Copy Markdown
Contributor Author

I'm feeling worse about this than I probably should.

@aweary

aweary commented Feb 5, 2018

Copy link
Copy Markdown
Contributor

@maciej-ka don't feel bad at all! This was a great start and it was my responsibility to review and help you. This is solely my fault, and we really appreciate the contribution 🙂

@gaearon

gaearon commented Feb 5, 2018

Copy link
Copy Markdown
Collaborator

Yeah this was a comment for @aweary 😛 Didn't mean to make you feel bad, thank you for helping! This is kind of a thorny issue and the code is not easiest to follow.

This was referenced Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants