Skip to content

Changelog for 16.9#16254

Merged
acdlite merged 3 commits into
masterfrom
gaearon-patch-1
Aug 8, 2019
Merged

Changelog for 16.9#16254
acdlite merged 3 commits into
masterfrom
gaearon-patch-1

Conversation

@gaearon

@gaearon gaearon commented Jul 30, 2019

Copy link
Copy Markdown
Collaborator

React

  • Add <React.Profiler> API for gathering performance measurements programmatically. (@bvaughn in #15172)
  • Remove unstable_ConcurrentMode in favor of unstable_createRoot. (@acdlite in #15532)

React DOM

React DOM Server

  • Fix incorrect output for camelCase custom CSS property names. (@bedakb in #16167)

React Test Utilities and Test Renderer

@sizebot

sizebot commented Jul 30, 2019

Copy link
Copy Markdown

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@seraj

seraj commented Jul 30, 2019

Copy link
Copy Markdown
  • Warn when setState is called from useEffect, creating a loop. (@gaearon in #15180)

thanks for this @gaearon

Comment thread CHANGELOG.md Outdated
@Go7hic

Go7hic commented Aug 1, 2019

Copy link
Copy Markdown

AsyncMode -> ConcurrentMode ->createRoot -> ?
When will it be stable

@gaearon

gaearon commented Aug 2, 2019

Copy link
Copy Markdown
Collaborator Author

@Go7hic When it's stable, you will see it in release notes. :-) We can't predict the future, but we're working to ship it. There's still more work ahead.

@radex

radex commented Aug 2, 2019

Copy link
Copy Markdown

Deprecate javascript: URLs as a common attack surface.

Is there something I can call to make javascript: urls an error, not a warning? Or does the feature flag require a special build of React to enable this?

EDIT: AFAICT not really — in react tests there’s:

const ReactFeatureFlags = require('shared/ReactFeatureFlags');
ReactFeatureFlags.disableJavaScriptURLs = true;

but i don’t think it will work in actual react builds.

I would be highly in favor of adding a function like import { disableJavascriptUrls } from react for this. Given how common and easy it is to have a huge XSS hole in links, I don’t think it’s appropriate to wait until React 17 when the feature is already there. A function with a recommendation to use it in the CHANGELOG (but still opt-in to preserve semver) seems like the best choice.

@gaearon

gaearon commented Aug 2, 2019

Copy link
Copy Markdown
Collaborator Author

You can always do custom builds of React from master. (Even from the same commits that go out in a release.) And toggle it on. That's what we do. We generally don't allow runtime configuration because it doesn't compose well. Like if you have several apps on one page.

@lifeiscontent

Copy link
Copy Markdown

@gaearon are you guys working on ReactDOMServer Suspense Support? Where is it in the queue?

@gaearon

gaearon commented Aug 5, 2019

Copy link
Copy Markdown
Collaborator Author

@gaearon are you guys working on ReactDOMServer Suspense Support? Where is it in the queue?

We've added initial infrastructure but haven't started on the implementation yet. Please let's keep this thread focused on the 16.9 release.

@Andarist

Andarist commented Aug 5, 2019

Copy link
Copy Markdown
Contributor

Seems like async act won't help solve this one, right? As setState gets called in promise handlers internally there is no way for act to wrap it.

@6graNik

6graNik commented Aug 6, 2019

Copy link
Copy Markdown
  • Warn when setState is called from useEffect, creating a loop. (@gaearon in #15180)

thanks for this @gaearon

Don't forget who was the first mentioning this issue for core team, lol

https://twitter.com/6graNik/status/1060898694092988421

@BZ-koko

BZ-koko commented Aug 6, 2019

Copy link
Copy Markdown

Good Job

@threepointone

threepointone commented Aug 6, 2019

Copy link
Copy Markdown
Contributor

Seems like async act won't help solve this one, right? As setState gets called in promise handlers internally there is no way for act to wrap it.

@Andarist this is a great usecase for async act. made a PR with a fix and some notes - final-form/react-final-form#578

@mdrideout

Copy link
Copy Markdown

Is there anything significant new feature I should learn for this release? (Like hooks / suspense on previous releases)?

@gaearon

gaearon commented Aug 6, 2019

Copy link
Copy Markdown
Collaborator Author

There will be a blog post, but this release is relatively minor in terms of new features.

@bvaughn

bvaughn commented Aug 6, 2019

Copy link
Copy Markdown
Contributor

@gaearon: Did we intentionally omit mention of unstable_createSyncRoot ?

@gaearon gaearon changed the title Changelog for 16.9 (TODO: add date) Changelog for 16.9 Aug 8, 2019
@gaearon gaearon mentioned this pull request Aug 8, 2019
9 tasks
This was referenced Mar 9, 2020
@kassens kassens deleted the gaearon-patch-1 branch November 29, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.