Skip to content

Commit d29ab25

Browse files
committed
chore(fdc): Fix linting issues, imports ordering, and formatting in dataconnect
1 parent 9a7a4bc commit d29ab25

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

firebase_admin/dataconnect.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ def _validate_variables_type(
222222
variable_type: Optional[Type[Any]] = None
223223
) -> None:
224224
"""Validates variables against expected type."""
225-
if variables is not None:
225+
if variables is not None:
226226
if not (isinstance(variables, Mapping) or is_dataclass(variables)):
227227
raise ValueError("variables must be a collections.abc.Mapping or a dataclass")
228228
if variable_type is not None:

tests/test_data_connect.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@
1414

1515
"""Test cases for the firebase_admin.dataconnect module."""
1616

17-
from unittest import mock
1817
from dataclasses import dataclass
18+
from typing import Any, Dict, Mapping
19+
from unittest import mock
20+
1921
from google.auth import credentials as google_auth_credentials
2022
import pytest
2123

@@ -442,7 +444,6 @@ def test_validate_graphql_options_valid_mapping_variables(self):
442444
self.api_client._validate_graphql_options(options)
443445

444446
def test_validate_graphql_options_valid_generic_variables(self):
445-
from typing import Any, Dict, Mapping
446447
options = dataconnect.GraphqlOptions(variables={"user_id": "1", "name": "Fred"})
447448
self.api_client._validate_graphql_options(options, Dict[str, Any])
448449
self.api_client._validate_graphql_options(options, Mapping[str, Any])
@@ -533,7 +534,6 @@ class CreateUserVariables:
533534
self.api_client._validate_graphql_options(options, (list, tuple))
534535

535536
# Test type mismatch when a dataclass is passed but a Dict is expected
536-
from typing import Dict, Any
537537
profile_val = UserProfile(address="123 Road", phone="332-3233-0199")
538538
valid_variables = CreateUserVariables(
539539
user_id="1", name="Fred", profile=profile_val

0 commit comments

Comments
 (0)