Skip to content

Some compile-time optimizations; particularly for larger structs#675

Merged
liuzicheng1987 merged 21 commits into
mainfrom
f/compile_time_optimization
Jun 7, 2026
Merged

Some compile-time optimizations; particularly for larger structs#675
liuzicheng1987 merged 21 commits into
mainfrom
f/compile_time_optimization

Conversation

@liuzicheng1987

Copy link
Copy Markdown
Contributor

No description provided.

@liuzicheng1987 liuzicheng1987 merged commit fbb05d7 into main Jun 7, 2026
386 of 388 checks passed
@liuzicheng1987 liuzicheng1987 deleted the f/compile_time_optimization branch June 7, 2026 14:26

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restructures the parsing module by splitting monolithic parser specializations into distinct parser structs and dispatching to them using new type traits within Parser_default.hpp. The review feedback is highly constructive, pointing out a compilation error in Parser_default.hpp where the is_short_v branch in to_schema is left empty. Additionally, the reviewer suggests adding missing <type_traits> headers and updating the is_string_map_v and is_positional_v traits to use std::remove_cvref_t to ensure robust type matching for cv-qualified or reference types.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread include/rfl/parsing/Parser_default.hpp
Comment thread include/rfl/parsing/is_string_map.hpp
Comment thread include/rfl/parsing/is_string_map.hpp
Comment thread include/rfl/parsing/ParserPositional.hpp
Comment thread include/rfl/parsing/ParserPositional.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant