feat: Remove Otel from fsIntegration (#21654)

- Closes #20750

This PR doesn't actually use orchestrion. 

Becuase `fs` in a Node built-in, it is CJS and can therfore be monkey
patched like it's 2005.

Author: timfish

dev-packages/node-integration-tests/suites/fs-instrumentation/server.ts

@@ -103,6 +103,16 @@ app.get('/mkdtemp', async (_, res) => {
   res.send('done');
 });
 
+app.get('/exists', async (_, res) => {
+  await new Promise<void>(resolve => {
+    fs.exists(path.join(__dirname, 'fixtures', 'some-file.txt'), () => {
+      resolve();
+    });
+  });
+  await util.promisify(fs.exists)(path.join(__dirname, 'fixtures', 'some-file-promisify.txt'));
+  res.send('done');
+});
+
 app.get('/symlink', async (_, res) => {
   await new Promise<void>(resolve => {
     fs.symlink(

dev-packages/node-integration-tests/suites/fs-instrumentation/test.ts

@@ -272,6 +272,42 @@ test('should create spans for fs operations that take target argument', async ()
   await runner.completed();
 });
 
+test('should create spans for fs.exists callback and promisified versions', async () => {
+  const runner = createRunner(__dirname, 'server.ts')
+    .expect({
+      transaction: {
+        transaction: 'GET /exists',
+        spans: expect.arrayContaining([
+          expect.objectContaining({
+            description: 'fs.exists',
+            op: 'file',
+            status: 'ok',
+            data: {
+              path_argument: expect.stringMatching('/fixtures/some-file.txt'),
+              [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'file',
+              [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.file.fs',
+            },
+          }),
+          expect.objectContaining({
+            description: 'fs.exists',
+            op: 'file',
+            status: 'ok',
+            data: {
+              path_argument: expect.stringMatching('/fixtures/some-file-promisify.txt'),
+              [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'file',
+              [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.file.fs',
+            },
+          }),
+        ]),
+      },
+    })
+    .start();
+
+  const result = await runner.makeRequest('get', '/exists');
+  expect(result).toEqual('done');
+  await runner.completed();
+});
+
 test('records file path but not error messages when only `recordFilePaths` is enabled', async () => {
   const runner = createRunner(__dirname, 'server-record-paths-only.ts')
     .expect({

packages/node/src/integrations/fs/index.ts

@@ -1,6 +1,6 @@
 import { defineIntegration } from '@sentry/core';
-import { generateInstrumentOnce } from '@sentry/node-core';
-import { FsInstrumentation } from './vendored/instrumentation';
+import { enableFsInstrumentation } from './vendored/instrumentation';
+import type { FsInstrumentationConfig } from './vendored/types';
 
 const INTEGRATION_NAME = 'FileSystem';
 
@@ -13,36 +13,11 @@ const INTEGRATION_NAME = 'FileSystem';
  *
  * @param options Configuration for this integration.
  */
-export const fsIntegration = defineIntegration(
-  (
-    options: {
-      /**
-       * Setting this option to `true` will include any filepath arguments from your `fs` API calls as span attributes.
-       *
-       * Defaults to `false`.
-       */
-      recordFilePaths?: boolean;
-
-      /**
-       * Setting this option to `true` will include the error messages of failed `fs` API calls as a span attribute.
-       *
-       * Defaults to `false`.
-       */
-      recordErrorMessagesAsSpanAttributes?: boolean;
-    } = {},
-  ) => {
-    return {
-      name: INTEGRATION_NAME,
-      setupOnce() {
-        generateInstrumentOnce(
-          INTEGRATION_NAME,
-          () =>
-            new FsInstrumentation({
-              recordFilePaths: options.recordFilePaths,
-              recordErrorMessagesAsSpanAttributes: options.recordErrorMessagesAsSpanAttributes,
-            }),
-        )();
-      },
-    };
-  },
-);
+export const fsIntegration = defineIntegration((options: FsInstrumentationConfig = {}) => {
+  return {
+    name: INTEGRATION_NAME,
+    setupOnce() {
+      enableFsInstrumentation(options);
+    },
+  };
+});